From patchwork Mon Dec 16 07:58:42 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shinas Rasheed X-Patchwork-Id: 13909347 X-Patchwork-Delegate: kuba@kernel.org Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70C9B203D44; Mon, 16 Dec 2024 07:59:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=67.231.156.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335958; cv=none; b=oHYV/ldwE4CkU0A64/QK1KDIOmX5bGRL28VVa2gSuMasEin/uod0wyEQuCQgZjUR7/o9kerUjzR8yU6ni/muKg/OF0Yi4qKI2si67AE4iahzYz8C/4K+aYFxY8SyF8xVM2z2l3qI4lk8a0jV4haCLC+VDlifO1Z7Z6Mn+EO9saY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734335958; c=relaxed/simple; bh=hWiwd352gG0Jk0qYwP9z+eCt7x1/kt+aXvZiIcs7bqo=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=HpwEGLFnTucVx91f0IMROKGJUIBLtljiO7VRqhuWxYKEcgLvkc8Amq5lw0wLz1aDjlc4O1VjX+5/wdRxPW+CjDbtF99LPBbLqL0ZRWGP2DE7dsP7Xy8TJpOY9giX58XQYH4jYALxHjJfqwZH/+KfJdyavZbugJfif/eHnjv5Kc0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com; spf=pass smtp.mailfrom=marvell.com; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b=IiyXc+Iv; arc=none smtp.client-ip=67.231.156.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=marvell.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=marvell.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=marvell.com header.i=@marvell.com header.b="IiyXc+Iv" Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4BG7DmDa020853; Sun, 15 Dec 2024 23:58:54 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=o wPjE3bRvlhjpMJO1d2yUzHys/+I4YY3gxyhpf/M1bw=; b=IiyXc+Ivcb260XPS/ 5hCeFIPdMcuhnGa/7RjQ1uiJqY7H/Tg/qn2H228mHqV63zWRK0E5OvG2Iip6pdZ7 AVmbsnKgijTmlW9+21m4FfpIls3rhAQgjTlMDDtXMIKiI1GtHBXLuLpvuBKi5YCa +UgFEkRkD4Jn9aR1aQaBlA6ZYut0lAvW7uKNz2/8PE2Cqh3dsYSXYJZBkV2OCNe1 uI5gJJmlda+ctkzDtPW6EYukzmFBum7gXmFvmsxUObG4/HFGLwL7eBX/JtKTPNIN Ssg/Zuzugz1E5qtrDwY0UT44rN18LjNeYnP6JO4Pw3enbtQq2ObPe+nzb+beyUmY XM0YA== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 43hadjrgu2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Dec 2024 23:58:53 -0800 (PST) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 15 Dec 2024 23:58:53 -0800 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Sun, 15 Dec 2024 23:58:53 -0800 Received: from ubuntu-PowerEdge-T110-II.sclab.marvell.com (unknown [10.106.27.86]) by maili.marvell.com (Postfix) with ESMTP id 5AF9D3F7091; Sun, 15 Dec 2024 23:58:52 -0800 (PST) From: Shinas Rasheed To: , CC: , , , , , , , , , "Shinas Rasheed" , Veerasenareddy Burru , Satananda Burla , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Subject: [PATCH net v2 4/4] octeon_ep_vf: remove firmware stats fetch in ndo_get_stats64 Date: Sun, 15 Dec 2024 23:58:42 -0800 Message-ID: <20241216075842.2394606-5-srasheed@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241216075842.2394606-1-srasheed@marvell.com> References: <20241216075842.2394606-1-srasheed@marvell.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Proofpoint-GUID: CG0_WbA_rzFsAGu7zIRDOM0YGH3TO9t0 X-Proofpoint-ORIG-GUID: CG0_WbA_rzFsAGu7zIRDOM0YGH3TO9t0 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Patchwork-Delegate: kuba@kernel.org The per queue stats are available already and are retrieved from register reads during ndo_get_stats64. The firmware stats fetch call that happens in ndo_get_stats64() is currently not required Fixes: c3fad23cdc06 ("octeon_ep_vf: add support for ndo ops") Signed-off-by: Shinas Rasheed --- V2: - No changes V1: https://lore.kernel.org/all/20241203072130.2316913-5-srasheed@marvell.com/ drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c index e6253f85b623..75dd3bd2b9ba 100644 --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c @@ -800,14 +800,6 @@ static void octep_vf_get_stats64(struct net_device *netdev, stats->tx_bytes = tx_bytes; stats->rx_packets = rx_packets; stats->rx_bytes = rx_bytes; - if (!octep_vf_get_if_stats(oct)) { - stats->multicast = oct->iface_rx_stats.mcast_pkts; - stats->rx_errors = oct->iface_rx_stats.err_pkts; - stats->rx_dropped = oct->iface_rx_stats.dropped_pkts_fifo_full + - oct->iface_rx_stats.err_pkts; - stats->rx_missed_errors = oct->iface_rx_stats.dropped_pkts_fifo_full; - stats->tx_dropped = oct->iface_tx_stats.dropped; - } } /**