diff mbox series

[net-next,v2,4/4] net: hisilicon: hns: Remove unused enums

Message ID 20241218163341.40297-5-linux@treblig.org (mailing list archive)
State Accepted
Commit 8973ce189376e41ddd398fab0ba8dc8b14e50cd0
Delegated to: Netdev Maintainers
Headers show
Series hisilicon hns deadcoding | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers warning 1 maintainers not CCed: rosenp@gmail.com
netdev/build_clang success Errors and warnings before: 162 this patch: 162
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 29 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2024-12-19--12-00 (tests: 881)

Commit Message

Dr. David Alan Gilbert Dec. 18, 2024, 4:33 p.m. UTC 
From: "Dr. David Alan Gilbert" <linux@treblig.org>

The enums dsaf_roce_port_mode, dsaf_roce_port_num and dsaf_roce_qos_sl
are unused after the removal of the reset code.

Remove them.

Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
 .../ethernet/hisilicon/hns/hns_dsaf_main.h    | 23 -------------------
 1 file changed, 23 deletions(-)

Comments

Jijie Shao Dec. 19, 2024, 12:30 p.m. UTC | #1 
on 2024/12/19 0:33, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The enums dsaf_roce_port_mode, dsaf_roce_port_num and dsaf_roce_qos_sl
> are unused after the removal of the reset code.
>
> Remove them.

Thanks,

Reviewed-by: Jijie Shao<shaojijie@huawei.com>


>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> ---
>   .../ethernet/hisilicon/hns/hns_dsaf_main.h    | 23 -------------------
>   1 file changed, 23 deletions(-)
>
> diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> index bb8267aafc43..653dfbb25d1b 100644
> --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
> @@ -42,29 +42,6 @@ struct hns_mac_cb;
>   
>   #define HNS_MAX_WAIT_CNT 10000
>   
> -enum dsaf_roce_port_mode {
> -	DSAF_ROCE_6PORT_MODE,
> -	DSAF_ROCE_4PORT_MODE,
> -	DSAF_ROCE_2PORT_MODE,
> -	DSAF_ROCE_CHAN_MODE_NUM,
> -};
> -
> -enum dsaf_roce_port_num {
> -	DSAF_ROCE_PORT_0,
> -	DSAF_ROCE_PORT_1,
> -	DSAF_ROCE_PORT_2,
> -	DSAF_ROCE_PORT_3,
> -	DSAF_ROCE_PORT_4,
> -	DSAF_ROCE_PORT_5,
> -};
> -
> -enum dsaf_roce_qos_sl {
> -	DSAF_ROCE_SL_0,
> -	DSAF_ROCE_SL_1,
> -	DSAF_ROCE_SL_2,
> -	DSAF_ROCE_SL_3,
> -};
> -
>   #define DSAF_STATS_READ(p, offset) (*((u64 *)((u8 *)(p) + (offset))))
>   #define HNS_DSAF_IS_DEBUG(dev) ((dev)->dsaf_mode == DSAF_MODE_DISABLE_SP)
>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
index bb8267aafc43..653dfbb25d1b 100644
--- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
+++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.h
@@ -42,29 +42,6 @@  struct hns_mac_cb;
 
 #define HNS_MAX_WAIT_CNT 10000
 
-enum dsaf_roce_port_mode {
-	DSAF_ROCE_6PORT_MODE,
-	DSAF_ROCE_4PORT_MODE,
-	DSAF_ROCE_2PORT_MODE,
-	DSAF_ROCE_CHAN_MODE_NUM,
-};
-
-enum dsaf_roce_port_num {
-	DSAF_ROCE_PORT_0,
-	DSAF_ROCE_PORT_1,
-	DSAF_ROCE_PORT_2,
-	DSAF_ROCE_PORT_3,
-	DSAF_ROCE_PORT_4,
-	DSAF_ROCE_PORT_5,
-};
-
-enum dsaf_roce_qos_sl {
-	DSAF_ROCE_SL_0,
-	DSAF_ROCE_SL_1,
-	DSAF_ROCE_SL_2,
-	DSAF_ROCE_SL_3,
-};
-
 #define DSAF_STATS_READ(p, offset) (*((u64 *)((u8 *)(p) + (offset))))
 #define HNS_DSAF_IS_DEBUG(dev) ((dev)->dsaf_mode == DSAF_MODE_DISABLE_SP)