| Message ID | 20250102174002.200538-1-linux@treblig.org (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/apply | fail | Patch does not apply to net-next-1 |
On Thu, 2 Jan 2025 17:40:02 +0000 linux@treblig.org wrote: > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of > commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)") > > but has remained unused. > > The functions it references are still referenced elsewhere. > > Remove it. This one doesn't apply, reportedly.
* Jakub Kicinski (kuba@kernel.org) wrote: > On Thu, 2 Jan 2025 17:40:02 +0000 linux@treblig.org wrote: > > From: "Dr. David Alan Gilbert" <linux@treblig.org> > > > > The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of > > commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)") > > > > but has remained unused. > > > > The functions it references are still referenced elsewhere. > > > > Remove it. > Hi Jakub, > This one doesn't apply, reportedly. Hmm, do you have a link to that report, or to which tree I should try applying it to. Dave > -- > pw-bot: cr
On Sat, 4 Jan 2025 21:56:24 +0000 Dr. David Alan Gilbert wrote: > > This one doesn't apply, reportedly. > > Hmm, do you have a link to that report, or to which tree I should try > applying it to. net-next, the tree in the subject prefix: $ git checkout net-next/main $ wget 'https://lore.kernel.org/all/20250102174002.200538-1-linux@treblig.org/raw' Saving 'raw' $ git am raw Applying: ixgbevf: Remove unused ixgbevf_hv_mbx_ops error: patch failed: drivers/net/ethernet/intel/ixgbevf/ixgbevf.h:439 error: drivers/net/ethernet/intel/ixgbevf/ixgbevf.h: patch does not apply Patch failed at 0001 ixgbevf: Remove unused ixgbevf_hv_mbx_ops
* Jakub Kicinski (kuba@kernel.org) wrote: > On Sat, 4 Jan 2025 21:56:24 +0000 Dr. David Alan Gilbert wrote: > > > This one doesn't apply, reportedly. > > > > Hmm, do you have a link to that report, or to which tree I should try > > applying it to. > > net-next, the tree in the subject prefix: > > $ git checkout net-next/main Thanks > $ wget 'https://lore.kernel.org/all/20250102174002.200538-1-linux@treblig.org/raw' > Saving 'raw' > $ git am raw > Applying: ixgbevf: Remove unused ixgbevf_hv_mbx_ops > error: patch failed: drivers/net/ethernet/intel/ixgbevf/ixgbevf.h:439 > error: drivers/net/ethernet/intel/ixgbevf/ixgbevf.h: patch does not apply > Patch failed at 0001 ixgbevf: Remove unused ixgbevf_hv_mbx_ops Oh I see, it's the e610 patch that crept in and just changed the context and moved the lines down a bit; not built it yet, but I'll cut a new version. See below. Dave diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h index 9b37f354d78c..4384e892f967 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h @@ -443,7 +443,6 @@ extern const struct ixgbevf_info ixgbevf_X540_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550EM_x_vf_hv_info; extern const struct ixgbevf_info ixgbevf_e610_vf_hv_info; -extern const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops; /* needed by ethtool.c */ extern const char ixgbevf_driver_name[]; vs diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h index 130cb868774c..a43cb500274e 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h @@ -439,7 +439,6 @@ extern const struct ixgbevf_info ixgbevf_82599_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X540_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550EM_x_vf_hv_info; -extern const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops; /* needed by ethtool.c */ extern const char ixgbevf_driver_name[];
* Jakub Kicinski (kuba@kernel.org) wrote: > On Sat, 4 Jan 2025 21:56:24 +0000 Dr. David Alan Gilbert wrote: > > > This one doesn't apply, reportedly. > > > > Hmm, do you have a link to that report, or to which tree I should try > > applying it to. > > net-next, the tree in the subject prefix: > > $ git checkout net-next/main > $ wget 'https://lore.kernel.org/all/20250102174002.200538-1-linux@treblig.org/raw' > Saving 'raw' > $ git am raw > Applying: ixgbevf: Remove unused ixgbevf_hv_mbx_ops > error: patch failed: drivers/net/ethernet/intel/ixgbevf/ixgbevf.h:439 > error: drivers/net/ethernet/intel/ixgbevf/ixgbevf.h: patch does not apply > Patch failed at 0001 ixgbevf: Remove unused ixgbevf_hv_mbx_ops Just sent: Subject: [PATCH net-next v2] ixgbevf: Remove unused ixgbevf_hv_mbx_ops Message-ID: <20250105122847.27341-1-linux@treblig.org> on top of a few hour old net-next. Dave
diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h index 130cb868774c..a43cb500274e 100644 --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf.h @@ -439,7 +439,6 @@ extern const struct ixgbevf_info ixgbevf_82599_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X540_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550_vf_hv_info; extern const struct ixgbevf_info ixgbevf_X550EM_x_vf_hv_info; -extern const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops; /* needed by ethtool.c */ extern const char ixgbevf_driver_name[]; diff --git a/drivers/net/ethernet/intel/ixgbevf/mbx.c b/drivers/net/ethernet/intel/ixgbevf/mbx.c index a55dd978f7ca..24d0237e7a99 100644 --- a/drivers/net/ethernet/intel/ixgbevf/mbx.c +++ b/drivers/net/ethernet/intel/ixgbevf/mbx.c @@ -505,15 +505,3 @@ const struct ixgbe_mbx_operations ixgbevf_mbx_ops_legacy = { .check_for_ack = ixgbevf_check_for_ack_vf, .check_for_rst = ixgbevf_check_for_rst_vf, }; - -/* Mailbox operations when running on Hyper-V. - * On Hyper-V, PF/VF communication is not through the - * hardware mailbox; this communication is through - * a software mediated path. - * Most mail box operations are noop while running on - * Hyper-V. - */ -const struct ixgbe_mbx_operations ixgbevf_hv_mbx_ops = { - .init_params = ixgbevf_init_mbx_params_vf, - .check_for_rst = ixgbevf_check_for_rst_vf, -};