From patchwork Thu Jan 2 18:14:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tariq Toukan X-Patchwork-Id: 13924761 X-Patchwork-Delegate: kuba@kernel.org Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2048.outbound.protection.outlook.com [40.107.236.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B47F018801A for ; Thu, 2 Jan 2025 18:15:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.236.48 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735841746; cv=fail; b=XaGcnpyAEp7zxw8rPKS/kmh3DsyjmKcXCWGQRlUDrYTDN2pymXtXkWAyuJTxZxEfaQrRVvKz3tsTbcq7wYmk66J34E1bqQVHXN3NDFsFaWXBFNyAR5I0clEzKlNssCJScSFinn00Xcxf/g6D5HTJhQhthQa7/aqj1XVnKXX54uU= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735841746; c=relaxed/simple; bh=pigy0yutngVrEujhSCnPM+PYijoeG3diEict5qR8Vqg=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=OeCKaEezCQmnu5gkFM4aPa2ScYdjC5LAoRE3ae0MsWqqkVJPIkJ6G4PYajSpk8/SJgbfW1i9i5feEJseoowwFVMw/lo7f8wtJL1NrOQDgSV6koLTtrKY/C51MhP89tdP6AafRknVYWABIIyv1UTYqY9fV0isZbZsgK3ATGle8r0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=uqjxxBnO; arc=fail smtp.client-ip=40.107.236.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="uqjxxBnO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F3i11+Xfjq9yLxj1j9GGYuuLhvGZwhUzmWB1WoT66W6jGFon+EXfzH4jRveqwzGc2ki7GqdJzw70JEr91jgGozeeYHowwBA/0fm39UPsb5rMfpeYlz0Gq3/il6WeRGQ99D1JXOzgrFIAFJ8iz7pdfmGzzOaOd51yNAPakxYcoypfKW+MgeAvE5ZW2fkMJnXHFM9yBCNFUQkLmgYdgohHEcpoWyigUAjMu5fr77GbkUvmMViJvyU7D0WCSt8dPo9+uFYmwOMrJORE6e1a/wPWXnXX9QBBfJqEZsKh88p2YOkc3AMOaYdfEGfYRI5RgChno6PJGDyInl85IZAQh33AnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Ecy3aVhXhr33ZQc6eBjQDmmjoLX5YtfoXg3CO6fQBfg=; b=C33H/mwsg6RI1LUxzTrnpit5+Y7i+h4bb0fNzfkFx0yz4FmH0UC7tQKGj9IPCS8WJuk/vrkkOC+Btf5fx/bRqkfKsCv5cYWVpaNPTuHKkKVP/IbfV21xxEtbzqSvGtRBWD5RVCJzllpGdye5hgS8rwHUX0Gz4YPeMuZtTLfReXyheWSJdP30HSuNSrBSllkUe0NYNTsqCddT1jSJ9cCvMdGJACHmt+p8GziN9HxxGbMqiL2ZPc62jtAfdroIMwezEdlXB4TfWGZ0oGFUFEJLN72cZUcK0MSEc2X0+TObc4Vt/3lTXtlaqDm6DzyJGTpKRNOTM1vsyj8P+VM1pEB0tA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=davemloft.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ecy3aVhXhr33ZQc6eBjQDmmjoLX5YtfoXg3CO6fQBfg=; b=uqjxxBnOT1g5lhHCmGMLov56zqG1+BLLqQdj2Xwf/w7IpbStJ7gpilEI1fW+CwdwAnCpSjuerrkwOwDmsD3LDnXo8tIWGMQUpPgvTOCQ+v2ppdkBUASY2f9i/InJmn0vfOVMENQD+ZcfSa2cQLnoibls76EIgm3/FWhLW6llitCgw33Box1jE9I505bKQpTTHqbenieyW0ZRmHLgB11+3WvlyxIIJo0PmNhPl4pOptog0uCjVCeJvOMcKrqThnKJLCPdNEgJznoVf87bIxjmol+jLkIXcOUzFa+ZgsvrYr0SV0SvM5eC1Omxm6+kbF/N0p2K8vJiaLdFZiJY76GVDw== Received: from DM6PR18CA0005.namprd18.prod.outlook.com (2603:10b6:5:15b::18) by PH7PR12MB6659.namprd12.prod.outlook.com (2603:10b6:510:210::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.12; Thu, 2 Jan 2025 18:15:33 +0000 Received: from DS2PEPF00003441.namprd04.prod.outlook.com (2603:10b6:5:15b:cafe::4c) by DM6PR18CA0005.outlook.office365.com (2603:10b6:5:15b::18) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.8314.12 via Frontend Transport; Thu, 2 Jan 2025 18:15:33 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DS2PEPF00003441.mail.protection.outlook.com (10.167.17.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8314.11 via Frontend Transport; Thu, 2 Jan 2025 18:15:32 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 2 Jan 2025 10:15:18 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 2 Jan 2025 10:15:18 -0800 Received: from vdi.nvidia.com (10.127.8.10) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Thu, 2 Jan 2025 10:15:14 -0800 From: Tariq Toukan To: "David S. Miller" , Jakub Kicinski , Paolo Abeni , Eric Dumazet , "Andrew Lunn" CC: , Saeed Mahameed , Gal Pressman , Leon Romanovsky , Mark Bloch , Moshe Shemesh , Yevgeny Kliteynik , Vlad Dogaru , Itamar Gozlan , Tariq Toukan Subject: [PATCH net-next 05/15] net/mlx5: HWS, add error message on failure to move rules Date: Thu, 2 Jan 2025 20:14:04 +0200 Message-ID: <20250102181415.1477316-6-tariqt@nvidia.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20250102181415.1477316-1-tariqt@nvidia.com> References: <20250102181415.1477316-1-tariqt@nvidia.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-NV-OnPremToCloud: AnonymousSubmission X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS2PEPF00003441:EE_|PH7PR12MB6659:EE_ X-MS-Office365-Filtering-Correlation-Id: f8bf11b4-f86e-4706-f516-08dd2b597260 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: 0r6vgcUE/d/PS5GZWY3Xf5jXg2iLXe2sRGUSaEDaV+GH/32zXsitwgKhVFh6LB9dBUjQc4qrGRyfi58YuL/o2Av2t3JEPY/2sTNSdc5GPqOT7rRsgn+jh0uW8ui1xkjx+aaOx7uOF5PDJ3Pg7ivbItVA8k+qibaWTyO5yiLG60IvtClm5HL3GmoCvZSMz+cuNJ3lISPRHdRaqzVxoqfll0kVNm8TUj5WD1ZfgbybdBjD5VNsBmae7IxH0SpCMbri0yAwQmLI4PupZaZO0FlrrqNHkgNmCILyvyKkZzsTJ8j+6rLBfhf6ng2IR6UmGO95LY+oWkJRMLd2JGYO3yxh+6YPz3Mz73e8ExX/OT6CpZmYlEsbPCte1Kxvmsiy17VXQnJRTdwxhjZCkY1pGXVTvkQLUQQzw1jI9hVqs0zzw39tC6BMhupXA0JDswH0Afab03gR/8tEx3MaOIt1PXFUpJypFwj1El+H2tlQxHiN8wLS5PR3WMVQ+uQ4JEIJ4uLi5l585lPg8CUqsNbRKdHhPgyOpav3ChwA6zu2ngS2w6ZdACH7Kl6a4XwEZMzVQ/3X5Ros7I9L44veI8YErN6TfrqKw7jVgARkk4QZqwBEUocsmVTMUEO9PXAaZkKecEZ9P/Rm0oR2CdkMmgVaNnjyWBR+4kfRS0FzHBlUv1mDJ2GsBFfjk1pQ8RW3Se1llWS6bTslErPWr63DyTSIzsYeom56soxNuyXiJI8YLiD3tl2k4L/sc4qnWbs4kimlsx3nJUbyKxCTrB2tYi54y2BbSeCsxpKv68iwDT4cV+eJgVCPetY0kAJXB1J/Z1Ipff5fgQERukmEQsNikhk/wUR1Ho0jY28z4Dzv71ZSW+Ixl9Hm7G+VOMtAdYBTOI41WPtwX6bOb9k0C1sizFxoPqdn/wJLaH7wFcjvPz6OyDix6dxt4IecOD2nR/1JheX5HRjYOVHJS2v7j4bQbwQ4lxBfEmWG0JDUxOWHnHVZGy/olXDDYmLGfiapYbqyh9XeAmiw9vhuNnxxIAEM4waSTFD2zfjLd7jNW35cGHdF48Ht1WEs9D8h4xquFYhq4LJhEiyxPbubqhs6eioxzGsuM3DfVtlqPpGvwi/1ZdmnWrzelCRivwV/cvyU4k7V1vnuhMbVpKz2Qx4bLkxLT9Is09Qz/E4aNjEjZfm+REC2TMk7DWA/K4t+qszI3W2HxrtU+Tuw5s+H2RcP7w0L6TH2Go5draRdmn03969htc3ayrxZ604NFBbMaAsAlz2aBtOwMTvl5pwbyMi7QVPpmxLLearK0TuSqomtXi/d6IFU5ZZ1S19WNmC2XzL9JsRPnfy6BEuv1+/ibr9EJfyZHp6LSBjByTKkTrIzPtSSRaTWpkgJi4y1/owdzKPopnRkN/5h7gYn9ouIlApeyDZ5wBedghjQGXfdp+EU5I7ip450HlaMOfPIgrUcNOEw6rF07+PqDuKSnc7HY1mZvnD8lXchlQBdH5gIuK/07AP+1nW7FDLmOoc= X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jan 2025 18:15:32.6112 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8bf11b4-f86e-4706-f516-08dd2b597260 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS2PEPF00003441.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6659 X-Patchwork-Delegate: kuba@kernel.org From: Yevgeny Kliteynik Add error message for failure to move rules from old matcher to new one during rehash. Signed-off-by: Yevgeny Kliteynik Reviewed-by: Itamar Gozlan Reviewed-by: Mark Bloch Signed-off-by: Tariq Toukan --- .../ethernet/mellanox/mlx5/core/steering/hws/bwc.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c index baacf662c0ab..af8ab8750c70 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc.c @@ -615,8 +615,12 @@ static int hws_bwc_matcher_move_all_simple(struct mlx5hws_bwc_matcher *bwc_match ret = hws_bwc_queue_poll(ctx, rule_attr.queue_id, &pending_rules[i], false); - if (unlikely(ret)) + if (unlikely(ret)) { + mlx5hws_err(ctx, + "Moving BWC rule failed during rehash (%d)\n", + ret); goto free_bwc_rules; + } } } } while (!all_done); @@ -629,8 +633,11 @@ static int hws_bwc_matcher_move_all_simple(struct mlx5hws_bwc_matcher *bwc_match mlx5hws_send_engine_flush_queue(&ctx->send_queue[queue_id]); ret = hws_bwc_queue_poll(ctx, queue_id, &pending_rules[i], true); - if (unlikely(ret)) + if (unlikely(ret)) { + mlx5hws_err(ctx, + "Moving BWC rule failed during rehash (%d)\n", ret); goto free_bwc_rules; + } } }