| Message ID | 20250103-feature_poe_port_prio-v4-18-dc91a3c0c187@bootlin.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for PSE budget evaluation strategy | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/apply | fail | Patch does not apply to net-next-0 |
On Fri, Jan 03, 2025 at 10:13:07PM +0100, Kory Maincent wrote: > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > Introduce a new property to describe the power budget of the regulator. > This property will allow power management support for regulator consumers > like PSE controllers, enabling them to make decisions based on the > available power capacity. > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > --- > > Changes in v3: > - Add type. > - Add unit in the name. > > Changes in v2: > - new patch. > --- > Documentation/devicetree/bindings/regulator/regulator.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.yaml b/Documentation/devicetree/bindings/regulator/regulator.yaml > index 1ef380d1515e..c5a6b24ebe7b 100644 > --- a/Documentation/devicetree/bindings/regulator/regulator.yaml > +++ b/Documentation/devicetree/bindings/regulator/regulator.yaml > @@ -34,6 +34,11 @@ properties: > regulator-input-current-limit-microamp: > description: maximum input current regulator allows > > + regulator-power-budget-miniwatt: What sort of quantity prefix is a "mini"? How much is a mini? > + description: power budget of the regulator > + $ref: /schemas/types.yaml#/definitions/uint32 This should not be needed. Use proper unit from dtschema. > + > + Just one blank line. Best regards, Krzysztof
On Fri, Jan 03, 2025 at 10:13:07PM +0100, Kory Maincent wrote: > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > Introduce a new property to describe the power budget of the regulator. > This property will allow power management support for regulator consumers > like PSE controllers, enabling them to make decisions based on the > available power capacity. > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> Please use same SoB as From. You might need to configure your Git correctly, first of all. Best regards, Krzysztof
On Sat, 4 Jan 2025 10:43:25 +0100 Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Fri, Jan 03, 2025 at 10:13:07PM +0100, Kory Maincent wrote: > > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > > > Introduce a new property to describe the power budget of the regulator. > > This property will allow power management support for regulator consumers > > like PSE controllers, enabling them to make decisions based on the > > available power capacity. > > > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > Please use same SoB as From. You might need to configure your Git > correctly, first of all. That was not an issue in the previous series. Net maintainers and you were ok with this: https://lore.kernel.org/linux-doc/20240417-feature_poe-v9-11-242293fd1900@bootlin.com/ Does it bother you now? If so I will fix it. Regards,
On Sat, 4 Jan 2025 10:42:32 +0100 Krzysztof Kozlowski <krzk@kernel.org> wrote: > On Fri, Jan 03, 2025 at 10:13:07PM +0100, Kory Maincent wrote: > > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > > > Introduce a new property to describe the power budget of the regulator. > > This property will allow power management support for regulator consumers > > like PSE controllers, enabling them to make decisions based on the > > available power capacity. > > > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > > --- > > > > Changes in v3: > > - Add type. > > - Add unit in the name. > > > > Changes in v2: > > - new patch. > > --- > > Documentation/devicetree/bindings/regulator/regulator.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/regulator/regulator.yaml > > b/Documentation/devicetree/bindings/regulator/regulator.yaml index > > 1ef380d1515e..c5a6b24ebe7b 100644 --- > > a/Documentation/devicetree/bindings/regulator/regulator.yaml +++ > > b/Documentation/devicetree/bindings/regulator/regulator.yaml @@ -34,6 > > +34,11 @@ properties: regulator-input-current-limit-microamp: > > description: maximum input current regulator allows > > > > + regulator-power-budget-miniwatt: > > What sort of quantity prefix is a "mini"? How much is a mini? Oops, that is a brain fart sorry for this. Of course it is milliwatt. > > > + description: power budget of the regulator > > + $ref: /schemas/types.yaml#/definitions/uint32 > > This should not be needed. Use proper unit from dtschema. Ok, I was mistaken. There are bindings with this ref in this file, so I thought it was needed. I will remove it. Regards,
On 04/01/2025 16:37, Kory Maincent wrote: > On Sat, 4 Jan 2025 10:43:25 +0100 > Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> On Fri, Jan 03, 2025 at 10:13:07PM +0100, Kory Maincent wrote: >>> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> >>> >>> Introduce a new property to describe the power budget of the regulator. >>> This property will allow power management support for regulator consumers >>> like PSE controllers, enabling them to make decisions based on the >>> available power capacity. >>> >>> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> >> >> Please use same SoB as From. You might need to configure your Git >> correctly, first of all. > > That was not an issue in the previous series. Net maintainers and you were ok > with this: > https://lore.kernel.org/linux-doc/20240417-feature_poe-v9-11-242293fd1900@bootlin.com/ > > Does it bother you now? > If so I will fix it. I don't think I paid attention to it before and I am not sure whether it matters, but I just don't want to wonder about it in the first place. I am not a lawyer and my knowledge on this topic is rather amateurish, so why would we even need to consider legal implications of different SoB from "From", if you could just fix it and make it simple/obvious/explicit/un-doubtful? Best regards, Krzysztof
On 04/01/2025 16:50, Kory Maincent wrote: > On Sat, 4 Jan 2025 10:42:32 +0100 > Krzysztof Kozlowski <krzk@kernel.org> wrote: > >> On Fri, Jan 03, 2025 at 10:13:07PM +0100, Kory Maincent wrote: >>> From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> >>> >>> Introduce a new property to describe the power budget of the regulator. >>> This property will allow power management support for regulator consumers >>> like PSE controllers, enabling them to make decisions based on the >>> available power capacity. >>> >>> Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> >>> --- >>> >>> Changes in v3: >>> - Add type. >>> - Add unit in the name. >>> >>> Changes in v2: >>> - new patch. >>> --- >>> Documentation/devicetree/bindings/regulator/regulator.yaml | 5 +++++ >>> 1 file changed, 5 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/regulator/regulator.yaml >>> b/Documentation/devicetree/bindings/regulator/regulator.yaml index >>> 1ef380d1515e..c5a6b24ebe7b 100644 --- >>> a/Documentation/devicetree/bindings/regulator/regulator.yaml +++ >>> b/Documentation/devicetree/bindings/regulator/regulator.yaml @@ -34,6 >>> +34,11 @@ properties: regulator-input-current-limit-microamp: >>> description: maximum input current regulator allows >>> >>> + regulator-power-budget-miniwatt: >> >> What sort of quantity prefix is a "mini"? How much is a mini? > > Oops, that is a brain fart sorry for this. Of course it is milliwatt. > >> >>> + description: power budget of the regulator >>> + $ref: /schemas/types.yaml#/definitions/uint32 >> >> This should not be needed. Use proper unit from dtschema. > > Ok, I was mistaken. There are bindings with this ref in this file, so I thought > it was needed. I will remove it. If the unit is not in the property-units of dtschema, you will have a warning, but then please send a pull request (patch could work as well probably) to dtschema adding it... but I am sure that milliwatt is there. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/regulator/regulator.yaml b/Documentation/devicetree/bindings/regulator/regulator.yaml index 1ef380d1515e..c5a6b24ebe7b 100644 --- a/Documentation/devicetree/bindings/regulator/regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/regulator.yaml @@ -34,6 +34,11 @@ properties: regulator-input-current-limit-microamp: description: maximum input current regulator allows + regulator-power-budget-miniwatt: + description: power budget of the regulator + $ref: /schemas/types.yaml#/definitions/uint32 + + regulator-always-on: description: boolean, regulator should never be disabled type: boolean