| Message ID | 20250103-feature_poe_port_prio-v4-27-dc91a3c0c187@bootlin.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add support for PSE budget evaluation strategy | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Clearly marked for net-next |
| netdev/apply | fail | Patch does not apply to net-next-0 |
On Fri, Jan 03, 2025 at 10:13:16PM +0100, Kory Maincent wrote: > From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com> > > Add an interrupt property to the device tree bindings for the TI TPS23881 > PSE controller. The interrupt is primarily used to detect classification > and disconnection events, which are essential for managing the PSE > controller in compliance with the PoE standard. > > Signed-off-by: Kory Maincent <kory.maincent@bootlin.com> > --- > > Change in v3: > - New patch > --- > Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml b/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml > index d08abcb01211..19d25ded4e58 100644 > --- a/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml > +++ b/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml > @@ -20,6 +20,9 @@ properties: > reg: > maxItems: 1 > > + interrupts: > + maxItems: 1 > + > '#pse-cells': > const: 1 > > @@ -62,6 +65,7 @@ unevaluatedProperties: false > required: > - compatible > - reg > + - interrupts Why? That's an ABI change. Commit msg mentions something like "essential for standard" so are you saying nothing here was working according to standard before? > > examples: > - | > @@ -72,6 +76,8 @@ examples: > ethernet-pse@20 { > compatible = "ti,tps23881"; > reg = <0x20>; > + interrupts = <8 0>; This looks like standard flag, so use standard define and then note that NONE is usually not a correct interrupt type. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml b/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml index d08abcb01211..19d25ded4e58 100644 --- a/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml +++ b/Documentation/devicetree/bindings/net/pse-pd/ti,tps23881.yaml @@ -20,6 +20,9 @@ properties: reg: maxItems: 1 + interrupts: + maxItems: 1 + '#pse-cells': const: 1 @@ -62,6 +65,7 @@ unevaluatedProperties: false required: - compatible - reg + - interrupts examples: - | @@ -72,6 +76,8 @@ examples: ethernet-pse@20 { compatible = "ti,tps23881"; reg = <0x20>; + interrupts = <8 0>; + interrupt-parent = <&gpiog>; channels { #address-cells = <1>;