| Message ID | 20250103155824.131285-1-niharchaithanya@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | octeontx2-pf: mcs: Remove dead code and semi-colon from rsrc_name() | expand |
On Fri, Jan 03, 2025 at 09:28:26PM +0530, Nihar Chaithanya wrote: > The switch-block has a default branch. Thus, the return statement at the > end of the function can never be reached. Deja vue? I already commented on a similar patch like this. It is not the default: branch alone which makes the code unreachable. It is that every case statement makes a return, not a break. This might seem pedantic, but compiles and static analysers are pedantic, so we software engineers also need to be pedantic. Please update the commit message. Please also take a read of: https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html Andrew --- pw-bot: cr
diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c index 6cc7a78968fc..f3b9daffaec3 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c @@ -133,9 +133,7 @@ static const char *rsrc_name(enum mcs_rsrc_type rsrc_type) return "SA"; default: return "Unknown"; - }; - - return "Unknown"; + } } static int cn10k_mcs_alloc_rsrc(struct otx2_nic *pfvf, enum mcs_direction dir,
The switch-block has a default branch. Thus, the return statement at the end of the function can never be reached. The semi-colon is not required after switch-block. Remove the semi-colon after the switch-block's curly braces and the return statement at the end of the function. This issue was reported by Coverity Scan. Report: CID 1516236: (#1 of 1): Structurally dead code (UNREACHABLE) unreachable: This code cannot be reached: return "Unknown";. Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com> --- drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)