| Message ID | 20250103182458.1213486-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e95274dfe86490ec2a5633035c24b2de6722841f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: tc-testing: reduce rshift value | expand |
On Fri, Jan 3, 2025 at 7:25 PM Jakub Kicinski <kuba@kernel.org> wrote: > > After previous change rshift >= 32 is no longer allowed. > Modify the test to use 31, the test doesn't seem to send > any traffic so the exact value shouldn't matter. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Thanks ! Reviewed-by: Eric Dumazet <edumazet@google.com>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 3 Jan 2025 10:24:58 -0800 you wrote: > After previous change rshift >= 32 is no longer allowed. > Modify the test to use 31, the test doesn't seem to send > any traffic so the exact value shouldn't matter. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: jhs@mojatatu.com > CC: xiyou.wangcong@gmail.com > CC: jiri@resnulli.us > CC: shuah@kernel.org > CC: karansanghvi98@gmail.com > CC: linux-kselftest@vger.kernel.org > > [...] Here is the summary with links: - [net] selftests: tc-testing: reduce rshift value https://git.kernel.org/netdev/net/c/e95274dfe864 You are awesome, thank you!
diff --git a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json index 996448afe31b..91d120548bf5 100644 --- a/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json +++ b/tools/testing/selftests/tc-testing/tc-tests/filters/flow.json @@ -78,10 +78,10 @@ "setup": [ "$TC qdisc add dev $DEV1 ingress" ], - "cmdUnderTest": "$TC filter add dev $DEV1 parent ffff: handle 1 prio 1 protocol ip flow map key dst rshift 0xff", + "cmdUnderTest": "$TC filter add dev $DEV1 parent ffff: handle 1 prio 1 protocol ip flow map key dst rshift 0x1f", "expExitCode": "0", "verifyCmd": "$TC filter get dev $DEV1 parent ffff: handle 1 protocol ip prio 1 flow", - "matchPattern": "filter parent ffff: protocol ip pref 1 flow chain [0-9]+ handle 0x1 map keys dst rshift 255 baseclass", + "matchPattern": "filter parent ffff: protocol ip pref 1 flow chain [0-9]+ handle 0x1 map keys dst rshift 31 baseclass", "matchCount": "1", "teardown": [ "$TC qdisc del dev $DEV1 ingress"
After previous change rshift >= 32 is no longer allowed. Modify the test to use 31, the test doesn't seem to send any traffic so the exact value shouldn't matter. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: jhs@mojatatu.com CC: xiyou.wangcong@gmail.com CC: jiri@resnulli.us CC: shuah@kernel.org CC: karansanghvi98@gmail.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/tc-testing/tc-tests/filters/flow.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)