| Message ID | 20250107144701.503884-1-edumazet@google.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] net: hsr: remove synchronize_rcu() from hsr_add_port() | expand |
On Tue, Jan 07, 2025 at 02:47:01PM +0000, Eric Dumazet wrote: > A synchronize_rcu() was added by mistake in commit > c5a759117210 ("net/hsr: Use list_head (and rcu) instead > of array for slave devices.") > > RCU does not mandate to observe a grace period after > list_add_tail_rcu(). > > Signed-off-by: Eric Dumazet <edumazet@google.com> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/net/hsr/hsr_slave.c b/net/hsr/hsr_slave.c index 006d6ef97e53f4077eb16f08077ee366d8cb4bbd..2a802a5de2acca1d87ad475b3c96d2464a1faad0 100644 --- a/net/hsr/hsr_slave.c +++ b/net/hsr/hsr_slave.c @@ -204,7 +204,6 @@ int hsr_add_port(struct hsr_priv *hsr, struct net_device *dev, } list_add_tail_rcu(&port->port_list, &hsr->ports); - synchronize_rcu(); master = hsr_port_get_hsr(hsr, HSR_PT_MASTER); netdev_update_features(master->dev);
A synchronize_rcu() was added by mistake in commit c5a759117210 ("net/hsr: Use list_head (and rcu) instead of array for slave devices.") RCU does not mandate to observe a grace period after list_add_tail_rcu(). Signed-off-by: Eric Dumazet <edumazet@google.com> --- net/hsr/hsr_slave.c | 1 - 1 file changed, 1 deletion(-)