| Message ID | 20250107162350.1281165-6-ninad@linux.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | DTS updates for system1 BMC | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Tue, Jan 07, 2025 at 10:23:42AM -0600, Ninad Palsule wrote: > system1 has 2 transceiver connected through the RGMII interfaces. Added > device tree entry to enable RGMII support. > > ASPEED AST2600 documentation recommends using 'rgmii-rxid' as a > 'phy-mode' for mac0 and mac1 to enable the RX interface delay from the > PHY chip. Why? Does the mac0 TX clock have an extra long clock line on the PCB? Does the mac1 TX and RX clocks have extra long clock lines on the PCB? Anything but rgmii-id is in most cases wrong, so you need a really good explanation why you need to use something else. Something that shows you understand what is going on, and why what you have is correct. Andrew
diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts index d11a922c9d44..0f4658074709 100644 --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-system1.dts @@ -425,14 +425,42 @@ &lpc_ctrl { memory-region = <&flash_memory>; }; +&mdio0 { + status = "okay"; + + ethphy0: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + }; +}; + +&mdio2 { + status = "okay"; + + ethphy2: ethernet-phy@0 { + compatible = "ethernet-phy-ieee802.3-c22"; + reg = <0>; + }; +}; + +&mac0 { + status = "okay"; + + phy-mode = "rgmii-rxid"; + phy-handle = <ðphy0>; + + pinctrl-names = "default"; + pinctrl-0 = <&pinctrl_rgmii1_default>; +}; + &mac2 { status = "okay"; + + phy-mode = "rgmii"; + phy-handle = <ðphy2>; + pinctrl-names = "default"; - pinctrl-0 = <&pinctrl_rmii3_default>; - clocks = <&syscon ASPEED_CLK_GATE_MAC3CLK>, - <&syscon ASPEED_CLK_MAC3RCLK>; - clock-names = "MACCLK", "RCLK"; - use-ncsi; + pinctrl-0 = <&pinctrl_rgmii3_default>; }; &mac3 {
system1 has 2 transceiver connected through the RGMII interfaces. Added device tree entry to enable RGMII support. ASPEED AST2600 documentation recommends using 'rgmii-rxid' as a 'phy-mode' for mac0 and mac1 to enable the RX interface delay from the PHY chip. Signed-off-by: Ninad Palsule <ninad@linux.ibm.com> --- .../dts/aspeed/aspeed-bmc-ibm-system1.dts | 38 ++++++++++++++++--- 1 file changed, 33 insertions(+), 5 deletions(-)