diff mbox series

[net-next] sched: sch_cake: Align QoS treatment to Windows and Zoom

Message ID 20250110155531.300303-1-toke@redhat.com (mailing list archive)
State Changes Requested
Delegated to: Netdev Maintainers
Headers show
Series [net-next] sched: sch_cake: Align QoS treatment to Windows and Zoom | expand

Checks

Context Check Description
netdev/series_format success Single patches do not need cover letters
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 1 this patch: 1
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 10 of 10 maintainers
netdev/build_clang success Errors and warnings before: 2 this patch: 2
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 1 this patch: 1
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 10 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Toke Høiland-Jørgensen Jan. 10, 2025, 3:55 p.m. UTC 
From: Dave Taht <dave.taht@gmail.com>

Cake's diffserv4 mode attempted to follow the IETF webrtc
QoS marking standards, RFC8837.

It turns out Windows QoS can only use CS0, CS1, CS5, and CS7.

Zoom defaults to using CS5 for video and screen sharing traffic.

Bump CS4, CS5, and NQB to the video tin (2) in diffserv4 mode, for
more bandwidth and lower priority.

This also better aligns with how WiFi presently treats CS5 and NQB.

Signed-off-by: Dave Taht <dave.taht@gmail.com>
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>
---
 net/sched/sch_cake.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Toke Høiland-Jørgensen Jan. 10, 2025, 7:06 p.m. UTC | #1 
Toke Høiland-Jørgensen <toke@redhat.com> writes:

> From: Dave Taht <dave.taht@gmail.com>
>
> Cake's diffserv4 mode attempted to follow the IETF webrtc
> QoS marking standards, RFC8837.
>
> It turns out Windows QoS can only use CS0, CS1, CS5, and CS7.
>
> Zoom defaults to using CS5 for video and screen sharing traffic.
>
> Bump CS4, CS5, and NQB to the video tin (2) in diffserv4 mode, for
> more bandwidth and lower priority.
>
> This also better aligns with how WiFi presently treats CS5 and NQB.
>
> Signed-off-by: Dave Taht <dave.taht@gmail.com>
> Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com>

Alright, there was some discussion on the cake list re: this. Please
drop.

pw-bot: changes-requested
diff mbox series

Patch

diff --git a/net/sched/sch_cake.c b/net/sched/sch_cake.c
index 48dd8c88903f..2a9288d4b873 100644
--- a/net/sched/sch_cake.c
+++ b/net/sched/sch_cake.c
@@ -328,8 +328,8 @@  static const u8 diffserv4[] = {
 	1, 0, 0, 0, 0, 0, 0, 0,
 	2, 0, 2, 0, 2, 0, 2, 0,
 	2, 0, 2, 0, 2, 0, 2, 0,
-	3, 0, 2, 0, 2, 0, 2, 0,
-	3, 0, 0, 0, 3, 0, 3, 0,
+	2, 0, 2, 0, 2, 0, 2, 0,
+	2, 0, 0, 0, 2, 0, 3, 0,
 	3, 0, 0, 0, 0, 0, 0, 0,
 	3, 0, 0, 0, 0, 0, 0, 0,
 };