| Message ID | 20250111065955.3698801-2-kuba@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next,1/2] net: un-export init_dummy_netdev() | expand |
diff --git a/net/core/dev.c b/net/core/dev.c index 23e7f6a3925b..00552197d601 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -10756,6 +10756,8 @@ static void init_dummy_netdev_core(struct net_device *dev) /* napi_busy_loop stats accounting wants this */ dev_net_set(dev, &init_net); + mutex_init(&dev->lock); + /* Note : We dont allocate pcpu_refcnt for dummy devices, * because users of this 'device' dont need to change * its refcount.
Make sure netdev->lock is always valid, even on dummy netdevs. Apparently it's legal to call mutex_destroy() on an uninitialized mutex (and we do that in free_netdev()), but it doesn't seem right. Plus we'll soon want to take netdev->lock on more paths which dummy netdevs may reach. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- net/core/dev.c | 2 ++ 1 file changed, 2 insertions(+)