| Message ID | 20250120-schema_qcs615-v4-1-d9d122f89e64@quicinc.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v4] dt-bindings: net: qcom,ethqos: Correct fallback compatible for qcom,qcs615-ethqos | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Mon, Jan 20, 2025 at 03:08:28PM +0800, Yijie Yang wrote: > The qcs615-ride utilizes the same EMAC as the qcs404, rather than the > sm8150. The current incorrect fallback could result in packet loss. > The Ethernet on qcs615-ride is currently not utilized by anyone. Therefore, > there is no need to worry about any ABI impact. > > Fixes: 32535b9410b8 ("dt-bindings: net: qcom,ethqos: add description for qcs615") > Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml index f117471fb06fb3b507df811d55d41d0b610ac15f..e7ee0d9efed8330f5cf62e6c0ea41066572415aa 100644 --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml @@ -22,12 +22,12 @@ properties: oneOf: - items: - enum: - - qcom,qcs8300-ethqos - - const: qcom,sa8775p-ethqos + - qcom,qcs615-ethqos + - const: qcom,qcs404-ethqos - items: - enum: - - qcom,qcs615-ethqos - - const: qcom,sm8150-ethqos + - qcom,qcs8300-ethqos + - const: qcom,sa8775p-ethqos - enum: - qcom,qcs404-ethqos - qcom,sa8775p-ethqos
The qcs615-ride utilizes the same EMAC as the qcs404, rather than the sm8150. The current incorrect fallback could result in packet loss. The Ethernet on qcs615-ride is currently not utilized by anyone. Therefore, there is no need to worry about any ABI impact. Fixes: 32535b9410b8 ("dt-bindings: net: qcom,ethqos: add description for qcs615") Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com> --- Changes in v4: - Update the base commit to next-20250117. - Update the commit description for better clarity and understanding. - Link to v3: https://lore.kernel.org/r/20250113-schema_qcs615-v3-1-d5bbf0ee8cb7@quicinc.com --- Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) --- base-commit: 29ef83bb05764c31613d839f62474aa54b39e7d4 change-id: 20250113-schema_qcs615-bd7b3d82c2fa Best regards,