From patchwork Mon Feb 3 17:01:52 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 13957867 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 35FF020B7FE; Mon, 3 Feb 2025 17:02:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.19 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738602155; cv=none; b=nhmd8sn8QZkMBD+fNls484O3JvZlfudknQeb3fWoBo/Bk8mUNKj+X8jq49/tv9mBSxGuHJmwZ6GBp+FFbyyUjzam+xw3DT6rvr7qFWd72R/RkkaJsHj7U/f7FFdk1Pwww3ry582LyN41rFv1hMiN+RZb5I2kg3vepjwwkgSMeSU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738602155; c=relaxed/simple; bh=32+59aZbJd8IOqTe+dLYeCFxvL3Tk0xzDu5MRFtgWYY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=blT8JGnLYpgW10yB4VQF2haWrW95dbSoERmgyBJfe9SjnQWNq5PcfS1ZmgQ05ngedCIqUeHwhLwodfxpEdUArOjiqgeZwKXZnCtW2dOCAIgeWnEG55e/Ew8AKm9oPmPf6w40B9dymcCy/GBsa0BP72FnXoX5FYBwBnNC+CkmK4A= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=KiPdGMOr; arc=none smtp.client-ip=212.227.15.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="KiPdGMOr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1738602148; x=1739206948; i=ps.report@gmx.net; bh=32+59aZbJd8IOqTe+dLYeCFxvL3Tk0xzDu5MRFtgWYY=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=KiPdGMOr1ieu6sYifUvQPMlZ6hKWHAqK86+Yt5V5pRSkDNmOPAvkSBPSd6VQqhC8 FcM/lcBC7S1TlOzFuB3Z6fRaBuk41+9V817z2nUUyN+8pbh3wQB37nyCsgqVuJpdQ Dei4OuoGJAWVbCIK9TKjWVPI1WrR4Kcfy9sKhIXF9Ctn9eEFTrm/hX00AImz/FVh7 j2zrqgYxcWF7m7+7tt1hJ9ii9JAYJGrzkw7oitT8qMvjMK4Dj05DM3KROOnk2h+a8 2339XKhgikwUYPMP8BcT20BIx/5dashOIki2ZQzK1PHWsiuX85CK98ZNm7Ge0yrVG VUDRBtIDLRvMw1CoZg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.54]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MplXz-1t4n0b1Tor-00dNuv; Mon, 03 Feb 2025 18:02:28 +0100 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Nam Cao , Thomas Gleixner , Frederic Weisbecker , Artem Chernyshev , Peter Seiderer Subject: [PATCH net-next v3 01/10] net: pktgen: replace ENOTSUPP with EOPNOTSUPP Date: Mon, 3 Feb 2025 18:01:52 +0100 Message-ID: <20250203170201.1661703-2-ps.report@gmx.net> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203170201.1661703-1-ps.report@gmx.net> References: <20250203170201.1661703-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:efFOmg+dqNpe4u3UGla4MV9XFWUj0tJLNRqUedq6zolUiCbHteB iB3AtOh3zU3zAwiVbUKyujVbSiU4hD+nq9zz+yu/S1ytJRi1CDI6MGmkC3ia7eiHTlepvd8 pQV6Z4QDRsM7OIEX/iXXpc89Lqg/TkHP12b0qMPmFJrA2bMXB5afb0l9ePXtXXQ1yfdHOUH V0lblhzDXtbGPtzu1ncqg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:7Lzg3n0qlGg=;e6PrcDw6e2LHlhfuOtRnk0J8MqS xngPifAxwuKlt3QFf1APsAw03ZhCSA9wHVEniprFYw8jCsg6VOMz2lFYl8/UtWjw8VC7TvklD 2bDjehzoDB88bwG5awV6FrtMybbRCHzV2xrI/nrQJaFeRU5pnOjTLqabzrFMyoKQCmKj+bRYs /m69mU7Ot8UTyTZSHfPhFlc5m8goMWdjIrFdtiFc9JPJR6FCvtbOhQP1vAM7AuaegC2FdiQtV DoAGDW31up8R/lEusOeW3JDxuxFD3snaiY4mPcPlX0XlX7nOxrp1s6/m/pQMwjK6aBTK3nBku Yr82nvrOLHseoxZ1FNrR+MsMR52tmgzkNSmVHg2WhZEyxWRjDtBLlKbptqhn3ixSFCWHchbT5 Co6CCR228KwBk8O1oPuzy8YmvsZTSL/JNvG6AGRoobmnhRESlNjEWaXBEnl0Xaz+nbSQ6fJ+y 2DIZisLKLFKciGfPYu0Xrfv/g9RbWpK1UARX0pskwi0NhrWHulsvKXbrM0QWCn+ySM7td4g2M IgGUfdkQbyXYViIXIAj8frbal3CySgwj+Iw13BvZvxtbamuVSQahvNb7/rdI0gKNMPZt7lyOX 1Cw3vajX9dvOnpSz/fr/H0IQQeZp7WS3iDSO4WswPG4fba4Wmfj6YrfZxjaq2AcBXkiueI2Zb AfuyiEjGR50TobqqKiu06Jxdj9zcnIPKiSeZtT7egE5n1HqQKyvr0H85+Dkden1u7O6SxCVPO xHZV3oTHZrXlxyWYjPJNDSklG0KorlHmy0V5BANCs+2YGjxC9pzSP9o3ysjtUMFyHB7kIsHzM EwbJ5itcMRUzxUbztDb3Ku6pKSA11EJ6z9rrngPYZaJh+yP9bTts7tsw0/nrQqfOXBzbNO5Pz /WZjGjsJuDKoBBQHVux9ehJ7V7OaulPkopxiPWnlYcDj/Rqhro7BUIMgNCpvZokCyJBTcOBoh c1p8BTeZL9mAbb70uLuNzgLVLK8rlFNY/wIy6IuJTi/4FWMSyxScvsL36Pa7qkWLViz5ehhU9 nFtONff8hKv7s+zKQftZl8Y9kjMkbfCK+KLGbbJHu12dtjejyfrdW/CEObZy93BBiH0fhVYJS Bjz1E8Fx/RULdLM2FyBgvPLcA2HNFHOk9CQq09pvTWJP8WkLwXzagJsqeiJxPSi+QXd3j++Mm eHg7TEmOpqNRVMWUve3tBXoAuq7m/mewqDhk1QwkqcPF1kTktJQu/j/SY8Y+ntPwTTQu0u2J5 RTHmKBAsvELA4XqfTqXdAKRlal+nTmDaqL3TXAKoe9Y9y3Ifyf0R1GzdvNFwo8uZ3m0Ee0780 d4wXWnAtQjSXX8mdiByvzMJ80AIm8rm8XyaN9oTIyY8gwM= X-Patchwork-Delegate: kuba@kernel.org Replace ENOTSUPP with EOPNOTSUPP, fixes checkpatch hint WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP and e.g. $ echo "clone_skb 1" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Unknown error 524 Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v2 -> v3 - no changes Changes v1 -> v2 - no changes --- net/core/pktgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 82b6a2c3c141..496aa16773e7 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1198,7 +1198,7 @@ static ssize_t pktgen_if_write(struct file *file, if ((value > 0) && ((pkt_dev->xmit_mode == M_NETIF_RECEIVE) || !(pkt_dev->odev->priv_flags & IFF_TX_SKB_SHARING))) - return -ENOTSUPP; + return -EOPNOTSUPP; if (value > 0 && (pkt_dev->n_imix_entries > 0 || !(pkt_dev->flags & F_SHARED))) return -EINVAL; @@ -1258,7 +1258,7 @@ static ssize_t pktgen_if_write(struct file *file, ((pkt_dev->xmit_mode == M_QUEUE_XMIT) || ((pkt_dev->xmit_mode == M_START_XMIT) && (!(pkt_dev->odev->priv_flags & IFF_TX_SKB_SHARING))))) - return -ENOTSUPP; + return -EOPNOTSUPP; if (value > 1 && !(pkt_dev->flags & F_SHARED)) return -EINVAL; @@ -1303,7 +1303,7 @@ static ssize_t pktgen_if_write(struct file *file, } else if (strcmp(f, "netif_receive") == 0) { /* clone_skb set earlier, not supported in this mode */ if (pkt_dev->clone_skb > 0) - return -ENOTSUPP; + return -EOPNOTSUPP; pkt_dev->xmit_mode = M_NETIF_RECEIVE;