From patchwork Mon Feb 3 17:01:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 13957875 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F98620F07A; Mon, 3 Feb 2025 17:02:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.15 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738602167; cv=none; b=prWe/ZhHJMJLl7LpVZkDl+8FDUuh4hoLromkQ+xjyhFEf9Ly8VxgcY8v9AWjxaWry0SxMrNDXk580dHWNGsfMep+ZVamTbput+/15e5MJRvdujd3PxqQpk+PIaMz/LfJ9jLBMKyELicLrbJxGa5vFvztDxRbnRAm4Pew8NZdxCk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738602167; c=relaxed/simple; bh=XYAqqxfOd4K97F96CABMIElX44iLTKCo20ntWNluzPE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=X6uPpevBiYlbXwhfkuIHSFSG4xN1Um9ZzrPC93Q9aHVhFKzacbqHS/RD4YM90c6Q+3FlRSwSeIRCcYy5G+dVrQS45PLuf9BJ+m4dNwYy8+7dwEd8urDHPmMwE9/FVl0axBwGHYRyIPSXMW8OMBxdE0mfWi5clTO76VhwQ3LJFHs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=s1ZPJ5h1; arc=none smtp.client-ip=212.227.15.15 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="s1ZPJ5h1" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1738602149; x=1739206949; i=ps.report@gmx.net; bh=XYAqqxfOd4K97F96CABMIElX44iLTKCo20ntWNluzPE=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=s1ZPJ5h14084YKFsis9wl2u/reRbhgIMu+izkOeHw0FbvU5dXfctjdi/QbQhxESc Xt7bu89FKTG88pebzlbjUQv0w5ocL8QI4NNiXAeNuWi9mVCTW6EXFOI16+ufRUxpQ 9m1fySp8mS9du1akMe/Fg6axCFW774YvbcpLRF7tI72mB45NNGxPMO4IANUf5sCaI spG8gYgDZFzrQc5EPHPSCCYZ/aZDmkaRvJE2HEcakqxq8DbuYcKO4mYSpz8/wtuTe eh1/KvrNtv4tCdUGSfwWRHSjuWT6ICj64AKLkv3fgJ/Db/H5IblgNU5zK9j9C0frR kqpd4ttFYXNK52i1kQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.54]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MvK0R-1tNT1Q1aXx-014taD; Mon, 03 Feb 2025 18:02:29 +0100 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Nam Cao , Thomas Gleixner , Frederic Weisbecker , Artem Chernyshev , Peter Seiderer Subject: [PATCH net-next v3 04/10] net: pktgen: fix 'rate 0' error handling (return -EINVAL) Date: Mon, 3 Feb 2025 18:01:55 +0100 Message-ID: <20250203170201.1661703-5-ps.report@gmx.net> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250203170201.1661703-1-ps.report@gmx.net> References: <20250203170201.1661703-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:ps5aTIrNCztv6KI7hrchAjf0FiOZxzlsJJmIWAvelJgKo4W6KaX 6thWWPM7+LZXGhNoEGa3EsgM6CrARQLQ6n9LROJQHRelThtkjg6yXvdA7TJxC1KlKIwa5k7 Lolip95Pm5iv99Y2qFbIjtjMKaFbI0PJjMDXUu6roLdiAb0ZI+uBdKcB/yRjqV16INJt+p6 DwsUF/RFGflviZfLM7utA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:BCJTPxYCcjw=;KT9wdtvHNdO99CXmHd3twLqvsx5 wgoJTTNhpZUFjcxh1yh681C6J8OrqeeJSqxuH897f6YOTWzxgN3p+lu94ozu7oVjdjzrUiqIm O9YWNPVYgGxDbWmxOKXJjFB2m8oID1RaXltleKsc2DQv+YlwCLIREy+G33WqEEUatFg/rSLjp m6cfUFHbOl5ab9PYqGwaO3w4Aq/Ni4Zl0XTvDdaCf319z0WEq/mW83+swxJ+xxnJYMVt1he4h 2DB2br3tLYbABhiJ7kV0O55muUvaF4MsaixTpIoF0yHDHiHv4+PpthnA6ZE0/zf8mPLAb4snj cpmeqR+GWoOC5kfYC5cVrbGvm5pSFpix5t84cxthgP77ymh8F/Je0NyAGW2q3wyxLKiZ0mHAj T0B7jbFMmoSxT4CoKbq3lY7YcNX1Z8DwptLFHAGT6ceSAWmD0DVq4MrhILzwwiIQJLY9hJREx bPykwsLUDJkQoefOWqtHpid/UuXatO+dwKhKnUErBGVrsPBTaXiSh+pu16vpDC76yMb1xfXvO X5ppAJuf5sCyDulNzrnPxpoK/xn03CHDZaqAuNE/fGo6JW0kFFb8OUKZptV2uNVo8rWjReBz/ E0m2RMQ4J1U2lKy2P72lOpbyGVDyQzN4P+VclgyObfYZZyo6PoEJAPe8qdvE0/oxqFg690JQS E2AsdktME5/YB5F2YQlvNpjeN6lFN1Ws50+96eQZlfCE53z9/EHy8/SZPUtvFJbA30Iqm8s/p VMblI/pb+W6lLFgvW60c91LupX7eVHEanhaiGk8ZC/5WvMq2JYqvhw054i8J3H+nuJxqmvZTM QY4Vw4obNVegjbCsPGZe0u9StFcBz9wQCSvo1SyzAWoy3VOJjJjhfvc8aN7dKmqnkAhBSjzst MxtTg2NcmztiTe+35bnX07ehgfgZuAPw9enQpoVmxltXP2Nl1ALO7lZLapOvZ/NDxU9uDSiai SfGxsYpPuGituklkQjoSXVqQwwF9sZs5ZyHjtp8FJSCfg7l3UuwSBW2JGiYFgb2i0oCy1ECDZ GpPhjY7uLlyzStEKXyiuTVZLLewyzN/0QKIYqBdd4WY0c2lm2/rqivEydfKDLJOpCDxV3x3ga RwVpHyQOyBKmiYXPh864sYsSac73GRtPkXNJRLd5hGAf9IMotxb8h/P5r5WkssSn/JM6jVB/O cDyyAHwonqbud1OPS+RdkPCJZ4QysvvEteYj5EzbrnlQ1MYB6QZ4xa/t0FB90qOmQkgS6B6EI m6bImxZa4YrCVZtAnT4LPJxwZHGipHSH2aSgZoJRYv45b0PnYPHr/DUvHd4CZWcIZTFDbXYuw P3Kt/2Wo0BFQj5alSWpA2NNWhwICOchMJ5bMO4z9lhu9xc= X-Patchwork-Delegate: kuba@kernel.org Given an invalid 'rate' command e.g. 'rate 0' the return value is '1', leading to the following misleading output: - the good case $ echo "rate 100" > /proc/net/pktgen/lo\@0 $ grep "Result:" /proc/net/pktgen/lo\@0 Result: OK: rate=100 - the bad case (before the patch) $ echo "rate 0" > /proc/net/pktgen/lo\@0" -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: No such parameter "ate" - with patch applied $ echo "rate 0" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Invalid argument $ grep "Result:" /proc/net/pktgen/lo\@0 Result: Idle Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v2 -> v3: - no changes Changes v1 -> v2: - new patch --- net/core/pktgen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 28dbbf70e142..75c7511bf492 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1115,7 +1115,7 @@ static ssize_t pktgen_if_write(struct file *file, i += len; if (!value) - return len; + return -EINVAL; pkt_dev->delay = pkt_dev->min_pkt_size*8*NSEC_PER_USEC/value; if (debug) pr_info("Delay set at: %llu ns\n", pkt_dev->delay);