From patchwork Tue Feb 4 02:00:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Levi Zim via B4 Relay X-Patchwork-Id: 13958512 X-Patchwork-Delegate: bpf@iogearbox.net Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D232E86321; Tue, 4 Feb 2025 02:00:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738634426; cv=none; b=eo7sT2EMhL/kqYgkiNMec6k8nYf+jAhQ4SsHyEalN/giJhc/CqkGFWYEkKSOQa2m6y26D2/K+V0fVZP2y/iwdxiWDnBVk4uowVvT0so1DJSG90vslxEYNScql07MFZpAF7NQj+NdGuXQlTnwRjiCNLo5hcGB0xyMzQgUyQzwppg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738634426; c=relaxed/simple; bh=/D3KeD0qSO6wrt7VgS4VH3NDiPTTikYRNjSzZ/ufXvo=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:To:Cc; b=pk734woSDPxWlxzhCUWLfkFblcJ7hJoCF13qKcmD9BxtAOr2eT8ceCSH3YRJnCuFSdxRGhqa9L5CpF+tyd3Qh5utCsv17LT0XjNWr1VIanXab94f4UKMpyDEbbAn1lYwXUYxjiApE6tsz0pMzoLztiPNDsujizT7Jh/gi8z/Y6c= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=teGua/Q1; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="teGua/Q1" Received: by smtp.kernel.org (Postfix) with ESMTPS id 3E16EC4CEE0; Tue, 4 Feb 2025 02:00:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738634426; bh=/D3KeD0qSO6wrt7VgS4VH3NDiPTTikYRNjSzZ/ufXvo=; h=From:Date:Subject:To:Cc:Reply-To:From; b=teGua/Q1I7mjzL/15fGF13S37/IVV+2eRCE0VepC2yOj7CB1qy49G8ZnsdLazmysi t03nMLwGs8i5f7mw1jEpzJ0QA+9Qum2qAqDBgF52862tBpUZY+Wpv0BljQcx3NrXHl FT0+8ypaONV/LPT3sm9I+c7D2m4WWFkeuIWuF1EZcwAeGTnKU4UiJosOQAoYmhmhSY Iwx+AFkwkY+gjEVNCQBWfi3qcmHpcaOYtsBJLurmD5QmEInnxHJviHu9mENRFfr3F3 OTE4qQjohw9K57bvQnWp6rZIWprZbp7KIFXLCyk/jlU04H4MqKxzaMhogqAFH0Dw9g UUUykGgZxSqCw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3207CC02192; Tue, 4 Feb 2025 02:00:26 +0000 (UTC) From: Levi Zim via B4 Relay Date: Tue, 04 Feb 2025 10:00:21 +0800 Subject: [PATCH bpf-next] bpf: Add comment about helper freeze Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250204-bpf-helper-freeze-v1-1-46efd9ff20dc@outlook.com> X-B4-Tracking: v=1; b=H4sIALR0oWcC/x2MwQqDMBAFf0X27EKMbaH+ingw9m1dKGnYiIjiv 5v2ODAzB2WYIlNXHWRYNes3FmjqiqZ5jG+wvgqTd/7uvLtxSMIzPgnGYsAOnqSFC/4p4dFS6ZJ BdPs/e/rpEdtCw3lendXnF20AAAA= X-Change-ID: 20250204-bpf-helper-freeze-cf3e0b29fb63 To: Andrii Nakryiko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Eduard Zingerman , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Levi Zim X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1621; i=rsworktech@outlook.com; s=k2025; h=from:subject:message-id; bh=6MxVW0yx3y2sc56aoIwnnQLxARMxNt5S7Q5kXG2Yyow=; b=owEBbQKS/ZANAwAIAW87mNQvxsnYAcsmYgBnoXS33Zgy50y0RZLE0DRtBqoIrdiBvqGAqn6se uVAuspSn+GJAjMEAAEIAB0WIQQolnD5HDY18KF0JEVvO5jUL8bJ2AUCZ6F0twAKCRBvO5jUL8bJ 2KKwD/9EfjUuh1T541jPAYhMsPRyKAt2Hp/LKLLvN/+Ge4oP0zL7ZQUPyj/Rsu2vplfW0aLUUhx FQwikTq7LebKenRXqf8neZPlp0Rg+TytBV8WUd9fkH+pHeOekYBqmULHHn15OMueZPcOWNalpni bn+Zh4ZxegELJJKom3FhC49gtt6/seoYT41RPXw1xQrdmkcECZ5/lVAnUT82JAez6/TbL322Sqi IOsOWh8g+YnTYU2ThbnBkzqagxTeP3Q7P5GUpO15SlBZSk1iZaqYx5rllnoMXuDyIenDcwlWmRJ gUklsX3twS7OgzSksUuceaeoNVR17BRiQq60+l1RK3wyP3nfuhQgAGu/q2uNhtnBnoLsDJEyxMk O9qgD1F8YxRkkvxP84C0zbsAZb6L9F0k3OdyHZw5edYasp40dwzWsy/Pp0tFL6NiEWQSirb2Zu1 jvTfWacUkEBgbjrbgnuB/OEGu42Hl2dXYewTZRas9dZVXxQK7JIi8maI2uw2iqyJGwZ0NeSw8lL HgYBDoq5W5mo9wt7sed+pe53qVoNaCxlpZRsn3WFY0EbKsuZPkydB8w95dYPY9pIKRzNgW7P4lm Eo2BGfZrV+9JAiGg1IoQcfiPESOOLAouSpO6G6/kL5IeGHZJF3yFiXmlMrvN/TJAdEg++kOE4Sv yfsbeYQg1Qzjnkw== X-Developer-Key: i=rsworktech@outlook.com; a=openpgp; fpr=17AADD6726DDC58B8EE5881757670CCFA42CCF0A X-Endpoint-Received: by B4 Relay for rsworktech@outlook.com/k2025 with auth_id=336 X-Original-From: Levi Zim Reply-To: rsworktech@outlook.com X-Patchwork-Delegate: bpf@iogearbox.net From: Levi Zim Put a comment after the bpf helper list in uapi bpf.h to prevent people from trying to add new helpers there and direct them to kfuncs. Link: https://lore.kernel.org/bpf/CAEf4BzZvQF+QQ=oip4vdz5A=9bd+OmN-CXk5YARYieaipK9s+A@mail.gmail.com/ Link: https://lore.kernel.org/bpf/20221231004213.h5fx3loccbs5hyzu@macbook-pro-6.dhcp.thefacebook.com/ Suggested-by: Andrii Nakryiko Signed-off-by: Levi Zim Reviewed-by: Bagas Sanjaya Acked-by: Daniel Xu --- Put a comment after the bpf helper list in uapi bpf.h to prevent people from trying to add new helpers there and direct them to kfuncs. --- include/uapi/linux/bpf.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) --- base-commit: 03f3aa4a6b664270d502c7fb44c634cbe250261e change-id: 20250204-bpf-helper-freeze-cf3e0b29fb63 Best regards, diff --git a/include/uapi/linux/bpf.h b/include/uapi/linux/bpf.h index 2acf9b33637174bd16b1d12ccc6410c5f55a7ea9..fff6cdb8d11a2c211a6205ae2937b2bdf593cd42 100644 --- a/include/uapi/linux/bpf.h +++ b/include/uapi/linux/bpf.h @@ -6019,7 +6019,10 @@ union bpf_attr { FN(user_ringbuf_drain, 209, ##ctx) \ FN(cgrp_storage_get, 210, ##ctx) \ FN(cgrp_storage_delete, 211, ##ctx) \ - /* */ + /* This helper list is effectively frozen. If you are trying to \ + * add a new helper, you should add a kfunc instead which has \ + * less stability guarantees. See Documentation/bpf/kfuncs.rst \ + */ /* backwards-compatibility macros for users of __BPF_FUNC_MAPPER that don't * know or care about integer value that is now passed as second argument