| Message ID | 20250205114448.113966-1-znscnchen@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] vxlan: vxlan_rcv(): Update comment to inlucde ipv6 | expand |
On 2/5/25 13:44, Ted Chen wrote: > Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c > invoke vxlan_rcv() to process packets. > > The comment aligns with that for vxlan_err_lookup(). > > Cc: Ido Schimmel <idosch@idosch.org> > Signed-off-by: Ted Chen <znscnchen@gmail.com> > --- > drivers/net/vxlan/vxlan_core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c > index 5ef40ac816cc..8bdf91d1fdfe 100644 > --- a/drivers/net/vxlan/vxlan_core.c > +++ b/drivers/net/vxlan/vxlan_core.c > @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph, > return err <= 1; > } > > -/* Callback from net/ipv4/udp.c to receive packets */ > +/* Callback from net/ipv{4,6}/udp.c to receive packets */ > static int vxlan_rcv(struct sock *sk, struct sk_buff *skb) > { > struct vxlan_vni_node *vninode = NULL; Your subject has a typo s/inlucde/include IMO these comments are unnecessary, encap_rcv callers are trivial to find. Cheers, Nik
On Wed, Feb 05, 2025 at 02:12:50PM +0200, Nikolay Aleksandrov wrote: > On 2/5/25 13:44, Ted Chen wrote: > > Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c > > invoke vxlan_rcv() to process packets. > > > > The comment aligns with that for vxlan_err_lookup(). > > > > Cc: Ido Schimmel <idosch@idosch.org> > > Signed-off-by: Ted Chen <znscnchen@gmail.com> > > --- > > drivers/net/vxlan/vxlan_core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c > > index 5ef40ac816cc..8bdf91d1fdfe 100644 > > --- a/drivers/net/vxlan/vxlan_core.c > > +++ b/drivers/net/vxlan/vxlan_core.c > > @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph, > > return err <= 1; > > } > > > > -/* Callback from net/ipv4/udp.c to receive packets */ > > +/* Callback from net/ipv{4,6}/udp.c to receive packets */ > > static int vxlan_rcv(struct sock *sk, struct sk_buff *skb) > > { > > struct vxlan_vni_node *vninode = NULL; > > Your subject has a typo > s/inlucde/include Oops. Sorry for that. > IMO these comments are unnecessary, encap_rcv callers are trivial to find. I'm fine with either way. No comment is better than a wrong comment. Please let me know if I need to send a new version to correct the subject or remove the comments for both vxlan_rcv() and vxlan_err_lookup().
On 2/5/25 14:40, Ted Chen wrote: > On Wed, Feb 05, 2025 at 02:12:50PM +0200, Nikolay Aleksandrov wrote: >> On 2/5/25 13:44, Ted Chen wrote: >>> Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c >>> invoke vxlan_rcv() to process packets. >>> >>> The comment aligns with that for vxlan_err_lookup(). >>> >>> Cc: Ido Schimmel <idosch@idosch.org> >>> Signed-off-by: Ted Chen <znscnchen@gmail.com> >>> --- >>> drivers/net/vxlan/vxlan_core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c >>> index 5ef40ac816cc..8bdf91d1fdfe 100644 >>> --- a/drivers/net/vxlan/vxlan_core.c >>> +++ b/drivers/net/vxlan/vxlan_core.c >>> @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph, >>> return err <= 1; >>> } >>> >>> -/* Callback from net/ipv4/udp.c to receive packets */ >>> +/* Callback from net/ipv{4,6}/udp.c to receive packets */ >>> static int vxlan_rcv(struct sock *sk, struct sk_buff *skb) >>> { >>> struct vxlan_vni_node *vninode = NULL; >> >> Your subject has a typo >> s/inlucde/include > Oops. Sorry for that. > >> IMO these comments are unnecessary, encap_rcv callers are trivial to find. > I'm fine with either way. No comment is better than a wrong comment. > Please let me know if I need to send a new version to correct the subject or > remove the comments for both vxlan_rcv() and vxlan_err_lookup(). > Up to you, I don't have a strong preference. You have to wait 24 hours before posting another version anyway, so you have time to decide. :)
diff --git a/drivers/net/vxlan/vxlan_core.c b/drivers/net/vxlan/vxlan_core.c index 5ef40ac816cc..8bdf91d1fdfe 100644 --- a/drivers/net/vxlan/vxlan_core.c +++ b/drivers/net/vxlan/vxlan_core.c @@ -1684,7 +1684,7 @@ static bool vxlan_ecn_decapsulate(struct vxlan_sock *vs, void *oiph, return err <= 1; } -/* Callback from net/ipv4/udp.c to receive packets */ +/* Callback from net/ipv{4,6}/udp.c to receive packets */ static int vxlan_rcv(struct sock *sk, struct sk_buff *skb) { struct vxlan_vni_node *vninode = NULL;
Update the comment to indicate that both net/ipv4/udp.c and net/ipv6/udp.c invoke vxlan_rcv() to process packets. The comment aligns with that for vxlan_err_lookup(). Cc: Ido Schimmel <idosch@idosch.org> Signed-off-by: Ted Chen <znscnchen@gmail.com> --- drivers/net/vxlan/vxlan_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)