From patchwork Wed Feb 5 13:11:37 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 13961040 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.15.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E004E155744; Wed, 5 Feb 2025 13:12:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.15.18 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738761131; cv=none; b=Z8FIp8+X3EHEob0+Kei91vsnJhgCCFl26aWrzAKJAta7f0FzOL3mPefbmxc6acdfXYdZouuyZHRJI7iR2QVgWBCkgA+9KzOcKEumJer2NhEwFxY8WV1G7Xm7Sh3zF2h8ku0OEQ+stUTotlnMtFaY302DTXKFRcaK4yN2WjHQsWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738761131; c=relaxed/simple; bh=7QZaHf/CYlNWEU18pei7TUReKsakGS4hi+m14IEnps8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=C7rotcElEA57a9e5xp0CyGn0bFO52dnCElMH+HwjO2kgMdTDdf39bNh24bfQ0TfJTYhoIfcNDBYPUj2FYgNCEsHn1cW3intvk1seCzOi7LyvvbLDDCj+Ty8a/tGLiLuBezVvw5bgTxUJZu8dvXdDh3zCIsO0yToZtwR0J9hqftw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=YidLCkgZ; arc=none smtp.client-ip=212.227.15.18 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="YidLCkgZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1738761121; x=1739365921; i=ps.report@gmx.net; bh=7QZaHf/CYlNWEU18pei7TUReKsakGS4hi+m14IEnps8=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=YidLCkgZMCEObyQsY5UW4uJbEsgE+SGL3wyVoX/yiMrjJwZEK6xv/r11r3A3Wc5c CKxDe/VSA+3zY+QhPjDqvf8Tl6CCpfCbPU4YuktdU8n+CKwU61jfK0je+zqdR9SxI SZp3L1DRQTOTtdS1YXIcceH5uLX4QnferTQAh1b2xGgRsab7UsR7eve8HFKjk2aCK LicVt5usOw+FVwRO4LkLzDLgfoFpea6jBKnLz7lnbhQcXqj4Y4Nr+pe8hpiAuXgrq 2emIAnGAk1gExYPXv2o2beYQ4NwEkYWDfuxXqitDGaiaJiQYpT349oUlBeDacnMBB Gox+VduCazsoAAiaNw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.162]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M8QS2-1tk5330GeW-001aGw; Wed, 05 Feb 2025 14:12:01 +0100 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Shuah Khan , Peter Seiderer Subject: [PATCH net-next v4 01/17] net: pktgen: replace ENOTSUPP with EOPNOTSUPP Date: Wed, 5 Feb 2025 14:11:37 +0100 Message-ID: <20250205131153.476278-2-ps.report@gmx.net> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250205131153.476278-1-ps.report@gmx.net> References: <20250205131153.476278-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:IBhPBAOoqo99Y/75uYu459DKOWrK585/4s4eUkDuXn5MbymJS7Z hq2duso6O9jYw3QoVX4oy69dP47wUOEcJQY7SKFFHfw3Pfck6inRbenIt6JOsS/oq7jEGwm ZfMhYXaEJh1fCyz0ruqztukfkQf9UBg7ejYuRjfFiA6SfQ2fSlYxj6dbn7M8VIAVOjTa77w 4bmLAh6mCKlZ2C6jER73Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:MfsmF18LbUU=;Mvk3lVDu+duCQ/SH3nuszY2c7BL vJEYQGTy4Pmcz4G5Jlw2XyNjnVCQZWqfBOTlDC9CXosHVST7vNormg3mZyxy84e4qN6poj2Io YJECm4vTZvXfExchHKm/xEj5kJ2fnswR5XVRe6J1+d7oQxa+YyEOSBlcoTyTvtaOv2Beifh0O nHCzRxr1D+92W0A9WgP0AagoBelPb0Xlm1nWOJpPIt9JrcJaRU5E8cSyTG//lHUJFkX4Jxe3i QmARg5tiPPn5Tv57l3Gf7tSdb0qFwrebZnBfiTU/TJYKsmE0Qqx7lE4vg//6eyXRH59VhVKPy pmHDOdN0NYO0o01SRpMDinAtKH6lpYLC3zkq9jbydedMsP/dS30d4wXCP2ulp2ae5uw0ssBQV YPAf85ymvOPfWFrQ/kLEVT+CJZXB9xwWCtQNCJDtowgqokiXSqQp8p9Fj+M7HxRPGA10RY+2Q Fcv3HFhKqCZm42hotSF3skz5DzwvHWQ0k1KLHt9zNpo2fSZaPgJGc/OpXxN6xWFdPGkxSWXHn uA/Pv4nuHEtB4OVH/p8mJfAGoWTLId7ePSbkruMs8oEUtQc6d+RRkTNxuBhoUAdI8caouxPSg 2tL6w8/lotjiyjFuGojYYrONjYljN3RQppnvov+azlnsFAMiDpEGn65JhRegvNWF660DlvYiJ 0ZEb9+iTUTONIQW+3oBZ0v/JLWWY58C0TpV0QX+2/lGkiUtOl5CimQx7D68h/QIlE0HpmYAHu UbvL/2fKYd+drz/QKcvK5fA+iYOGdTLe/Nz+Ys7Rkv0LusfvyEImT/p+f0GuKAiMEtxNX9wab KfYnOyrTOYAM63w23zdWIt5/LTmR5YWtp7mUblwyYsvM94mIYaQZrWg3S1oLoFgH9Asbt1XAy QcHlZw/onH89eMBxjL0fMYHfFy0HYf8OXLkk5SWXX24UeFrxxVOQugIegUdSYajD4aAeTmreI qz4pppyP7s+QI+gkfiQLgHkLi8c3peiFloabEIIzExfzgHxcPdirI3uFe5txpZ1QbU2FDNsGF dUDwDjt6nDKdy0uiG1Is+AT119piJBqXsDl0uoeZxWRmV9ykt9VLK1HDDUYsI489v3rhb+1v/ 0BanrjYZ2eexTHkuLA//67hfHJK99A3RcKJh8wYu/ys3FGMAwFghxr/g2W83jabqW7feGM8l0 kQ4PZvz+QtChfOJ6JI7L6CVndX7g/Sx3qvVp8n5VCKwVHR3TntXIaPtsNM7QA/48sfGtTBdHT Ge+v6AEg9oU/0vjXyTkzm7xlvoBKzfToCjeX9c2xjIvdZC2+khzH9K+T02byLbu4jEkQpYgMW aOsXmiZNrkXL1g9xBX6PUncKPkfhA/dEv2n9jrMjt2+bs47sMrxe3gKAwnuvXB+rHHWkDeztD a8Ozf0hVsehYKLDnpUMpVrsB1LyuhmbWH/ckxaLfr9xJEBe4m0lpQyewHU X-Patchwork-Delegate: kuba@kernel.org Replace ENOTSUPP with EOPNOTSUPP, fixes checkpatch hint WARNING: ENOTSUPP is not a SUSV4 error code, prefer EOPNOTSUPP and e.g. $ echo "clone_skb 1" > /proc/net/pktgen/lo\@0 -bash: echo: write error: Unknown error 524 Signed-off-by: Peter Seiderer Reviewed-by: Simon Horman --- Changes v3 -> v4 - add rev-by Simon Horman Changes v2 -> v3 - no changes Changes v1 -> v2 - no changes --- net/core/pktgen.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 82b6a2c3c141..496aa16773e7 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1198,7 +1198,7 @@ static ssize_t pktgen_if_write(struct file *file, if ((value > 0) && ((pkt_dev->xmit_mode == M_NETIF_RECEIVE) || !(pkt_dev->odev->priv_flags & IFF_TX_SKB_SHARING))) - return -ENOTSUPP; + return -EOPNOTSUPP; if (value > 0 && (pkt_dev->n_imix_entries > 0 || !(pkt_dev->flags & F_SHARED))) return -EINVAL; @@ -1258,7 +1258,7 @@ static ssize_t pktgen_if_write(struct file *file, ((pkt_dev->xmit_mode == M_QUEUE_XMIT) || ((pkt_dev->xmit_mode == M_START_XMIT) && (!(pkt_dev->odev->priv_flags & IFF_TX_SKB_SHARING))))) - return -ENOTSUPP; + return -EOPNOTSUPP; if (value > 1 && !(pkt_dev->flags & F_SHARED)) return -EINVAL; @@ -1303,7 +1303,7 @@ static ssize_t pktgen_if_write(struct file *file, } else if (strcmp(f, "netif_receive") == 0) { /* clone_skb set earlier, not supported in this mode */ if (pkt_dev->clone_skb > 0) - return -ENOTSUPP; + return -EOPNOTSUPP; pkt_dev->xmit_mode = M_NETIF_RECEIVE;