| Message ID | 20250207013117.104205-5-zhangzekun11@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add wrapper function of_find_node_by_name_balanced() | expand |
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c index 9fc4e130a273..0299d08a7196 100644 --- a/drivers/media/i2c/max9286.c +++ b/drivers/media/i2c/max9286.c @@ -1399,9 +1399,7 @@ static int max9286_parse_dt(struct max9286_priv *priv) u32 i2c_clk_freq = 105000; unsigned int i; - /* Balance the of_node_put() performed by of_find_node_by_name(). */ - of_node_get(dev->of_node); - i2c_mux = of_find_node_by_name(dev->of_node, "i2c-mux"); + i2c_mux = of_find_node_by_name_balanced(dev->of_node, "i2c-mux"); if (!i2c_mux) { dev_err(dev, "Failed to find i2c-mux node\n"); return -EINVAL;
Instead of directly using of_node_get() before of_find_node_by_name() to balance the refcount of the device_node, using wraper function of_find_node_by_name_balanced() to make code logic a bit simplier. Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> --- drivers/media/i2c/max9286.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)