| Message ID | 20250207013117.104205-9-zhangzekun11@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Add wrapper function of_find_node_by_name_balanced() | expand |
diff --git a/drivers/net/ethernet/marvell/prestera/prestera_main.c b/drivers/net/ethernet/marvell/prestera/prestera_main.c index 440a4c42b405..5d10031bfa32 100644 --- a/drivers/net/ethernet/marvell/prestera/prestera_main.c +++ b/drivers/net/ethernet/marvell/prestera/prestera_main.c @@ -378,8 +378,7 @@ static int prestera_port_sfp_bind(struct prestera_port *port) if (!sw->np) return 0; - of_node_get(sw->np); - ports = of_find_node_by_name(sw->np, "ports"); + ports = of_find_node_by_name_balanced(sw->np, "ports"); for_each_child_of_node(ports, node) { int num;
Instead of directly using of_node_get() before of_find_node_by_name() to balance the refcount of the device_node, using wraper function of_find_node_by_name_balanced() to make code logic a bit simplier. Signed-off-by: Zhang Zekun <zhangzekun11@huawei.com> --- drivers/net/ethernet/marvell/prestera/prestera_main.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)