| Message ID | 20250207183119.1721424-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a980da54b6a457e8d9ceb02d7c2ba6a47fc3d502 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] selftests: drv-net: remove an unnecessary libmnl include | expand |
On Fri, Feb 7, 2025 at 10:31 AM Jakub Kicinski <kuba@kernel.org> wrote: > > ncdevmem doesn't need libmnl, remove the unnecessary include. > > Since YNL doesn't depend on libmnl either, any more, it's actually > possible to build selftests without having libmnl installed. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> Whoops, sorry about that. Reviewed-by: Mina Almasry <almasrymina@google.com>
On Fri, Feb 07, 2025 at 10:31:19AM -0800, Jakub Kicinski wrote: > ncdevmem doesn't need libmnl, remove the unnecessary include. > > Since YNL doesn't depend on libmnl either, any more, it's actually > possible to build selftests without having libmnl installed. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: shuah@kernel.org > CC: almasrymina@google.com > CC: sdf@fomichev.me > CC: jdamato@fastly.com > CC: linux-kselftest@vger.kernel.org > --- > tools/testing/selftests/drivers/net/hw/ncdevmem.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Joe Damato <jdamato@fastly.com>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Fri, 7 Feb 2025 10:31:19 -0800 you wrote: > ncdevmem doesn't need libmnl, remove the unnecessary include. > > Since YNL doesn't depend on libmnl either, any more, it's actually > possible to build selftests without having libmnl installed. > > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > > [...] Here is the summary with links: - [net-next] selftests: drv-net: remove an unnecessary libmnl include https://git.kernel.org/netdev/net-next/c/a980da54b6a4 You are awesome, thank you!
diff --git a/tools/testing/selftests/drivers/net/hw/ncdevmem.c b/tools/testing/selftests/drivers/net/hw/ncdevmem.c index 19a6969643f4..2bf14ac2b8c6 100644 --- a/tools/testing/selftests/drivers/net/hw/ncdevmem.c +++ b/tools/testing/selftests/drivers/net/hw/ncdevmem.c @@ -50,7 +50,6 @@ #include <linux/memfd.h> #include <linux/dma-buf.h> #include <linux/udmabuf.h> -#include <libmnl/libmnl.h> #include <linux/types.h> #include <linux/netlink.h> #include <linux/genetlink.h>
ncdevmem doesn't need libmnl, remove the unnecessary include. Since YNL doesn't depend on libmnl either, any more, it's actually possible to build selftests without having libmnl installed. Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: shuah@kernel.org CC: almasrymina@google.com CC: sdf@fomichev.me CC: jdamato@fastly.com CC: linux-kselftest@vger.kernel.org --- tools/testing/selftests/drivers/net/hw/ncdevmem.c | 1 - 1 file changed, 1 deletion(-)