| Message ID | 20250212131413.91787-2-jedrzej.jagielski@intel.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | ixgbe: Add basic devlink support | expand |
Wed, Feb 12, 2025 at 02:14:00PM +0100, jedrzej.jagielski@intel.com wrote: >Prevent from proceeding if there's nothing to print. > >Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> >Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com> Reviewed-by: Jiri Pirko <jiri@nvidia.com>
diff --git a/net/devlink/dev.c b/net/devlink/dev.c index d6e3db300acb..02602704bdea 100644 --- a/net/devlink/dev.c +++ b/net/devlink/dev.c @@ -775,7 +775,7 @@ static int devlink_info_version_put(struct devlink_info_req *req, int attr, req->version_cb(version_name, version_type, req->version_cb_priv); - if (!req->msg) + if (!req->msg || !*version_value) return 0; nest = nla_nest_start_noflag(req->msg, attr);
Prevent from proceeding if there's nothing to print. Suggested-by: Przemek Kitszel <przemyslaw.kitszel@intel.com> Signed-off-by: Jedrzej Jagielski <jedrzej.jagielski@intel.com> --- net/devlink/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)