diff mbox series

[net-next,2/4] net/mlx5: Prefix temperature event bitmap with '0x' for clarity

Message ID 20250213094641.226501-3-tariqt@nvidia.com (mailing list archive)
State Accepted
Commit b9b72ce0f5f4679fc878ad010658a72f30595118
Delegated to: Netdev Maintainers
Headers show
Series mlx5: Add sensor name in temperature message | expand

Checks

Context Check Description
netdev/series_format success Posting correctly formatted
netdev/tree_selection success Clearly marked for net-next
netdev/ynl success Generated files up to date; no warnings/errors; no diff in generated;
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 0 this patch: 0
netdev/build_tools success No tools touched, skip
netdev/cc_maintainers success CCed 9 of 9 maintainers
netdev/build_clang success Errors and warnings before: 2 this patch: 2
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 0 this patch: 0
netdev/checkpatch success total: 0 errors, 0 warnings, 0 checks, 8 lines checked
netdev/build_clang_rust success No Rust files in patch. Skipping build
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0
netdev/contest success net-next-2025-02-15--03-00 (tests: 891)

Commit Message

Tariq Toukan Feb. 13, 2025, 9:46 a.m. UTC
From: Shahar Shitrit <shshitrit@nvidia.com>

Prepend '0x' to the sensor bitmap in the warning message to clearly
indicate that the bitmap is in hexadecimal format.

Signed-off-by: Shahar Shitrit <shshitrit@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 drivers/net/ethernet/mellanox/mlx5/core/events.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mateusz Polchlopek Feb. 13, 2025, 10:33 a.m. UTC | #1
On 2/13/2025 10:46 AM, Tariq Toukan wrote:
> From: Shahar Shitrit <shshitrit@nvidia.com>
> 
> Prepend '0x' to the sensor bitmap in the warning message to clearly
> indicate that the bitmap is in hexadecimal format.
> 
> Signed-off-by: Shahar Shitrit <shshitrit@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> ---
>   drivers/net/ethernet/mellanox/mlx5/core/events.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/events.c b/drivers/net/ethernet/mellanox/mlx5/core/events.c
> index e8beb6289d01..a661aa522a9a 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/events.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/events.c
> @@ -167,7 +167,7 @@ static int temp_warn(struct notifier_block *nb, unsigned long type, void *data)
>   
>   	if (net_ratelimit())
>   		mlx5_core_warn(events->dev,
> -			       "High temperature on sensors with bit set %llx %llx",
> +			       "High temperature on sensors with bit set %#llx %#llx",
>   			       value_msb, value_lsb);
>   
>   	return NOTIFY_OK;

Reviewed-by: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ethernet/mellanox/mlx5/core/events.c b/drivers/net/ethernet/mellanox/mlx5/core/events.c
index e8beb6289d01..a661aa522a9a 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/events.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/events.c
@@ -167,7 +167,7 @@  static int temp_warn(struct notifier_block *nb, unsigned long type, void *data)
 
 	if (net_ratelimit())
 		mlx5_core_warn(events->dev,
-			       "High temperature on sensors with bit set %llx %llx",
+			       "High temperature on sensors with bit set %#llx %#llx",
 			       value_msb, value_lsb);
 
 	return NOTIFY_OK;