Message ID | 20250216013155.643127-1-ant.v.moryakov@gmail.com (mailing list archive) |
---|---|
State | Superseded |
Delegated to: | David Ahern |
Headers | show |
Series | ip: remove duplicate condition in ila_csum_name2mode in | expand |
Context | Check | Description |
---|---|---|
netdev/tree_selection | success | Not a local patch |
diff --git a/ip/ila_common.h b/ip/ila_common.h index f99c2672..cd3524d5 100644 --- a/ip/ila_common.h +++ b/ip/ila_common.h @@ -31,8 +31,6 @@ static inline int ila_csum_name2mode(char *name) return ILA_CSUM_NEUTRAL_MAP_AUTO; else if (strcmp(name, "no-action") == 0) return ILA_CSUM_NO_ACTION; - else if (strcmp(name, "neutral-map-auto") == 0) - return ILA_CSUM_NEUTRAL_MAP_AUTO; else return -1; }
Static analyzer reported: expression is identical to previous conditio Corrections explained: The condition checking for "neutral-map-auto" was duplicated in the ila_csum_name2mode function. This commit removes the redundant check to improve code readability and maintainability. Triggers found by static analyzer Svace. Signed-off-by: Anton Moryakov <ant.v.moryakov@gmail.com> --- ip/ila_common.h | 2 -- 1 file changed, 2 deletions(-)