| Message ID | 20250219-qt2025-comment-fix-v2-1-029f67696516@posteo.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 8279a8dacf9f975c37f3dc51634b6c4a8936c57b |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net,v2] net: phy: qt2025: Fix hardware revision check comment | expand |
On Wed, Feb 19, 2025 at 12:41:55PM +0000, Charalampos Mitrodimas wrote: > Correct the hardware revision check comment in the QT2025 driver. The > revision value was documented as 0x3b instead of the correct 0xb3, > which matches the actual comparison logic in the code. > > Fixes: fd3eaad826da ("net: phy: add Applied Micro QT2025 PHY driver") > Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com> > Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
On Wed, Feb 19, 2025 at 7:42 AM Charalampos Mitrodimas <charmitro@posteo.net> wrote: > > Correct the hardware revision check comment in the QT2025 driver. The > revision value was documented as 0x3b instead of the correct 0xb3, > which matches the actual comparison logic in the code. > > Fixes: fd3eaad826da ("net: phy: add Applied Micro QT2025 PHY driver") > Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com> > Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> Reviewed-by: Trevor Gross <tmgross@umich.edu>
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 19 Feb 2025 12:41:55 +0000 you wrote: > Correct the hardware revision check comment in the QT2025 driver. The > revision value was documented as 0x3b instead of the correct 0xb3, > which matches the actual comparison logic in the code. > > Fixes: fd3eaad826da ("net: phy: add Applied Micro QT2025 PHY driver") > Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com> > Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> > > [...] Here is the summary with links: - [net,v2] net: phy: qt2025: Fix hardware revision check comment https://git.kernel.org/netdev/net-next/c/8279a8dacf9f You are awesome, thank you!
diff --git a/drivers/net/phy/qt2025.rs b/drivers/net/phy/qt2025.rs index 1ab065798175b4f54c5f2fd6c871ba2942c48bf1..7e754d5d71544c6d6b6a6d90416a5a130ba76108 100644 --- a/drivers/net/phy/qt2025.rs +++ b/drivers/net/phy/qt2025.rs @@ -41,7 +41,7 @@ impl Driver for PhyQT2025 { fn probe(dev: &mut phy::Device) -> Result<()> { // Check the hardware revision code. - // Only 0x3b works with this driver and firmware. + // Only 0xb3 works with this driver and firmware. let hw_rev = dev.read(C45::new(Mmd::PMAPMD, 0xd001))?; if (hw_rev >> 8) != 0xb3 { return Err(code::ENODEV);
Correct the hardware revision check comment in the QT2025 driver. The revision value was documented as 0x3b instead of the correct 0xb3, which matches the actual comparison logic in the code. Fixes: fd3eaad826da ("net: phy: add Applied Micro QT2025 PHY driver") Reviewed-by: FUJITA Tomonori <fujita.tomonori@gmail.com> Signed-off-by: Charalampos Mitrodimas <charmitro@posteo.net> --- Changes in v2: - Resend with proper patch subject, according to netdev documentation - Add "Fixes: " tag - Link to v1: https://lore.kernel.org/r/20250218-qt2025-comment-fix-v1-1-743e87c0040c@posteo.net --- drivers/net/phy/qt2025.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: beeb78d46249cab8b2b8359a2ce8fa5376b5ad2d change-id: 20250218-qt2025-comment-fix-31a7f8fcbc64 Best regards,