From patchwork Mon Feb 24 18:08:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stanislav Fomichev X-Patchwork-Id: 13988677 X-Patchwork-Delegate: kuba@kernel.org Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 01665264FA6 for ; Mon, 24 Feb 2025 18:08:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740420501; cv=none; b=dpH9g8DXJTC8Ce0YwilCNO3xE3BqVvxAHY3p493XW0qgN4WGDgDTVu0/p7wjcaw5JN4RXHHjMcgdB6cVUPN+sxlMThvpK9RHeEcfUCa6TTl8KKLgszqYOua50dTLHw1J+UfW9OPO5wIC1WJUPTnNkFZp4la5wVBtP9eFcZ51mRI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740420501; c=relaxed/simple; bh=kXaYBqASN5+V6ZP6KD/bBm3KMCh2Fqrvp2Jk2q2l5BE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=uP8H+ppjJ8yjjmVCqMmXX9XHu/p0azxG99JHLEmlWvjGkIOOJUbakWnWksn1PkHitZekTHgHEBAfpMPnIAxEMpqHrovJzXD3Dm4DOqkXyMMCUTEzhYHo5hw3Xjw8u77efRfeWJA/c1w0l1ujsFtWxK23xFdxPi0leQmIWEwIMMs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me; spf=pass smtp.mailfrom=gmail.com; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fomichev.me Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2fc0026eb79so9690105a91.0 for ; Mon, 24 Feb 2025 10:08:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740420499; x=1741025299; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TshGRqdcoaoHschjXBsL8R/GNWjGZ6wmA0C8tW0sSKk=; b=IoBOYxRUC6i8qPjMXZ/haORfsSAya03Wgrw3yGUpMu6hSv53zdRDdD3NbcKbqzXpN8 4kRUUbEkf0UgGtHV3Plme3ynJdDEXlFmV6JMM3fr0I+nY+vawaWdIfjRJBN3ISeE83NM K/0cc8QsM6orDFIou/HUwuGWGDtdNe7xyhCMKAEImqjMOuGBjFYYeEENnLI6udhpA14j ujlu9O8JLHVpo1TrjMKRpJT1AfIrYJzodDnFoF3Bjg7s91+VMxLzl/NE4K2Kt3W7G+nN 2CndVMc1mdvvFZZz2RFoqFWn8bNmlOvCtW3CSOlOrYac/OluTChkUjNtACdtsDktZDe9 Ymag== X-Gm-Message-State: AOJu0YxQ3Qf9SstYqLV1yCkkILscyW6Jm6Z9uyGZn/DWTFWPHrZ7fWAZ LS22Ytnc6j0xRjAcrAyQNTE/zhvNVLzki5kMRrUKEwjSPrWrkmbJuOTo X-Gm-Gg: ASbGnct/xAvufV/Evc+Lgt8E6wfrgtL/YFPsW+kdYUj8pLNfpDwmeLLEq/NpaHAGdEE STIfztmnc/J7Lw1QdbBGbx9LJMYqzbpabdL7GUFRn11/qZAQrIUfLROAByjJo6m8ma2UFzF/frO g0U/Y7WjjF+AkjM4u3AcDzL4lMg4QMc7jRLMSEIXiXBkuiwXiJuJknJBXVS8ZfL8xNz1WyENimz 7uA78cbWrXONK4gz749Dqr4PG45CPkcQNAmuJpq4E15UnKPp+WYVQJGrt6QQeYcWajY9NYTETuI hC1kRL7NFXwoQv6SNw4wRjw9Xg== X-Google-Smtp-Source: AGHT+IE3c9TX9QmU0F4bnFgQY4EgBSDCmGFw/GGfufPgbcoaWpadDjyc24pagSzzxbDYcZBF3ifO8A== X-Received: by 2002:a17:90b:4c4b:b0:2ee:8427:4b02 with SMTP id 98e67ed59e1d1-2fce7b23610mr23713653a91.28.1740420498916; Mon, 24 Feb 2025 10:08:18 -0800 (PST) Received: from localhost ([2601:646:9e00:f56e:123b:cea3:439a:b3e3]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-2fceb04bedbsm6971298a91.18.2025.02.24.10.08.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 24 Feb 2025 10:08:18 -0800 (PST) From: Stanislav Fomichev To: netdev@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, Saeed Mahameed Subject: [PATCH net-next v7 07/12] net: hold netdev instance lock during ndo_bpf Date: Mon, 24 Feb 2025 10:08:03 -0800 Message-ID: <20250224180809.3653802-8-sdf@fomichev.me> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250224180809.3653802-1-sdf@fomichev.me> References: <20250224180809.3653802-1-sdf@fomichev.me> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Patchwork-Delegate: kuba@kernel.org Cover the paths that come via bpf system call and XSK bind. Cc: Saeed Mahameed Signed-off-by: Stanislav Fomichev --- include/linux/netdevice.h | 1 + kernel/bpf/offload.c | 6 ++++-- net/core/dev.c | 13 +++++++++++-- net/core/dev_api.c | 12 ++++++++++++ net/xdp/xsk.c | 3 +++ net/xdp/xsk_buff_pool.c | 2 ++ 6 files changed, 33 insertions(+), 4 deletions(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index 7bf64fd29532..7eabcb203e92 100644 --- a/include/linux/netdevice.h +++ b/include/linux/netdevice.h @@ -4239,6 +4239,7 @@ struct sk_buff *dev_hard_start_xmit(struct sk_buff *skb, struct net_device *dev, int bpf_xdp_link_attach(const union bpf_attr *attr, struct bpf_prog *prog); u8 dev_xdp_prog_count(struct net_device *dev); +int netif_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf); int dev_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf); u8 dev_xdp_sb_prog_count(struct net_device *dev); u32 dev_xdp_prog_id(struct net_device *dev, enum bpf_xdp_mode mode); diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c index 1a4fec330eaa..a10153c3be2d 100644 --- a/kernel/bpf/offload.c +++ b/kernel/bpf/offload.c @@ -528,10 +528,10 @@ struct bpf_map *bpf_map_offload_map_alloc(union bpf_attr *attr) return ERR_PTR(-ENOMEM); bpf_map_init_from_attr(&offmap->map, attr); - rtnl_lock(); - down_write(&bpf_devs_lock); offmap->netdev = __dev_get_by_index(net, attr->map_ifindex); + netdev_lock_ops(offmap->netdev); + down_write(&bpf_devs_lock); err = bpf_dev_offload_check(offmap->netdev); if (err) goto err_unlock; @@ -548,12 +548,14 @@ struct bpf_map *bpf_map_offload_map_alloc(union bpf_attr *attr) list_add_tail(&offmap->offloads, &ondev->maps); up_write(&bpf_devs_lock); + netdev_unlock_ops(offmap->netdev); rtnl_unlock(); return &offmap->map; err_unlock: up_write(&bpf_devs_lock); + netdev_unlock_ops(offmap->netdev); rtnl_unlock(); bpf_map_area_free(offmap); return ERR_PTR(err); diff --git a/net/core/dev.c b/net/core/dev.c index 3d7e361134b4..80c2ee985dc6 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -9726,7 +9726,7 @@ u8 dev_xdp_sb_prog_count(struct net_device *dev) return count; } -int dev_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf) +int netif_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf) { if (!dev->netdev_ops->ndo_bpf) return -EOPNOTSUPP; @@ -9746,7 +9746,6 @@ int dev_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf) return dev->netdev_ops->ndo_bpf(dev, bpf); } -EXPORT_SYMBOL_GPL(dev_xdp_propagate); u32 dev_xdp_prog_id(struct net_device *dev, enum bpf_xdp_mode mode) { @@ -9776,6 +9775,8 @@ static int dev_xdp_install(struct net_device *dev, enum bpf_xdp_mode mode, struct netdev_bpf xdp; int err; + netdev_ops_assert_locked(dev); + if (dev->cfg->hds_config == ETHTOOL_TCP_DATA_SPLIT_ENABLED && prog && !prog->aux->xdp_has_frags) { NL_SET_ERR_MSG(extack, "unable to install XDP to device using tcp-data-split"); @@ -10008,7 +10009,9 @@ static void bpf_xdp_link_release(struct bpf_link *link) * already NULL, in which case link was already auto-detached */ if (xdp_link->dev) { + netdev_lock_ops(xdp_link->dev); WARN_ON(dev_xdp_detach_link(xdp_link->dev, NULL, xdp_link)); + netdev_unlock_ops(xdp_link->dev); xdp_link->dev = NULL; } @@ -10090,10 +10093,12 @@ static int bpf_xdp_link_update(struct bpf_link *link, struct bpf_prog *new_prog, goto out_unlock; } + netdev_lock_ops(xdp_link->dev); mode = dev_xdp_mode(xdp_link->dev, xdp_link->flags); bpf_op = dev_xdp_bpf_op(xdp_link->dev, mode); err = dev_xdp_install(xdp_link->dev, mode, bpf_op, NULL, xdp_link->flags, new_prog); + netdev_unlock_ops(xdp_link->dev); if (err) goto out_unlock; @@ -10879,7 +10884,9 @@ int register_netdevice(struct net_device *dev) if (ret) goto err_uninit_notify; + netdev_lock_ops(dev); __netdev_update_features(dev); + netdev_unlock_ops(dev); /* * Default initial state at registry is that the @@ -11818,7 +11825,9 @@ void unregister_netdevice_many_notify(struct list_head *head, /* Shutdown queueing discipline. */ dev_shutdown(dev); dev_tcx_uninstall(dev); + netdev_lock_ops(dev); dev_xdp_uninstall(dev); + netdev_unlock_ops(dev); bpf_dev_bound_netdev_unregister(dev); dev_memory_provider_uninstall(dev); diff --git a/net/core/dev_api.c b/net/core/dev_api.c index 87a62022ef1c..0db20ed086d3 100644 --- a/net/core/dev_api.c +++ b/net/core/dev_api.c @@ -317,3 +317,15 @@ int dev_set_mac_address(struct net_device *dev, struct sockaddr *sa, return ret; } EXPORT_SYMBOL(dev_set_mac_address); + +int dev_xdp_propagate(struct net_device *dev, struct netdev_bpf *bpf) +{ + int ret; + + netdev_lock_ops(dev); + ret = netif_xdp_propagate(dev, bpf); + netdev_unlock_ops(dev); + + return ret; +} +EXPORT_SYMBOL_GPL(dev_xdp_propagate); diff --git a/net/xdp/xsk.c b/net/xdp/xsk.c index 84bf9f1d4bf2..f864e5d70b40 100644 --- a/net/xdp/xsk.c +++ b/net/xdp/xsk.c @@ -1181,6 +1181,8 @@ static int xsk_bind(struct socket *sock, struct sockaddr *addr, int addr_len) goto out_release; } + netdev_lock_ops(dev); + if (!xs->rx && !xs->tx) { err = -EINVAL; goto out_unlock; @@ -1315,6 +1317,7 @@ static int xsk_bind(struct socket *sock, struct sockaddr *addr, int addr_len) smp_wmb(); WRITE_ONCE(xs->state, XSK_BOUND); } + netdev_unlock_ops(dev); out_release: mutex_unlock(&xs->mutex); rtnl_unlock(); diff --git a/net/xdp/xsk_buff_pool.c b/net/xdp/xsk_buff_pool.c index c263fb7a68dc..0e6ca568fdee 100644 --- a/net/xdp/xsk_buff_pool.c +++ b/net/xdp/xsk_buff_pool.c @@ -1,5 +1,6 @@ // SPDX-License-Identifier: GPL-2.0 +#include #include #include #include @@ -219,6 +220,7 @@ int xp_assign_dev(struct xsk_buff_pool *pool, bpf.xsk.pool = pool; bpf.xsk.queue_id = queue_id; + netdev_ops_assert_locked(netdev); err = netdev->netdev_ops->ndo_bpf(netdev, &bpf); if (err) goto err_unreg_pool;