| Message ID | 20250227-ipa-v4-7-fixes-v1-3-a88dd8249d8a@fairphone.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 934e69669e32eb653234898424ae007bae2f636e |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fixes for IPA v4.7 | expand |
On 2/27/25 4:33 AM, Luca Weiss wrote: > Enable the checksum option for these two endpoints in order to allow > mobile data to actually work. Without this, no packets seem to make it > through the IPA. > > Fixes: b310de784bac ("net: ipa: add IPA v4.7 support") > Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> This makes sense. The checksum option affects how outgoing packets are formatted and incoming packets are interpreted by the IPA hardware. So with this being wrong, I suppose packets (one way and/or the other) might just be getting dropped as invalid. This looks good to me. I'm really pleased you were able to get this working. Reviewed-by: Alex Elder <elder@riscstar.com> > --- > drivers/net/ipa/data/ipa_data-v4.7.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ipa/data/ipa_data-v4.7.c b/drivers/net/ipa/data/ipa_data-v4.7.c > index e63dcf8d45567b0851393c2cea7a0d630afa20cd..41f212209993f10fee338e28027739a7402d5089 100644 > --- a/drivers/net/ipa/data/ipa_data-v4.7.c > +++ b/drivers/net/ipa/data/ipa_data-v4.7.c > @@ -104,6 +104,7 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = { > .filter_support = true, > .config = { > .resource_group = IPA_RSRC_GROUP_SRC_UL_DL, > + .checksum = true, > .qmap = true, > .status_enable = true, > .tx = { > @@ -127,6 +128,7 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = { > .endpoint = { > .config = { > .resource_group = IPA_RSRC_GROUP_DST_UL_DL, > + .checksum = true, > .qmap = true, > .aggregation = true, > .rx = { >
diff --git a/drivers/net/ipa/data/ipa_data-v4.7.c b/drivers/net/ipa/data/ipa_data-v4.7.c index e63dcf8d45567b0851393c2cea7a0d630afa20cd..41f212209993f10fee338e28027739a7402d5089 100644 --- a/drivers/net/ipa/data/ipa_data-v4.7.c +++ b/drivers/net/ipa/data/ipa_data-v4.7.c @@ -104,6 +104,7 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = { .filter_support = true, .config = { .resource_group = IPA_RSRC_GROUP_SRC_UL_DL, + .checksum = true, .qmap = true, .status_enable = true, .tx = { @@ -127,6 +128,7 @@ static const struct ipa_gsi_endpoint_data ipa_gsi_endpoint_data[] = { .endpoint = { .config = { .resource_group = IPA_RSRC_GROUP_DST_UL_DL, + .checksum = true, .qmap = true, .aggregation = true, .rx = {
Enable the checksum option for these two endpoints in order to allow mobile data to actually work. Without this, no packets seem to make it through the IPA. Fixes: b310de784bac ("net: ipa: add IPA v4.7 support") Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> --- drivers/net/ipa/data/ipa_data-v4.7.c | 2 ++ 1 file changed, 2 insertions(+)