| Message ID | 20250227092441.1848419-1-m-malladi@ti.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 54e1b4becf5e220be03db4e1be773c1310e8cbbd |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] net: ti: icss-iep: Reject perout generation request | expand |
On 27/02/2025 09:24, Meghana Malladi wrote: > IEP driver supports both perout and pps signal generation > but perout feature is faulty with half-cooked support > due to some missing configuration. Remove perout > support from the driver and reject perout requests with > "not supported" error code. > > Fixes: c1e0230eeaab2 ("net: ti: icss-iep: Add IEP driver") > Signed-off-by: Meghana Malladi <m-malladi@ti.com> > --- > > This patch is a bug fix to disable/remove a faulty feature, which will be > enabled separately as a feature addition to net-next, as suggested by > Jakub Kicinski and Jacob Keller: > https://lore.kernel.org/all/20250220172410.025b96d6@kernel.org/ > > drivers/net/ethernet/ti/icssg/icss_iep.c | 21 +-------------------- > 1 file changed, 1 insertion(+), 20 deletions(-) > > diff --git a/drivers/net/ethernet/ti/icssg/icss_iep.c b/drivers/net/ethernet/ti/icssg/icss_iep.c > index 768578c0d958..d59c1744840a 100644 > --- a/drivers/net/ethernet/ti/icssg/icss_iep.c > +++ b/drivers/net/ethernet/ti/icssg/icss_iep.c > @@ -474,26 +474,7 @@ static int icss_iep_perout_enable_hw(struct icss_iep *iep, > static int icss_iep_perout_enable(struct icss_iep *iep, > struct ptp_perout_request *req, int on) > { > - int ret = 0; > - > - mutex_lock(&iep->ptp_clk_mutex); > - > - if (iep->pps_enabled) { > - ret = -EBUSY; > - goto exit; > - } > - > - if (iep->perout_enabled == !!on) > - goto exit; > - > - ret = icss_iep_perout_enable_hw(iep, req, on); > - if (!ret) > - iep->perout_enabled = !!on; > - > -exit: > - mutex_unlock(&iep->ptp_clk_mutex); > - > - return ret; > + return -EOPNOTSUPP; > } > > static void icss_iep_cap_cmp_work(struct work_struct *work) > > base-commit: 29b036be1b0bfcfc958380d5931325997fddf08a LGTM. It maybe cleaner to remove PTP_CLK_REQ_PEROUT in icss_iep_ptp_enable as well, but if the idea is to bring the feature back, then it should be good enough. Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Thu, 27 Feb 2025 14:54:41 +0530 you wrote: > IEP driver supports both perout and pps signal generation > but perout feature is faulty with half-cooked support > due to some missing configuration. Remove perout > support from the driver and reject perout requests with > "not supported" error code. > > Fixes: c1e0230eeaab2 ("net: ti: icss-iep: Add IEP driver") > Signed-off-by: Meghana Malladi <m-malladi@ti.com> > > [...] Here is the summary with links: - [net] net: ti: icss-iep: Reject perout generation request https://git.kernel.org/netdev/net/c/54e1b4becf5e You are awesome, thank you!
diff --git a/drivers/net/ethernet/ti/icssg/icss_iep.c b/drivers/net/ethernet/ti/icssg/icss_iep.c index 768578c0d958..d59c1744840a 100644 --- a/drivers/net/ethernet/ti/icssg/icss_iep.c +++ b/drivers/net/ethernet/ti/icssg/icss_iep.c @@ -474,26 +474,7 @@ static int icss_iep_perout_enable_hw(struct icss_iep *iep, static int icss_iep_perout_enable(struct icss_iep *iep, struct ptp_perout_request *req, int on) { - int ret = 0; - - mutex_lock(&iep->ptp_clk_mutex); - - if (iep->pps_enabled) { - ret = -EBUSY; - goto exit; - } - - if (iep->perout_enabled == !!on) - goto exit; - - ret = icss_iep_perout_enable_hw(iep, req, on); - if (!ret) - iep->perout_enabled = !!on; - -exit: - mutex_unlock(&iep->ptp_clk_mutex); - - return ret; + return -EOPNOTSUPP; } static void icss_iep_cap_cmp_work(struct work_struct *work)
IEP driver supports both perout and pps signal generation but perout feature is faulty with half-cooked support due to some missing configuration. Remove perout support from the driver and reject perout requests with "not supported" error code. Fixes: c1e0230eeaab2 ("net: ti: icss-iep: Add IEP driver") Signed-off-by: Meghana Malladi <m-malladi@ti.com> --- This patch is a bug fix to disable/remove a faulty feature, which will be enabled separately as a feature addition to net-next, as suggested by Jakub Kicinski and Jacob Keller: https://lore.kernel.org/all/20250220172410.025b96d6@kernel.org/ drivers/net/ethernet/ti/icssg/icss_iep.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) base-commit: 29b036be1b0bfcfc958380d5931325997fddf08a