| Message ID | 20250228100020.3944-8-Frank.Sae@motor-comm.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net:yt6801: Add Motorcomm yt6801 PCIe driver | expand |
On Fri, Feb 28, 2025 at 06:00:13PM +0800, Frank Sae wrote: > YT6801 NIC Integrated a PHY that is YT8531S, but it used GMII interface. > Add a case of PHY_INTERFACE_MODE_INTERNAL to support YT6801. > > Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com> > --- > drivers/net/phy/motorcomm.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c > index 0e91f5d1a..371acafd5 100644 > --- a/drivers/net/phy/motorcomm.c > +++ b/drivers/net/phy/motorcomm.c > @@ -896,6 +896,12 @@ static int ytphy_rgmii_clk_delay_config(struct phy_device *phydev) > val |= FIELD_PREP(YT8521_RC1R_RX_DELAY_MASK, rx_reg) | > FIELD_PREP(YT8521_RC1R_GE_TX_DELAY_MASK, tx_reg); > break; > + case PHY_INTERFACE_MODE_INTERNAL: > + if (phydev->drv->phy_id != PHY_ID_YT8531S) > + return -EOPNOTSUPP; > + > + phydev_info(phydev, "Integrated YT8531S phy of YT6801.\n"); Why should this be printed every time the PHY is configured?
diff --git a/drivers/net/phy/motorcomm.c b/drivers/net/phy/motorcomm.c index 0e91f5d1a..371acafd5 100644 --- a/drivers/net/phy/motorcomm.c +++ b/drivers/net/phy/motorcomm.c @@ -896,6 +896,12 @@ static int ytphy_rgmii_clk_delay_config(struct phy_device *phydev) val |= FIELD_PREP(YT8521_RC1R_RX_DELAY_MASK, rx_reg) | FIELD_PREP(YT8521_RC1R_GE_TX_DELAY_MASK, tx_reg); break; + case PHY_INTERFACE_MODE_INTERNAL: + if (phydev->drv->phy_id != PHY_ID_YT8531S) + return -EOPNOTSUPP; + + phydev_info(phydev, "Integrated YT8531S phy of YT6801.\n"); + return 0; default: /* do not support other modes */ return -EOPNOTSUPP; }
YT6801 NIC Integrated a PHY that is YT8531S, but it used GMII interface. Add a case of PHY_INTERFACE_MODE_INTERNAL to support YT6801. Signed-off-by: Frank Sae <Frank.Sae@motor-comm.com> --- drivers/net/phy/motorcomm.c | 6 ++++++ 1 file changed, 6 insertions(+)