| Message ID | 20250313134146.27087-9-kabel@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | Fixes for mv88e6xxx (mainly 6320 family) | expand |
On Thu, Mar 13, 2025 at 02:41:41PM +0100, Marek Behún wrote: > Commit 9e5baf9b3636 ("net: dsa: mv88e6xxx: add RMU disable op") forgot > to add the .rmu_disable() method for the 6320 family. Fix it. Please add a justification for stable. The rules say: It must either fix a real bug that bothers people or just add a device ID. How does this bother people? Please look through all the patches in this set and split them between net and net-next. They do not all meet this requirement. Andrew --- pw-bot: cr
diff --git a/drivers/net/dsa/mv88e6xxx/chip.c b/drivers/net/dsa/mv88e6xxx/chip.c index 734aee3500c8..e67c24d960cf 100644 --- a/drivers/net/dsa/mv88e6xxx/chip.c +++ b/drivers/net/dsa/mv88e6xxx/chip.c @@ -5164,6 +5164,7 @@ static const struct mv88e6xxx_ops mv88e6320_ops = { .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6352_g1_rmu_disable, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .gpio_ops = &mv88e6352_gpio_ops, @@ -5213,6 +5214,7 @@ static const struct mv88e6xxx_ops mv88e6321_ops = { .hardware_reset_pre = mv88e6xxx_g2_eeprom_wait, .hardware_reset_post = mv88e6xxx_g2_eeprom_wait, .reset = mv88e6352_g1_reset, + .rmu_disable = mv88e6352_g1_rmu_disable, .vtu_getnext = mv88e6352_g1_vtu_getnext, .vtu_loadpurge = mv88e6352_g1_vtu_loadpurge, .gpio_ops = &mv88e6352_gpio_ops,
Commit 9e5baf9b3636 ("net: dsa: mv88e6xxx: add RMU disable op") forgot to add the .rmu_disable() method for the 6320 family. Fix it. Fixes: 9e5baf9b3636 ("net: dsa: mv88e6xxx: add RMU disable op") Signed-off-by: Marek Behún <kabel@kernel.org> --- drivers/net/dsa/mv88e6xxx/chip.c | 2 ++ 1 file changed, 2 insertions(+)