From patchwork Tue Mar 18 23:31:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuniyuki Iwashima X-Patchwork-Id: 14021738 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp-fw-6002.amazon.com (smtp-fw-6002.amazon.com [52.95.49.90]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 21CF11F7076 for ; Tue, 18 Mar 2025 23:34:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=52.95.49.90 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742340897; cv=none; b=WsEJSuTp50IhIi45nmCmr7UCmjFkngfRX1nNL2L7gWQwAJ67qZzGR67Xfm6BZ5jvcuLrLts+cpHxASzbch6mcLUCXSFPHcxkzYXLQT6T3HrvfkEVwS4tXW6mdypCqfQZDF7HIchpel63Xc6gHp6RzdYAiBDUs+0o3XtBlOCpI5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742340897; c=relaxed/simple; bh=Rid7cLLB3tLlup+VYdRfGQ+vEUhD98T2Bk9MEslMFh4=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=SPHmF1HI249alfNXT5aOpE4/5N6gkggBQlIIIoCmgONlY1H7vbEp/8VlvMKzGOGCC+kFTOBi3++WnHqHQEb0drF4V76via6Hh52+dUKkm29QwZW85Rai0xCgp+9GZWT/Yord3lScbOzoMD8Kn29dXEdRQnzAGnPD7ZX4+eVjxY4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com; spf=pass smtp.mailfrom=amazon.co.jp; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b=vgv4aFmV; arc=none smtp.client-ip=52.95.49.90 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amazon.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=amazon.co.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="vgv4aFmV" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1742340896; x=1773876896; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=trSspWxDMxD+GsX7d9lbyC5sGqeOld+2ndIYdMFdr3M=; b=vgv4aFmVQGTM+mXn9LF8knwVnM9cZdvQNjkYxe/7x/L+hNnuF9yRevxA E1/gXvBaW1FPmTB4HT3NTEINsra1bWUQZWYbJvwOBjaoKGsIkw2sU0LSf i5rO5vEoBotPtOZxsG/0sj3H1J4rE55Lw4Ju03r9eAjAEDkUlKCcI96Uu M=; X-IronPort-AV: E=Sophos;i="6.14,258,1736812800"; d="scan'208";a="481547199" Received: from iad12-co-svc-p1-lb1-vlan3.amazon.com (HELO smtpout.prod.us-west-2.prod.farcaster.email.amazon.dev) ([10.43.8.6]) by smtp-border-fw-6002.iad6.amazon.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Mar 2025 23:34:53 +0000 Received: from EX19MTAUWC001.ant.amazon.com [10.0.38.20:34008] by smtpin.naws.us-west-2.prod.farcaster.email.amazon.dev [10.0.22.127:2525] with esmtp (Farcaster) id f2716520-2d20-4867-b36c-ea32e53f8cf4; Tue, 18 Mar 2025 23:34:52 +0000 (UTC) X-Farcaster-Flow-ID: f2716520-2d20-4867-b36c-ea32e53f8cf4 Received: from EX19D004ANA001.ant.amazon.com (10.37.240.138) by EX19MTAUWC001.ant.amazon.com (10.250.64.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Tue, 18 Mar 2025 23:34:52 +0000 Received: from 6c7e67bfbae3.amazon.com (10.135.212.115) by EX19D004ANA001.ant.amazon.com (10.37.240.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA) id 15.2.1544.14; Tue, 18 Mar 2025 23:34:49 +0000 From: Kuniyuki Iwashima To: David Ahern , "David S. Miller" , Eric Dumazet , Jakub Kicinski , "Paolo Abeni" CC: Simon Horman , Kuniyuki Iwashima , Kuniyuki Iwashima , Subject: [PATCH v1 net-next 5/7] nexthop: Remove redundant group len check in nexthop_create_group(). Date: Tue, 18 Mar 2025 16:31:48 -0700 Message-ID: <20250318233240.53946-6-kuniyu@amazon.com> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250318233240.53946-1-kuniyu@amazon.com> References: <20250318233240.53946-1-kuniyu@amazon.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: EX19D037UWB003.ant.amazon.com (10.13.138.115) To EX19D004ANA001.ant.amazon.com (10.37.240.138) X-Patchwork-Delegate: kuba@kernel.org The number of NHA_GROUP entries is guaranteed to be non-zero in nh_check_attr_group(). Let's remove the redundant check in nexthop_create_group(). Signed-off-by: Kuniyuki Iwashima --- net/ipv4/nexthop.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c index 09f5f31f34a0..409f13d64ed4 100644 --- a/net/ipv4/nexthop.c +++ b/net/ipv4/nexthop.c @@ -2692,9 +2692,6 @@ static struct nexthop *nexthop_create_group(struct net *net, int err; int i; - if (WARN_ON(!num_nh)) - return ERR_PTR(-EINVAL); - nh = nexthop_alloc(); if (!nh) return ERR_PTR(-ENOMEM);