| Message ID | 20250324125222.82057-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | a8b4ea7857ff870d0ba266561210832833869415 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | dt-bindings: net: qcom,ipa: Correct indentation and style in DTS example | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Mon, 24 Mar 2025 13:52:22 +0100, Krzysztof Kozlowski wrote: > DTS example in the bindings should be indented with 2- or 4-spaces and > aligned with opening '- |', so correct any differences like 3-spaces or > mixtures 2- and 4-spaces in one binding. > > No functional changes here, but saves some comments during reviews of > new patches built on existing code. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/net/qcom,ipa.yaml | 124 +++++++++--------- > 1 file changed, 62 insertions(+), 62 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
On 3/24/25 7:52 AM, Krzysztof Kozlowski wrote: > DTS example in the bindings should be indented with 2- or 4-spaces and > aligned with opening '- |', so correct any differences like 3-spaces or > mixtures 2- and 4-spaces in one binding. > > No functional changes here, but saves some comments during reviews of > new patches built on existing code. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Looks identical with the exception of the white space change. Thanks Krzysztof. Reviewed-by: Alex Elder <elder@riscstar.com> > --- > .../devicetree/bindings/net/qcom,ipa.yaml | 124 +++++++++--------- > 1 file changed, 62 insertions(+), 62 deletions(-) > > diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > index 1a46d80a66e8..b4a79912d473 100644 > --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml > +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml > @@ -210,70 +210,70 @@ additionalProperties: false > > examples: > - | > - #include <dt-bindings/interrupt-controller/arm-gic.h> > - #include <dt-bindings/clock/qcom,rpmh.h> > - #include <dt-bindings/interconnect/qcom,sdm845.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/qcom,rpmh.h> > + #include <dt-bindings/interconnect/qcom,sdm845.h> > > - smp2p-mpss { > - compatible = "qcom,smp2p"; > - interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>; > - mboxes = <&apss_shared 6>; > - qcom,smem = <94>, <432>; > - qcom,local-pid = <0>; > - qcom,remote-pid = <5>; > + smp2p-mpss { > + compatible = "qcom,smp2p"; > + interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>; > + mboxes = <&apss_shared 6>; > + qcom,smem = <94>, <432>; > + qcom,local-pid = <0>; > + qcom,remote-pid = <5>; > > - ipa_smp2p_out: ipa-ap-to-modem { > - qcom,entry-name = "ipa"; > - #qcom,smem-state-cells = <1>; > - }; > - > - ipa_smp2p_in: ipa-modem-to-ap { > - qcom,entry-name = "ipa"; > - interrupt-controller; > - #interrupt-cells = <2>; > - }; > + ipa_smp2p_out: ipa-ap-to-modem { > + qcom,entry-name = "ipa"; > + #qcom,smem-state-cells = <1>; > }; > > - ipa@1e40000 { > - compatible = "qcom,sc7180-ipa"; > - > - qcom,gsi-loader = "self"; > - memory-region = <&ipa_fw_mem>; > - firmware-name = "qcom/sc7180-trogdor/modem/modem.mbn"; > - > - iommus = <&apps_smmu 0x440 0x0>, > - <&apps_smmu 0x442 0x0>; > - reg = <0x1e40000 0x7000>, > - <0x1e47000 0x2000>, > - <0x1e04000 0x2c000>; > - reg-names = "ipa-reg", > - "ipa-shared", > - "gsi"; > - > - interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>, > - <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>, > - <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > - <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; > - interrupt-names = "ipa", > - "gsi", > - "ipa-clock-query", > - "ipa-setup-ready"; > - > - clocks = <&rpmhcc RPMH_IPA_CLK>; > - clock-names = "core"; > - > - interconnects = > - <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>, > - <&aggre2_noc MASTER_IPA 0 &system_noc SLAVE_IMEM 0>, > - <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>; > - interconnect-names = "memory", > - "imem", > - "config"; > - > - qcom,qmp = <&aoss_qmp>; > - > - qcom,smem-states = <&ipa_smp2p_out 0>, > - <&ipa_smp2p_out 1>; > - qcom,smem-state-names = "ipa-clock-enabled-valid", > - "ipa-clock-enabled"; > + ipa_smp2p_in: ipa-modem-to-ap { > + qcom,entry-name = "ipa"; > + interrupt-controller; > + #interrupt-cells = <2>; > }; > + }; > + > + ipa@1e40000 { > + compatible = "qcom,sc7180-ipa"; > + > + qcom,gsi-loader = "self"; > + memory-region = <&ipa_fw_mem>; > + firmware-name = "qcom/sc7180-trogdor/modem/modem.mbn"; > + > + iommus = <&apps_smmu 0x440 0x0>, > + <&apps_smmu 0x442 0x0>; > + reg = <0x1e40000 0x7000>, > + <0x1e47000 0x2000>, > + <0x1e04000 0x2c000>; > + reg-names = "ipa-reg", > + "ipa-shared", > + "gsi"; > + > + interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>, > + <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>, > + <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "ipa", > + "gsi", > + "ipa-clock-query", > + "ipa-setup-ready"; > + > + clocks = <&rpmhcc RPMH_IPA_CLK>; > + clock-names = "core"; > + > + interconnects = > + <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>, > + <&aggre2_noc MASTER_IPA 0 &system_noc SLAVE_IMEM 0>, > + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>; > + interconnect-names = "memory", > + "imem", > + "config"; > + > + qcom,qmp = <&aoss_qmp>; > + > + qcom,smem-states = <&ipa_smp2p_out 0>, > + <&ipa_smp2p_out 1>; > + qcom,smem-state-names = "ipa-clock-enabled-valid", > + "ipa-clock-enabled"; > + };
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 24 Mar 2025 13:52:22 +0100 you wrote: > DTS example in the bindings should be indented with 2- or 4-spaces and > aligned with opening '- |', so correct any differences like 3-spaces or > mixtures 2- and 4-spaces in one binding. > > No functional changes here, but saves some comments during reviews of > new patches built on existing code. > > [...] Here is the summary with links: - dt-bindings: net: qcom,ipa: Correct indentation and style in DTS example https://git.kernel.org/netdev/net-next/c/a8b4ea7857ff You are awesome, thank you!
diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml index 1a46d80a66e8..b4a79912d473 100644 --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml @@ -210,70 +210,70 @@ additionalProperties: false examples: - | - #include <dt-bindings/interrupt-controller/arm-gic.h> - #include <dt-bindings/clock/qcom,rpmh.h> - #include <dt-bindings/interconnect/qcom,sdm845.h> + #include <dt-bindings/interrupt-controller/arm-gic.h> + #include <dt-bindings/clock/qcom,rpmh.h> + #include <dt-bindings/interconnect/qcom,sdm845.h> - smp2p-mpss { - compatible = "qcom,smp2p"; - interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>; - mboxes = <&apss_shared 6>; - qcom,smem = <94>, <432>; - qcom,local-pid = <0>; - qcom,remote-pid = <5>; + smp2p-mpss { + compatible = "qcom,smp2p"; + interrupts = <GIC_SPI 576 IRQ_TYPE_EDGE_RISING>; + mboxes = <&apss_shared 6>; + qcom,smem = <94>, <432>; + qcom,local-pid = <0>; + qcom,remote-pid = <5>; - ipa_smp2p_out: ipa-ap-to-modem { - qcom,entry-name = "ipa"; - #qcom,smem-state-cells = <1>; - }; - - ipa_smp2p_in: ipa-modem-to-ap { - qcom,entry-name = "ipa"; - interrupt-controller; - #interrupt-cells = <2>; - }; + ipa_smp2p_out: ipa-ap-to-modem { + qcom,entry-name = "ipa"; + #qcom,smem-state-cells = <1>; }; - ipa@1e40000 { - compatible = "qcom,sc7180-ipa"; - - qcom,gsi-loader = "self"; - memory-region = <&ipa_fw_mem>; - firmware-name = "qcom/sc7180-trogdor/modem/modem.mbn"; - - iommus = <&apps_smmu 0x440 0x0>, - <&apps_smmu 0x442 0x0>; - reg = <0x1e40000 0x7000>, - <0x1e47000 0x2000>, - <0x1e04000 0x2c000>; - reg-names = "ipa-reg", - "ipa-shared", - "gsi"; - - interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>, - <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>, - <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, - <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; - interrupt-names = "ipa", - "gsi", - "ipa-clock-query", - "ipa-setup-ready"; - - clocks = <&rpmhcc RPMH_IPA_CLK>; - clock-names = "core"; - - interconnects = - <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>, - <&aggre2_noc MASTER_IPA 0 &system_noc SLAVE_IMEM 0>, - <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>; - interconnect-names = "memory", - "imem", - "config"; - - qcom,qmp = <&aoss_qmp>; - - qcom,smem-states = <&ipa_smp2p_out 0>, - <&ipa_smp2p_out 1>; - qcom,smem-state-names = "ipa-clock-enabled-valid", - "ipa-clock-enabled"; + ipa_smp2p_in: ipa-modem-to-ap { + qcom,entry-name = "ipa"; + interrupt-controller; + #interrupt-cells = <2>; }; + }; + + ipa@1e40000 { + compatible = "qcom,sc7180-ipa"; + + qcom,gsi-loader = "self"; + memory-region = <&ipa_fw_mem>; + firmware-name = "qcom/sc7180-trogdor/modem/modem.mbn"; + + iommus = <&apps_smmu 0x440 0x0>, + <&apps_smmu 0x442 0x0>; + reg = <0x1e40000 0x7000>, + <0x1e47000 0x2000>, + <0x1e04000 0x2c000>; + reg-names = "ipa-reg", + "ipa-shared", + "gsi"; + + interrupts-extended = <&intc GIC_SPI 311 IRQ_TYPE_EDGE_RISING>, + <&intc GIC_SPI 432 IRQ_TYPE_LEVEL_HIGH>, + <&ipa_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, + <&ipa_smp2p_in 1 IRQ_TYPE_EDGE_RISING>; + interrupt-names = "ipa", + "gsi", + "ipa-clock-query", + "ipa-setup-ready"; + + clocks = <&rpmhcc RPMH_IPA_CLK>; + clock-names = "core"; + + interconnects = + <&aggre2_noc MASTER_IPA 0 &mc_virt SLAVE_EBI1 0>, + <&aggre2_noc MASTER_IPA 0 &system_noc SLAVE_IMEM 0>, + <&gem_noc MASTER_APPSS_PROC 0 &config_noc SLAVE_IPA_CFG 0>; + interconnect-names = "memory", + "imem", + "config"; + + qcom,qmp = <&aoss_qmp>; + + qcom,smem-states = <&ipa_smp2p_out 0>, + <&ipa_smp2p_out 1>; + qcom,smem-state-names = "ipa-clock-enabled-valid", + "ipa-clock-enabled"; + };
DTS example in the bindings should be indented with 2- or 4-spaces and aligned with opening '- |', so correct any differences like 3-spaces or mixtures 2- and 4-spaces in one binding. No functional changes here, but saves some comments during reviews of new patches built on existing code. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/net/qcom,ipa.yaml | 124 +++++++++--------- 1 file changed, 62 insertions(+), 62 deletions(-)