| Message ID | 20250329185704.676589-2-sdf@fomichev.me (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: hold instance lock during NETDEV_UP/REGISTER | expand |
Hi Stanislav, kernel test robot noticed the following build errors: [auto build test ERROR on net/main] url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/net-switch-to-netif_disable_lro-in-inetdev_init/20250330-030132 base: net/main patch link: https://lore.kernel.org/r/20250329185704.676589-2-sdf%40fomichev.me patch subject: [PATCH net v3 01/11] net: switch to netif_disable_lro in inetdev_init config: i386-buildonly-randconfig-002-20250330 (https://download.01.org/0day-ci/archive/20250330/202503300541.24wTsWWQ-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250330/202503300541.24wTsWWQ-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202503300541.24wTsWWQ-lkp@intel.com/ All error/warnings (new ones prefixed by >>): >> net/core/dev.c:1774:1: warning: data definition has no type or storage class 1774 | EXPORT_IPV6_MOD(netif_disable_lro); | ^~~~~~~~~~~~~~~ >> net/core/dev.c:1774:1: error: type defaults to 'int' in declaration of 'EXPORT_IPV6_MOD' [-Werror=implicit-int] >> net/core/dev.c:1774:1: warning: parameter names (without types) in function declaration cc1: some warnings being treated as errors vim +1774 net/core/dev.c 1756 1757 void netif_disable_lro(struct net_device *dev) 1758 { 1759 struct net_device *lower_dev; 1760 struct list_head *iter; 1761 1762 dev->wanted_features &= ~NETIF_F_LRO; 1763 netdev_update_features(dev); 1764 1765 if (unlikely(dev->features & NETIF_F_LRO)) 1766 netdev_WARN(dev, "failed to disable LRO!\n"); 1767 1768 netdev_for_each_lower_dev(dev, lower_dev, iter) { 1769 netdev_lock_ops(lower_dev); 1770 netif_disable_lro(lower_dev); 1771 netdev_unlock_ops(lower_dev); 1772 } 1773 } > 1774 EXPORT_IPV6_MOD(netif_disable_lro); 1775
Hi Stanislav, kernel test robot noticed the following build errors: [auto build test ERROR on net/main] url: https://github.com/intel-lab-lkp/linux/commits/Stanislav-Fomichev/net-switch-to-netif_disable_lro-in-inetdev_init/20250330-030132 base: net/main patch link: https://lore.kernel.org/r/20250329185704.676589-2-sdf%40fomichev.me patch subject: [PATCH net v3 01/11] net: switch to netif_disable_lro in inetdev_init config: s390-randconfig-002-20250330 (https://download.01.org/0day-ci/archive/20250330/202503300552.i2jDOcpl-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250330/202503300552.i2jDOcpl-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202503300552.i2jDOcpl-lkp@intel.com/ All errors (new ones prefixed by >>): >> net/core/dev.c:1774:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Werror,-Wimplicit-int] EXPORT_IPV6_MOD(netif_disable_lro); ^ int >> net/core/dev.c:1774:17: error: a parameter list without types is only allowed in a function definition EXPORT_IPV6_MOD(netif_disable_lro); ^ 2 errors generated. vim +/int +1774 net/core/dev.c 1756 1757 void netif_disable_lro(struct net_device *dev) 1758 { 1759 struct net_device *lower_dev; 1760 struct list_head *iter; 1761 1762 dev->wanted_features &= ~NETIF_F_LRO; 1763 netdev_update_features(dev); 1764 1765 if (unlikely(dev->features & NETIF_F_LRO)) 1766 netdev_WARN(dev, "failed to disable LRO!\n"); 1767 1768 netdev_for_each_lower_dev(dev, lower_dev, iter) { 1769 netdev_lock_ops(lower_dev); 1770 netif_disable_lro(lower_dev); 1771 netdev_unlock_ops(lower_dev); 1772 } 1773 } > 1774 EXPORT_IPV6_MOD(netif_disable_lro); 1775
diff --git a/net/core/dev.c b/net/core/dev.c index be17e0660144..711a946d4bfb 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1771,6 +1771,7 @@ void netif_disable_lro(struct net_device *dev) netdev_unlock_ops(lower_dev); } } +EXPORT_IPV6_MOD(netif_disable_lro); /** * dev_disable_gro_hw - disable HW Generic Receive Offload on a device diff --git a/net/ipv4/devinet.c b/net/ipv4/devinet.c index 754f60fb6e25..77e5705ac799 100644 --- a/net/ipv4/devinet.c +++ b/net/ipv4/devinet.c @@ -281,7 +281,7 @@ static struct in_device *inetdev_init(struct net_device *dev) if (!in_dev->arp_parms) goto out_kfree; if (IPV4_DEVCONF(in_dev->cnf, FORWARDING)) - dev_disable_lro(dev); + netif_disable_lro(dev); /* Reference in_dev->dev */ netdev_hold(dev, &in_dev->dev_tracker, GFP_KERNEL); /* Account for reference dev->ip_ptr (below) */