| Message ID | 20250401012939.2116915-1-kuba@kernel.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] netlink: specs: fix schema of rt_addr | expand |
Reviewed-by: Yuyang Huang <yuyanghuang@google.com> On Tue, Apr 1, 2025 at 10:29 AM Jakub Kicinski <kuba@kernel.org> wrote: > > The spec is mis-formatted, schema validation says: > > Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']: > {'minimum': 0, 'type': 'integer'} > > On instance['operations']['list'][3]['dump']['request']['value']: > '58 - ifa-family' > > The ifa-family clearly wants to be part of an attribute list. > > Fixes: dfb0f7d9d979 ("doc/netlink: Add spec for rt addr messages") > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: donald.hunter@gmail.com > CC: yuyanghuang@google.com > CC: jacob.e.keller@intel.com > --- > Documentation/netlink/specs/rt_addr.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/netlink/specs/rt_addr.yaml b/Documentation/netlink/specs/rt_addr.yaml > index 5dd5469044c7..3bc9b6f9087e 100644 > --- a/Documentation/netlink/specs/rt_addr.yaml > +++ b/Documentation/netlink/specs/rt_addr.yaml > @@ -187,6 +187,7 @@ protonum: 0 > dump: > request: > value: 58 > + attributes: > - ifa-family > reply: > value: 58 > -- > 2.49.0 >
Jakub Kicinski <kuba@kernel.org> writes: > The spec is mis-formatted, schema validation says: > > Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']: > {'minimum': 0, 'type': 'integer'} > > On instance['operations']['list'][3]['dump']['request']['value']: > '58 - ifa-family' > > The ifa-family clearly wants to be part of an attribute list. > > Fixes: dfb0f7d9d979 ("doc/netlink: Add spec for rt addr messages") The fixes tag looks wrong. I think it should be: Fixes: 4f280376e531 ("selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support") I wonder if the op name should be changed from getmaddrs to getmaddr, removing the plural to be consistent with do/dump conventions, or to getmulticast to be consistent with RTM_GETMULTICAST. > Signed-off-by: Jakub Kicinski <kuba@kernel.org> > --- > CC: donald.hunter@gmail.com > CC: yuyanghuang@google.com > CC: jacob.e.keller@intel.com > --- > Documentation/netlink/specs/rt_addr.yaml | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/netlink/specs/rt_addr.yaml b/Documentation/netlink/specs/rt_addr.yaml > index 5dd5469044c7..3bc9b6f9087e 100644 > --- a/Documentation/netlink/specs/rt_addr.yaml > +++ b/Documentation/netlink/specs/rt_addr.yaml > @@ -187,6 +187,7 @@ protonum: 0 > dump: > request: > value: 58 > + attributes: > - ifa-family > reply: > value: 58
On Tue, 01 Apr 2025 09:28:10 +0100 Donald Hunter wrote: > Fixes: 4f280376e531 ("selftests/net: Add selftest for IPv4 RTM_GETMULTICAST support") My bad! > I wonder if the op name should be changed from getmaddrs to getmaddr, > removing the plural to be consistent with do/dump conventions, or to > getmulticast to be consistent with RTM_GETMULTICAST. Well spotted! I have that change queued for net-next, but you're right, we better send it as a fix, before too many people depend on it.
diff --git a/Documentation/netlink/specs/rt_addr.yaml b/Documentation/netlink/specs/rt_addr.yaml index 5dd5469044c7..3bc9b6f9087e 100644 --- a/Documentation/netlink/specs/rt_addr.yaml +++ b/Documentation/netlink/specs/rt_addr.yaml @@ -187,6 +187,7 @@ protonum: 0 dump: request: value: 58 + attributes: - ifa-family reply: value: 58
The spec is mis-formatted, schema validation says: Failed validating 'type' in schema['properties']['operations']['properties']['list']['items']['properties']['dump']['properties']['request']['properties']['value']: {'minimum': 0, 'type': 'integer'} On instance['operations']['list'][3]['dump']['request']['value']: '58 - ifa-family' The ifa-family clearly wants to be part of an attribute list. Fixes: dfb0f7d9d979 ("doc/netlink: Add spec for rt addr messages") Signed-off-by: Jakub Kicinski <kuba@kernel.org> --- CC: donald.hunter@gmail.com CC: yuyanghuang@google.com CC: jacob.e.keller@intel.com --- Documentation/netlink/specs/rt_addr.yaml | 1 + 1 file changed, 1 insertion(+)