| Message ID | 20250402133905.895421-7-shaojijie@huawei.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | There are some bugfix for hibmcge driver | expand |
On Wed, Apr 02, 2025 at 09:39:04PM +0800, Jijie Shao wrote: > In normal cases, the driver must ensure that the value > of rx pause mac addr is the same as the MAC address of > the network port. This ensures that the driver can > receive pause frames whose destination address is > the MAC address of the network port. > > Currently, the rx pause addr does not restored after reset. > > The index of the MAC address of the host is always 0. > Therefore, this patch sets rx pause addr to > the MAC address with index 0. > > Fixes: 3f5a61f6d504 ("net: hibmcge: Add reset supported in this module") > Signed-off-by: Jijie Shao <shaojijie@huawei.com> Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/hisilicon/hibmcge/hbg_err.c b/drivers/net/ethernet/hisilicon/hibmcge/hbg_err.c index 4e8cb66f601c..a0bcfb5a713d 100644 --- a/drivers/net/ethernet/hisilicon/hibmcge/hbg_err.c +++ b/drivers/net/ethernet/hisilicon/hibmcge/hbg_err.c @@ -26,12 +26,15 @@ static void hbg_restore_mac_table(struct hbg_priv *priv) static void hbg_restore_user_def_settings(struct hbg_priv *priv) { + /* The index of host mac is always 0. */ + u64 rx_pause_addr = ether_addr_to_u64(priv->filter.mac_table[0].addr); struct ethtool_pauseparam *pause_param = &priv->user_def.pause_param; hbg_restore_mac_table(priv); hbg_hw_set_mtu(priv, priv->netdev->mtu); hbg_hw_set_pause_enable(priv, pause_param->tx_pause, pause_param->rx_pause); + hbg_hw_set_rx_pause_mac_addr(priv, rx_pause_addr); } int hbg_rebuild(struct hbg_priv *priv)
In normal cases, the driver must ensure that the value of rx pause mac addr is the same as the MAC address of the network port. This ensures that the driver can receive pause frames whose destination address is the MAC address of the network port. Currently, the rx pause addr does not restored after reset. The index of the MAC address of the host is always 0. Therefore, this patch sets rx pause addr to the MAC address with index 0. Fixes: 3f5a61f6d504 ("net: hibmcge: Add reset supported in this module") Signed-off-by: Jijie Shao <shaojijie@huawei.com> --- drivers/net/ethernet/hisilicon/hibmcge/hbg_err.c | 3 +++ 1 file changed, 3 insertions(+)