From patchwork Thu Apr 3 10:19:34 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Abramov X-Patchwork-Id: 14036952 X-Patchwork-Delegate: kuba@kernel.org Received: from ksmg01.maxima.ru (ksmg01.maxima.ru [81.200.124.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECBD424A055; Thu, 3 Apr 2025 10:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=81.200.124.38 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743675602; cv=none; b=n2RToUnKIgfTDWgANE9nYGSYETRN2MPq2d5Kqbo8ZNejhEVc8pJy3BvuBg3hFZNba6Qwwh3C4GJdejIzHqf7K5VGFyxei363ZBdj0zAgXXGYHKdYI1PstXzf4QE80U6Zh7YOx0ETxvvQ7ikcDoe/+oSTf/P4cbLS1unpWupOiYk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743675602; c=relaxed/simple; bh=RPXyeFu3hLGAwb60oZcpOdtZIfP7WSaxI6mPPTvu0Z8=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VL1TSj6MZMsqTumVV6/lQnc7iTL4X8ToUlNfqsKIQ1Xv4d87eVQ4+BpLpsgewlz1NlMl9S5222bjt5zGdiom13JnKn1eD/oyURcUWVFr0qRUAHnVddoi9HZmAVTBbMM6bWg1dM7bPEWZYwMPnIb5EHXnsFShRe+9tmbDrmpZQII= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mt-integration.ru; spf=pass smtp.mailfrom=mt-integration.ru; dkim=pass (2048-bit key) header.d=mt-integration.ru header.i=@mt-integration.ru header.b=aXPUFQvb; arc=none smtp.client-ip=81.200.124.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=mt-integration.ru Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mt-integration.ru Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mt-integration.ru header.i=@mt-integration.ru header.b="aXPUFQvb" Received: from ksmg01.maxima.ru (localhost [127.0.0.1]) by ksmg01.maxima.ru (Postfix) with ESMTP id CD814C001E; Thu, 3 Apr 2025 13:19:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 ksmg01.maxima.ru CD814C001E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mt-integration.ru; s=sl; t=1743675598; bh=N6N25JmQAuicJL+q493OEXAu4U2lX1+1kyO9BOM/ZaM=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=aXPUFQvbjl6QYqhi99iXBe5b1I2eLTBn8L1X24bXuzGRGzY2LJUw3PH9dh7dJDPde +1IWuSxf5N1sfjfITVh7a7i/94GnePJc809+JEVz5LtGqw+/VklOR1mcR3geCJaX2y gMOOBpRLPT1BPaNGu7YkTcygPpF3UD5Mr/T2tLcCoSFHR57aJDcG/5CinpGU1SVNqC 39lHdftaXOPLrA5wxVvC80z85slXGgybPTOWCknqVl4gAAXHkRxVBHsPMpxXNn4/m+ RPY+LZFFp7eF3GTxYBd5rcrshhycxXw3+93pwZyL6jxrnmej47cNYf38emkqrraSUA qz+nnqRPDCvog== Received: from ksmg01.maxima.ru (mail.maxima.ru [81.200.124.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.maxima.ru", Issuer "GlobalSign GCC R3 DV TLS CA 2020" (verified OK)) by ksmg01.maxima.ru (Postfix) with ESMTPS; Thu, 3 Apr 2025 13:19:58 +0300 (MSK) Received: from db126-1-abramov-14-d-mosos.mti-lab.com (172.25.20.118) by mmail-p-exch01.mt.ru (81.200.124.61) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Thu, 3 Apr 2025 13:19:57 +0300 From: Ivan Abramov To: Alexander Aring CC: Ivan Abramov , Miquel Raynal , Stefan Schmidt , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , , , , Subject: [PATCH net v3 3/3] ieee802154: Remove WARN_ON() in cfg802154_pernet_exit() Date: Thu, 3 Apr 2025 13:19:34 +0300 Message-ID: <20250403101935.991385-4-i.abramov@mt-integration.ru> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20250403101935.991385-1-i.abramov@mt-integration.ru> References: <20250403101935.991385-1-i.abramov@mt-integration.ru> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ClientProxiedBy: mmail-p-exch02.mt.ru (81.200.124.62) To mmail-p-exch01.mt.ru (81.200.124.61) X-KSMG-AntiPhishing: NotDetected X-KSMG-AntiSpam-Auth: dmarc=none header.from=mt-integration.ru;spf=none smtp.mailfrom=mt-integration.ru;dkim=none X-KSMG-AntiSpam-Envelope-From: i.abramov@mt-integration.ru X-KSMG-AntiSpam-Info: LuaCore: 54 0.3.54 464169e973265e881193cca5ab7aa5055e5b7016, {rep_avail}, {Tracking_from_domain_doesnt_match_to}, ksmg01.maxima.ru:7.1.1;mt-integration.ru:7.1.1;127.0.0.199:7.1.2;81.200.124.61:7.1.2;d41d8cd98f00b204e9800998ecf8427e.com:7.1.1, FromAlignment: s, ApMailHostAddress: 81.200.124.61 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiSpam-Lua-Profiles: 192331 [Apr 03 2025] X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Version: 6.1.1.11 X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.1.8310, bases: 2025/04/03 07:23:00 #27851719 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: NotDetected X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 7 X-Patchwork-Delegate: kuba@kernel.org There's no need to call WARN_ON() in cfg802154_pernet_exit(), since every point of failure in cfg802154_switch_netns() is covered with WARN_ON(), so remove it. Found by Linux Verification Center (linuxtesting.org) with Syzkaller. Fixes: 66e5c2672cd1 ("ieee802154: add netns support") Reviewed-by: Miquel Raynal Signed-off-by: Ivan Abramov --- v3: Add Reviewed-by tag. v2: Make sure to commit against latest netdev/net. net/ieee802154/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ieee802154/core.c b/net/ieee802154/core.c index 987c633e2c54..c0b8712018a1 100644 --- a/net/ieee802154/core.c +++ b/net/ieee802154/core.c @@ -358,7 +358,7 @@ static void __net_exit cfg802154_pernet_exit(struct net *net) rtnl_lock(); list_for_each_entry(rdev, &cfg802154_rdev_list, list) { if (net_eq(wpan_phy_net(&rdev->wpan_phy), net)) - WARN_ON(cfg802154_switch_netns(rdev, &init_net)); + cfg802154_switch_netns(rdev, &init_net); } rtnl_unlock(); }