| Message ID | 20250409092446.64202-1-maimon.sagi@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1] ptp: ocp: add irig and dcf NULL-check in __handle_signal functions | expand |
On 09/04/2025 10:24, Sagi Maimon wrote: > In __handle_signal_outputs and __handle_signal_inputs add > irig and dcf NULL-check > > Signed-off-by: Sagi Maimon <maimon.sagi@gmail.com> Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
On 4/9/25 11:24 AM, Sagi Maimon wrote: > In __handle_signal_outputs and __handle_signal_inputs add > irig and dcf NULL-check You need to expand a little the commit message. Is the NULL ptr dereference actually possible? How? or this is just defensive programming? If there is a real NULL ptr dereference this need a suitable Fixes tag. And you should specify the target tree in the subj prefix. You can retain the collected ack when resubmitting. Thanks, Paolo
HI Paolo Most of your notes are clear and will be fixed. can you explain more regarding: "And you should specify the target tree in the subj prefix" Did you mean: net, net-next, Linux-nex? On Thu, Apr 10, 2025 at 1:23 PM Paolo Abeni <pabeni@redhat.com> wrote: > > On 4/9/25 11:24 AM, Sagi Maimon wrote: > > In __handle_signal_outputs and __handle_signal_inputs add > > irig and dcf NULL-check > > You need to expand a little the commit message. Is the NULL ptr > dereference actually possible? How? or this is just defensive programming? > > If there is a real NULL ptr dereference this need a suitable Fixes tag. > > And you should specify the target tree in the subj prefix. > > You can retain the collected ack when resubmitting. > > Thanks, > > Paolo >
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 7945c6be1f7c..4e4a6f465b01 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -2434,15 +2434,19 @@ ptp_ocp_dcf_in(struct ptp_ocp *bp, bool enable) static void __handle_signal_outputs(struct ptp_ocp *bp, u32 val) { - ptp_ocp_irig_out(bp, val & 0x00100010); - ptp_ocp_dcf_out(bp, val & 0x00200020); + if (bp->irig_out) + ptp_ocp_irig_out(bp, val & 0x00100010); + if (bp->dcf_out) + ptp_ocp_dcf_out(bp, val & 0x00200020); } static void __handle_signal_inputs(struct ptp_ocp *bp, u32 val) { - ptp_ocp_irig_in(bp, val & 0x00100010); - ptp_ocp_dcf_in(bp, val & 0x00200020); + if (bp->irig_out) + ptp_ocp_irig_in(bp, val & 0x00100010); + if (bp->dcf_out) + ptp_ocp_dcf_in(bp, val & 0x00200020); } static u32
In __handle_signal_outputs and __handle_signal_inputs add irig and dcf NULL-check Signed-off-by: Sagi Maimon <maimon.sagi@gmail.com> --- drivers/ptp/ptp_ocp.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-)