From patchwork Thu Apr 10 07:17:48 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Peter Seiderer X-Patchwork-Id: 14045999 X-Patchwork-Delegate: kuba@kernel.org Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65D7D20E316; Thu, 10 Apr 2025 07:18:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=212.227.17.20 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; cv=none; b=QcV/N7145EylGrgFKmDQD5L49fcDOVEL43OzLoTwkQkBngoAkildw0//uYQ5AabuzuyQ6SiC57/N41CyGH6brIE7IUT+k/i767zd9tQtiNg4WVjQhx5P9hRPdSrZkRt45Gp/U/xIVZcDZClf6H6C8OWdHl5tk3yo8BeIY/UI/oY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744269499; c=relaxed/simple; bh=QHFMGT7825aLf9CCNjJ13QgmK6RJ8FFKkBaM863mKyk=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qM4dbjNUtawyJtpjeX4tuxPLTop1Vm+Luwpcfqg7+8HjdN4jBh7F50FZX5AP/XGF2uPLmf0NfNvGzLSGy3Xodsy11k+wmazK9aNSkAUHvoCm9JChdkcGy8wYmzPvECbJ1boCO72pz+3anTB5Gj+YE6EH2b6jmuTESsbwZc5fJAc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net; spf=pass smtp.mailfrom=gmx.net; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b=SPsPSUQe; arc=none smtp.client-ip=212.227.17.20 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gmx.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmx.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmx.net header.i=ps.report@gmx.net header.b="SPsPSUQe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1744269484; x=1744874284; i=ps.report@gmx.net; bh=QHFMGT7825aLf9CCNjJ13QgmK6RJ8FFKkBaM863mKyk=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:Message-ID:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:cc: content-transfer-encoding:content-type:date:from:message-id: mime-version:reply-to:subject:to; b=SPsPSUQe7J69mO4qvsV5jGcZQeDcF0LCydFPE+NWw+1zszmy2rClVkMwaCEa+J3c s+pAL/JpwfpDEKzukMpUOkfZqBP3sxQl5VKnaiIM3ZY1U4VFd75WYZq/PHVU8eFyJ yw5+GsAwqfHEV5BKIalfk9lFntA9cQE84C+M9/Z1NI6/WWBtUBGaUC8yJ0NqIhDU0 tPLsKdNU3Jsb8lqJb4Roh8zRSovpNRRBmqH64Rhp0C4Fls2QBZL3W6/2ThcPNyaXu MNDpFC4W6auvvxDOTtiI5lRptaBB9pBULVwQci6Ggr7cExrnHRhrSoSjB9hNgDCkH bgWMwyYVtKp99+KrjQ== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from localhost.fritz.box ([82.135.81.74]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxDkm-1t9q6e1XQG-00xQNG; Thu, 10 Apr 2025 09:18:04 +0200 From: Peter Seiderer To: netdev@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Peter Seiderer Subject: [PATCH net-next v1 11/11] net: pktgen: fix code style (WARNING: Prefer strscpy over strcpy) Date: Thu, 10 Apr 2025 09:17:48 +0200 Message-ID: <20250410071749.30505-12-ps.report@gmx.net> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250410071749.30505-1-ps.report@gmx.net> References: <20250410071749.30505-1-ps.report@gmx.net> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Provags-ID: V03:K1:ndIQyKXD72T7ZtrQT18eDtqgwfyCjLsquOJhoZkuZs0nCfo/ToB nlebgxxesCvHrvUA3kw0WhY2oDDyHjI/tzl350KAzOMbxp8XSz8qb7yn06bdWg5qYhdHFuT qoPDo0EpLYJH23i36rCZAH8pNyzcc7MRmVA2q8rcV99g2RQRBUo3FEI7O2L245QYAqHqfif TR4uqTuNQO6sWjNesmsQA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:VqfOQYDHX/4=;dkZZXsXi1ra7wYudIvAVEDmeSas XTAmOHYf8quG/HY0kyRphV74+djWeDPE2FCFRZa9qmfZu+09UOmSMvOnKhlygbsK4/L8pVt2L M8StHIaVdCmRUYiZgZCEZ/78XoQ+87MdmBvrs2Q9GUfru6czt1Q3lJGfFQ/kYxoxVHUNq2fCg qp2USA1C6d+yt0bR6YxsyWOBWueCABwt4+s/p3XSbHYtRkYQIdI7ZPX9tz2CinrS1PLNuhLCP u9d1RWYACgTzIG+hU7tkOrSzvZyfJwsU2aYvhOqdiNSs0qsJftdI3PVDvnENhSrl+3zpWW7lK jmZXHoQsYOxRLGB2pdAIVNd54hajK0zkLp4TrGYhIr6oOwO+CSoWGZ1VkcABCWB3n4E9ev2tw jLHa7rHu7Y65i0TtzRQJfckbkVH9iklBtSXK3AoMvOpHUoc2W9SVP4QgHl/acaZEajeidbZcp wvZ9kmwRceXOzbvEkRcghZfHEDgnD6xIJitryDAfgnuP4ZHwSytg7LutVEzDFmQfH706zCvFU 5hxENTo1Ul0GMV8Kna4eNVDzshgaYy4HqAdFqFgM4zK9VRlJNUCfoNB6uSknZ/QL2pKgpcMyc ABg1K6Qh2sGctdjzTgmSH19s6wUvcLoTClo+guaKPPm9TYfRgNqgGlNpCJD6elmWgqcoOrr1M BjBaXsBUHidRFOVD1kOT39aKMrvuVaiBy/i120zIggIHJ1VlujjELptt0giK0O1lbZ0KHD5v3 WkcBSzZPp/knsmsut2daBuIpDLDGFP8Kj768044QiPTJ8L2gcQmWUR7dQ/63xf110CjZvHHd6 NFnLzExyrnAf8qbgBc8Oln8Ofitls8q+RN9kkctVuL+q9//7TqklmjPzPEfRBpqxv53pHNqIo WMpdyh1u+LjLakUm2PZFsS81nrKnCTXUz1IIGTexUp3vi04/OB6D/CGhoXZlCNs/u5ikz+Pvs uCaiObywkeX1lTGo/I21FkobbDcKplSiy2VmaIfKNUVevUDGwvhWWHUaC3ljL8zPZIht1eZEK HO9/dC+yVqZuB14vkIyHmXcoKF4sJdzbg8VIxLJy7bDLSNj5z/WBe6HIb9ThZF4CjubSCfZmQ FABmAaq1tWhdVb4KQ4D41z4/P+A1tHk/7JQytLsiS8Ed1JX6LVWdjQ9ky6X6btS2HyYDmQEqB Ia7L3SVseAde6kHGTSy0Ecazui0fRglnJUnI3shGR5jvy2+xpJvZ4hrZWHZir7+GWcth33wTh UeT0c9Dbk1Pio/vcVzA5lnP2yfIDkkXobBiKLbnMD3X/A/er18LPP57DGuOAlGNdgYuYt8VMp GlFWOhoe/vMMvOEbnxshfMQzoVKSYXXt+iUge/8R+lOGamRZwaYQ+kYIpuH5YZrhjCJHrhfXx fI3Vd/ke/s5zI1mvQtuxdtRMEb9daDkalpKv8MzC8xLBJ4lj2CQOQ/o21dh44LIgwVaufA0vU J1TXYhSqQvj+bBhU2dLt1WMKaavwOVTrBAosUVIqxelslbovCmp49S/Zb+9EhsPjWgOPy9w== X-Patchwork-Delegate: kuba@kernel.org Fix checkpatch code style warnings: WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #1422: FILE: net/core/pktgen.c:1422: + strcpy(pkt_dev->dst_min, buf); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #1443: FILE: net/core/pktgen.c:1443: + strcpy(pkt_dev->dst_max, buf); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #1553: FILE: net/core/pktgen.c:1553: + strcpy(pkt_dev->src_min, buf); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #1574: FILE: net/core/pktgen.c:1574: + strcpy(pkt_dev->src_max, buf); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #3227: FILE: net/core/pktgen.c:3227: + strcpy(pkt_dev->result, "Starting"); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #3231: FILE: net/core/pktgen.c:3231: + strcpy(pkt_dev->result, "Error starting"); WARNING: Prefer strscpy over strcpy - see: https://github.com/KSPP/linux/issues/88 #3845: FILE: net/core/pktgen.c:3845: + strcpy(pkt_dev->odevname, ifname); Signed-off-by: Peter Seiderer --- net/core/pktgen.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/net/core/pktgen.c b/net/core/pktgen.c index 0d18fd932ed9..3f76cae9cf57 100644 --- a/net/core/pktgen.c +++ b/net/core/pktgen.c @@ -1419,7 +1419,7 @@ static ssize_t pktgen_if_write(struct file *file, buf[len] = 0; if (strcmp(buf, pkt_dev->dst_min) != 0) { memset(pkt_dev->dst_min, 0, sizeof(pkt_dev->dst_min)); - strcpy(pkt_dev->dst_min, buf); + strscpy(pkt_dev->dst_min, buf); pkt_dev->daddr_min = in_aton(pkt_dev->dst_min); pkt_dev->cur_daddr = pkt_dev->daddr_min; } @@ -1440,7 +1440,7 @@ static ssize_t pktgen_if_write(struct file *file, buf[len] = 0; if (strcmp(buf, pkt_dev->dst_max) != 0) { memset(pkt_dev->dst_max, 0, sizeof(pkt_dev->dst_max)); - strcpy(pkt_dev->dst_max, buf); + strscpy(pkt_dev->dst_max, buf); pkt_dev->daddr_max = in_aton(pkt_dev->dst_max); pkt_dev->cur_daddr = pkt_dev->daddr_max; } @@ -1550,7 +1550,7 @@ static ssize_t pktgen_if_write(struct file *file, buf[len] = 0; if (strcmp(buf, pkt_dev->src_min) != 0) { memset(pkt_dev->src_min, 0, sizeof(pkt_dev->src_min)); - strcpy(pkt_dev->src_min, buf); + strscpy(pkt_dev->src_min, buf); pkt_dev->saddr_min = in_aton(pkt_dev->src_min); pkt_dev->cur_saddr = pkt_dev->saddr_min; } @@ -1571,7 +1571,7 @@ static ssize_t pktgen_if_write(struct file *file, buf[len] = 0; if (strcmp(buf, pkt_dev->src_max) != 0) { memset(pkt_dev->src_max, 0, sizeof(pkt_dev->src_max)); - strcpy(pkt_dev->src_max, buf); + strscpy(pkt_dev->src_max, buf); pkt_dev->saddr_max = in_aton(pkt_dev->src_max); pkt_dev->cur_saddr = pkt_dev->saddr_max; } @@ -3224,11 +3224,11 @@ static void pktgen_run(struct pktgen_thread *t) set_pkt_overhead(pkt_dev); - strcpy(pkt_dev->result, "Starting"); + strscpy(pkt_dev->result, "Starting"); pkt_dev->running = 1; /* Cranke yeself! */ started++; } else - strcpy(pkt_dev->result, "Error starting"); + strscpy(pkt_dev->result, "Error starting"); } rcu_read_unlock(); if (started) @@ -3842,7 +3842,7 @@ static int pktgen_add_device(struct pktgen_thread *t, const char *ifname) if (!pkt_dev) return -ENOMEM; - strcpy(pkt_dev->odevname, ifname); + strscpy(pkt_dev->odevname, ifname); pkt_dev->flows = vzalloc_node(array_size(MAX_CFLOWS, sizeof(struct flow_state)), node);