| Message ID | 20250414-octeon-wq-v1-1-23700e4bd208@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | bbfc077d457272bcea4f14b3a28247ade99b196d |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] octeon_ep_vf: Remove octep_vf_wq | expand |
* Simon Horman (horms@kernel.org) wrote: > commit cb7dd712189f ("octeon_ep_vf: Add driver framework and device > initialization") added octep_vf_wq but it has never been used. Remove it. > > Reported-by: Dr. David Alan Gilbert <linux@treblig.org> > Closes: https://lore.kernel.org/netdev/Z70bEoTKyeBau52q@gallifrey/ > Signed-off-by: Simon Horman <horms@kernel.org> Thanks, Reviewed-by: Dr. David Alan Gilbert <linux@treblig.org> > --- > drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 2 -- > drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h | 2 -- > 2 files changed, 4 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c > index 18c922dd5fc6..5841e30dff2a 100644 > --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c > +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c > @@ -18,8 +18,6 @@ > #include "octep_vf_config.h" > #include "octep_vf_main.h" > > -struct workqueue_struct *octep_vf_wq; > - > /* Supported Devices */ > static const struct pci_device_id octep_vf_pci_id_tbl[] = { > {PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, OCTEP_PCI_DEVICE_ID_CN93_VF)}, > diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h > index 1a352f41f823..b9f13506f462 100644 > --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h > +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h > @@ -320,8 +320,6 @@ static inline u16 OCTEP_VF_MINOR_REV(struct octep_vf_device *oct) > #define octep_vf_read_csr64(octep_vf_dev, reg_off) \ > readq((octep_vf_dev)->mmio.hw_addr + (reg_off)) > > -extern struct workqueue_struct *octep_vf_wq; > - > int octep_vf_device_setup(struct octep_vf_device *oct); > int octep_vf_setup_iqs(struct octep_vf_device *oct); > void octep_vf_free_iqs(struct octep_vf_device *oct); >
Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski <kuba@kernel.org>: On Mon, 14 Apr 2025 17:44:48 +0100 you wrote: > commit cb7dd712189f ("octeon_ep_vf: Add driver framework and device > initialization") added octep_vf_wq but it has never been used. Remove it. > > Reported-by: Dr. David Alan Gilbert <linux@treblig.org> > Closes: https://lore.kernel.org/netdev/Z70bEoTKyeBau52q@gallifrey/ > Signed-off-by: Simon Horman <horms@kernel.org> > > [...] Here is the summary with links: - [net-next] octeon_ep_vf: Remove octep_vf_wq https://git.kernel.org/netdev/net-next/c/bbfc077d4572 You are awesome, thank you!
diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c index 18c922dd5fc6..5841e30dff2a 100644 --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c @@ -18,8 +18,6 @@ #include "octep_vf_config.h" #include "octep_vf_main.h" -struct workqueue_struct *octep_vf_wq; - /* Supported Devices */ static const struct pci_device_id octep_vf_pci_id_tbl[] = { {PCI_DEVICE(PCI_VENDOR_ID_CAVIUM, OCTEP_PCI_DEVICE_ID_CN93_VF)}, diff --git a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h index 1a352f41f823..b9f13506f462 100644 --- a/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h +++ b/drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h @@ -320,8 +320,6 @@ static inline u16 OCTEP_VF_MINOR_REV(struct octep_vf_device *oct) #define octep_vf_read_csr64(octep_vf_dev, reg_off) \ readq((octep_vf_dev)->mmio.hw_addr + (reg_off)) -extern struct workqueue_struct *octep_vf_wq; - int octep_vf_device_setup(struct octep_vf_device *oct); int octep_vf_setup_iqs(struct octep_vf_device *oct); void octep_vf_free_iqs(struct octep_vf_device *oct);
commit cb7dd712189f ("octeon_ep_vf: Add driver framework and device initialization") added octep_vf_wq but it has never been used. Remove it. Reported-by: Dr. David Alan Gilbert <linux@treblig.org> Closes: https://lore.kernel.org/netdev/Z70bEoTKyeBau52q@gallifrey/ Signed-off-by: Simon Horman <horms@kernel.org> --- drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.c | 2 -- drivers/net/ethernet/marvell/octeon_ep_vf/octep_vf_main.h | 2 -- 2 files changed, 4 deletions(-)