| Message ID | 20250414143220.121657-1-maimon.sagi@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [v1] ptp: ocp: fix start time alignment in ptp_ocp_signal_set | expand |
On 14/04/2025 15:32, Sagi Maimon wrote: > In ptp_ocp_signal_set, the start time for periodic signals is not > aligned to the next period boundary. The current code rounds up the > start time and divides by the period but fails to multiply back by > the period, causing misaligned signal starts. Fix this by multiplying > the rounded-up value by the period to ensure the start time is the > closest next period. > > Fixes: 4bd46bb037f8e ("ptp: ocp: Use DIV64_U64_ROUND_UP for rounding.") > Signed-off-by: Sagi Maimon <maimon.sagi@gmail.com> > --- > drivers/ptp/ptp_ocp.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c > index 7945c6be1f7c..e5b55b78a6d7 100644 > --- a/drivers/ptp/ptp_ocp.c > +++ b/drivers/ptp/ptp_ocp.c > @@ -2067,6 +2067,7 @@ ptp_ocp_signal_set(struct ptp_ocp *bp, int gen, struct ptp_ocp_signal *s) > if (!s->start) { > /* roundup() does not work on 32-bit systems */ > s->start = DIV64_U64_ROUND_UP(start_ns, s->period); > + s->start = (s->start) * (s->period); No parenthesis are needed here. it's better to put this line as s->start *= s->period; > s->start = ktime_add(s->start, s->phase); > } > pw-bot:cr
diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c index 7945c6be1f7c..e5b55b78a6d7 100644 --- a/drivers/ptp/ptp_ocp.c +++ b/drivers/ptp/ptp_ocp.c @@ -2067,6 +2067,7 @@ ptp_ocp_signal_set(struct ptp_ocp *bp, int gen, struct ptp_ocp_signal *s) if (!s->start) { /* roundup() does not work on 32-bit systems */ s->start = DIV64_U64_ROUND_UP(start_ns, s->period); + s->start = (s->start) * (s->period); s->start = ktime_add(s->start, s->phase); }
In ptp_ocp_signal_set, the start time for periodic signals is not aligned to the next period boundary. The current code rounds up the start time and divides by the period but fails to multiply back by the period, causing misaligned signal starts. Fix this by multiplying the rounded-up value by the period to ensure the start time is the closest next period. Fixes: 4bd46bb037f8e ("ptp: ocp: Use DIV64_U64_ROUND_UP for rounding.") Signed-off-by: Sagi Maimon <maimon.sagi@gmail.com> --- drivers/ptp/ptp_ocp.c | 1 + 1 file changed, 1 insertion(+)