diff mbox series

netdev: Clean up errors in netdevice.h

Message ID 2de2b453.859.18ad4b697c8.Coremail.chenguohua@jari.cn (mailing list archive)
State Rejected
Headers show
Series netdev: Clean up errors in netdevice.h | expand

Checks

Context Check Description
netdev/series_format warning Single patches do not need cover letters; Target tree name not specified in the subject
netdev/tree_selection success Guessed tree name to be net-next, async
netdev/fixes_present success Fixes tag not required for -next series
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 5487 this patch: 5487
netdev/cc_maintainers warning 1 maintainers not CCed: davem@davemloft.net
netdev/build_clang success Errors and warnings before: 1660 this patch: 1660
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/deprecated_api success None detected
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 5867 this patch: 5867
netdev/checkpatch warning WARNING: From:/Signed-off-by: email name mismatch: 'From: "chenguohua@jari.cn" <chenguohua@jari.cn>' != 'Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>'
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

chenguohua@jari.cn Sept. 27, 2023, 3:37 a.m. UTC
Fix the following errors reported by checkpatch:

ERROR: that open brace { should be on the previous line
ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>
---
 include/linux/netdevice.h | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Simon Horman Oct. 1, 2023, 6:03 p.m. UTC | #1
On Wed, Sep 27, 2023 at 11:37:30AM +0800, chenguohua@jari.cn wrote:
> Fix the following errors reported by checkpatch:
> 
> ERROR: that open brace { should be on the previous line
> ERROR: spaces required around that '=' (ctx:VxV)
> 
> Signed-off-by: GuoHua Cheng <chenguohua@jari.cn>

Hi GuoHua Cheng,

I'm sorry, but checkpatch cleanup patches for Networking code
are not accepted.

pw-bot: rejected
diff mbox series

Patch

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index 7e520c14eb8c..551372f42be6 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -2306,7 +2306,7 @@  struct net_device {
 
 	struct list_head	link_watch_list;
 
-	enum { NETREG_UNINITIALIZED=0,
+	enum { NETREG_UNINITIALIZED = 0,
 	       NETREG_REGISTERED,	/* completed register_netdevice */
 	       NETREG_UNREGISTERING,	/* called unregister_netdevice */
 	       NETREG_UNREGISTERED,	/* completed unregister todo */
@@ -2501,8 +2501,7 @@  struct netdev_queue *netdev_get_tx_queue(const struct net_device *dev,
 }
 
 static inline struct netdev_queue *skb_get_tx_queue(const struct net_device *dev,
-						    const struct sk_buff *skb)
-{
+						    const struct sk_buff *skb) {
 	return netdev_get_tx_queue(dev, skb_get_queue_mapping(skb));
 }