diff mbox series

[v6,02/26] tcp: authopt: Remove more unused noops

Message ID 2e9007e2f536ef2b8e3dfdaa1dd44dcc6bfc125f.1658815925.git.cdleonard@gmail.com (mailing list archive)
State Deferred
Delegated to: Netdev Maintainers
Headers show
Series tcp: Initial support for RFC5925 auth option | expand

Checks

Context Check Description
netdev/tree_selection success Guessed tree name to be net-next, async
netdev/fixes_present success Fixes tag not required for -next series
netdev/subject_prefix warning Target tree name not specified in the subject
netdev/cover_letter success Series has a cover letter
netdev/patch_count fail Series longer than 15 patches (and no cover letter)
netdev/header_inline success No static functions without inline keyword in header files
netdev/build_32bit success Errors and warnings before: 22 this patch: 22
netdev/cc_maintainers warning 1 maintainers not CCed: pabeni@redhat.com
netdev/build_clang success Errors and warnings before: 7 this patch: 7
netdev/module_param success Was 0 now: 0
netdev/verify_signedoff success Signed-off-by tag matches author and committer
netdev/check_selftest success No net selftest shell script
netdev/verify_fixes success No Fixes tag
netdev/build_allmodconfig_warn success Errors and warnings before: 22 this patch: 22
netdev/checkpatch warning WARNING: Missing commit description - Add an appropriate one
netdev/kdoc success Errors and warnings before: 0 this patch: 0
netdev/source_inline success Was 0 now: 0

Commit Message

Leonard Crestez July 26, 2022, 6:15 a.m. UTC 
Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
---
 include/net/tcp_authopt.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

David Ahern July 27, 2022, 1:17 a.m. UTC | #1 
On 7/26/22 12:15 AM, Leonard Crestez wrote:
> Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
> ---
>  include/net/tcp_authopt.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/include/net/tcp_authopt.h b/include/net/tcp_authopt.h
> index adf325c260d5..bc2cff82830d 100644
> --- a/include/net/tcp_authopt.h
> +++ b/include/net/tcp_authopt.h
> @@ -60,14 +60,10 @@ DECLARE_STATIC_KEY_FALSE(tcp_authopt_needed_key);
>  void tcp_authopt_clear(struct sock *sk);
>  int tcp_set_authopt(struct sock *sk, sockptr_t optval, unsigned int optlen);
>  int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key);
>  int tcp_set_authopt_key(struct sock *sk, sockptr_t optval, unsigned int optlen);
>  #else
> -static inline int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key)
> -{
> -	return -ENOPROTOOPT;
> -}
>  static inline void tcp_authopt_clear(struct sock *sk)
>  {
>  }
>  #endif
>  
added in the previous patch, so this one should be folded into patch 1
Leonard Crestez July 27, 2022, 8:49 a.m. UTC | #2 
On 7/27/22 04:17, David Ahern wrote:
> On 7/26/22 12:15 AM, Leonard Crestez wrote:
>> Signed-off-by: Leonard Crestez <cdleonard@gmail.com>
>> ---
>>   include/net/tcp_authopt.h | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/include/net/tcp_authopt.h b/include/net/tcp_authopt.h
>> index adf325c260d5..bc2cff82830d 100644
>> --- a/include/net/tcp_authopt.h
>> +++ b/include/net/tcp_authopt.h
>> @@ -60,14 +60,10 @@ DECLARE_STATIC_KEY_FALSE(tcp_authopt_needed_key);
>>   void tcp_authopt_clear(struct sock *sk);
>>   int tcp_set_authopt(struct sock *sk, sockptr_t optval, unsigned int optlen);
>>   int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key);
>>   int tcp_set_authopt_key(struct sock *sk, sockptr_t optval, unsigned int optlen);
>>   #else
>> -static inline int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key)
>> -{
>> -	return -ENOPROTOOPT;
>> -}
>>   static inline void tcp_authopt_clear(struct sock *sk)
>>   {
>>   }
>>   #endif
>>   
> added in the previous patch, so this one should be folded into patch 1
Yes this was intended for squashing but missed somehow; sorry!

--
Regards,
Leonard
diff mbox series

Patch

diff --git a/include/net/tcp_authopt.h b/include/net/tcp_authopt.h
index adf325c260d5..bc2cff82830d 100644
--- a/include/net/tcp_authopt.h
+++ b/include/net/tcp_authopt.h
@@ -60,14 +60,10 @@  DECLARE_STATIC_KEY_FALSE(tcp_authopt_needed_key);
 void tcp_authopt_clear(struct sock *sk);
 int tcp_set_authopt(struct sock *sk, sockptr_t optval, unsigned int optlen);
 int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key);
 int tcp_set_authopt_key(struct sock *sk, sockptr_t optval, unsigned int optlen);
 #else
-static inline int tcp_get_authopt_val(struct sock *sk, struct tcp_authopt *key)
-{
-	return -ENOPROTOOPT;
-}
 static inline void tcp_authopt_clear(struct sock *sk)
 {
 }
 #endif