| Message ID | 3152336.aeNJFYEL58@eto.sf-tec.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [1/3] sunhme: remove unused tx_dump_ring() | expand |
On Thu, Feb 03, 2022 at 05:22:23PM +0100, Rolf Eike Beer wrote: > Fixes: 050bbb196392b9c178f82b1205a23dd2f915ee93 > Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de> > --- > drivers/net/ethernet/sun/sunhme.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c > index 22abfe58f728..43834339bb43 100644 > --- a/drivers/net/ethernet/sun/sunhme.c > +++ b/drivers/net/ethernet/sun/sunhme.c > @@ -2470,8 +2470,8 @@ static void hme_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info > { > struct happy_meal *hp = netdev_priv(dev); > > - strlcpy(info->driver, "sunhme", sizeof(info->driver)); > - strlcpy(info->version, "2.02", sizeof(info->version)); > + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); > + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); I would suggest you drop setting info->version. The kernel will fill it with the current kernel version, which is much more meaningful. Andrew
On Thu, 03 Feb 2022 17:22:23 +0100 Rolf Eike Beer wrote:
> Fixes: 050bbb196392b9c178f82b1205a23dd2f915ee93
This is not the correct format for a fixes tag, FWIW.
Am Donnerstag, 3. Februar 2022, 18:12:40 CET schrieb Andrew Lunn: > On Thu, Feb 03, 2022 at 05:22:23PM +0100, Rolf Eike Beer wrote: > > Fixes: 050bbb196392b9c178f82b1205a23dd2f915ee93 > > Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de> > > --- > > > > drivers/net/ethernet/sun/sunhme.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/ethernet/sun/sunhme.c > > b/drivers/net/ethernet/sun/sunhme.c index 22abfe58f728..43834339bb43 > > 100644 > > --- a/drivers/net/ethernet/sun/sunhme.c > > +++ b/drivers/net/ethernet/sun/sunhme.c > > @@ -2470,8 +2470,8 @@ static void hme_get_drvinfo(struct net_device *dev, > > struct ethtool_drvinfo *info> > > { > > > > struct happy_meal *hp = netdev_priv(dev); > > > > - strlcpy(info->driver, "sunhme", sizeof(info->driver)); > > - strlcpy(info->version, "2.02", sizeof(info->version)); > > + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); > > + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); > > I would suggest you drop setting info->version. The kernel will fill > it with the current kernel version, which is much more meaningful. Would it make sense to completely remove the version number from the driver then? Eike
> > > struct ethtool_drvinfo *info> > > > { > > > > > > struct happy_meal *hp = netdev_priv(dev); > > > > > > - strlcpy(info->driver, "sunhme", sizeof(info->driver)); > > > - strlcpy(info->version, "2.02", sizeof(info->version)); > > > + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); > > > + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); > > > > I would suggest you drop setting info->version. The kernel will fill > > it with the current kernel version, which is much more meaningful. > > Would it make sense to completely remove the version number from the driver > then? If it is not used anywhere else, yes, you can remove it. Andrew
Am Samstag, 5. Februar 2022, 15:48:41 CET schrieb Andrew Lunn: > > > > struct ethtool_drvinfo *info> > > > > > > > > { > > > > > > > > struct happy_meal *hp = netdev_priv(dev); > > > > > > > > - strlcpy(info->driver, "sunhme", sizeof(info->driver)); > > > > - strlcpy(info->version, "2.02", sizeof(info->version)); > > > > + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); > > > > + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); > > > > > > I would suggest you drop setting info->version. The kernel will fill > > > it with the current kernel version, which is much more meaningful. > > > > Would it make sense to completely remove the version number from the > > driver > > then? > > If it is not used anywhere else, yes, you can remove it. Of course it prints the number on module load… but otherwise it does nothing with it.
> > If it is not used anywhere else, yes, you can remove it. > > Of course it prints the number on module load… but otherwise it does nothing > with it. You could remove that as well. The basic problem is, the version string does not identify the sources with enough accuracy. It says nothing about back ported fixes in stable kernels. It tells you nothing about vendor patches to the network core, etc. Andrew
diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c index 22abfe58f728..43834339bb43 100644 --- a/drivers/net/ethernet/sun/sunhme.c +++ b/drivers/net/ethernet/sun/sunhme.c @@ -2470,8 +2470,8 @@ static void hme_get_drvinfo(struct net_device *dev, struct ethtool_drvinfo *info { struct happy_meal *hp = netdev_priv(dev); - strlcpy(info->driver, "sunhme", sizeof(info->driver)); - strlcpy(info->version, "2.02", sizeof(info->version)); + strlcpy(info->driver, DRV_NAME, sizeof(info->driver)); + strlcpy(info->version, DRV_VERSION, sizeof(info->version)); if (hp->happy_flags & HFLAG_PCI) { struct pci_dev *pdev = hp->happy_dev; strlcpy(info->bus_info, pci_name(pdev), sizeof(info->bus_info));
Fixes: 050bbb196392b9c178f82b1205a23dd2f915ee93 Signed-off-by: Rolf Eike Beer <eike-kernel@sf-tec.de> --- drivers/net/ethernet/sun/sunhme.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)