| Message ID | 373ee2fc-e78f-48e6-826e-e8de464848b7@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6a26310273c323380da21eb23fcfd50e31140913 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [RESEND,net] Revert "net: r8169: Disable multicast filter for RTL8168H and RTL8107E" | expand |
Hello: This patch was applied to netdev/net.git (main) by David S. Miller <davem@davemloft.net>: On Tue, 21 Nov 2023 09:09:33 +0100 you wrote: > This reverts commit efa5f1311c4998e9e6317c52bc5ee93b3a0f36df. > > I couldn't reproduce the reported issue. What I did, based on a pcap > packet log provided by the reporter: > - Used same chip version (RTL8168h) > - Set MAC address to the one used on the reporters system > - Replayed the EAPOL unicast packet that, according to the reporter, > was filtered out by the mc filter. > The packet was properly received. > > [...] Here is the summary with links: - [RESEND,net] Revert "net: r8169: Disable multicast filter for RTL8168H and RTL8107E" https://git.kernel.org/netdev/net/c/6a26310273c3 You are awesome, thank you!
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c index b9bb1d2f0237..295366a85c63 100644 --- a/drivers/net/ethernet/realtek/r8169_main.c +++ b/drivers/net/ethernet/realtek/r8169_main.c @@ -2599,9 +2599,7 @@ static void rtl_set_rx_mode(struct net_device *dev) rx_mode &= ~AcceptMulticast; } else if (netdev_mc_count(dev) > MC_FILTER_LIMIT || dev->flags & IFF_ALLMULTI || - tp->mac_version == RTL_GIGA_MAC_VER_35 || - tp->mac_version == RTL_GIGA_MAC_VER_46 || - tp->mac_version == RTL_GIGA_MAC_VER_48) { + tp->mac_version == RTL_GIGA_MAC_VER_35) { /* accept all multicasts */ } else if (netdev_mc_empty(dev)) { rx_mode &= ~AcceptMulticast;
This reverts commit efa5f1311c4998e9e6317c52bc5ee93b3a0f36df. I couldn't reproduce the reported issue. What I did, based on a pcap packet log provided by the reporter: - Used same chip version (RTL8168h) - Set MAC address to the one used on the reporters system - Replayed the EAPOL unicast packet that, according to the reporter, was filtered out by the mc filter. The packet was properly received. Therefore the root cause of the reported issue seems to be somewhere else. Disabling mc filtering completely for the most common chip version is a quite big hammer. Therefore revert the change and wait for further analysis results from the reporter. Cc: stable@vger.kernel.org Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/ethernet/realtek/r8169_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)