| Message ID | 39b1a3684880e1d85ef76e34403886e8f1d22508.1623149635.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 762411542050dbe27c7c96f13c57f93da5d9b89a |
| Headers | show |
| Series | nvme: NVME_TCP_OFFLOAD should not default to m | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Not a local patch |
On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote: > The help text for the symbol controlling support for the NVM Express > over Fabrics TCP offload common layer suggests to not enable this > support when unsure. > > Hence drop the "default m", which actually means "default y" if > CONFIG_MODULES is not enabled. > > Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Err, where did this appear from? This code has not been accepted into the NVMe tree and is indeed not acceptable in this form.
Hi Christoph, On Tue, Jun 8, 2021 at 2:19 PM Christoph Hellwig <hch@lst.de> wrote: > On Tue, Jun 08, 2021 at 12:56:09PM +0200, Geert Uytterhoeven wrote: > > The help text for the symbol controlling support for the NVM Express > > over Fabrics TCP offload common layer suggests to not enable this > > support when unsure. > > > > Hence drop the "default m", which actually means "default y" if > > CONFIG_MODULES is not enabled. > > > > Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP") > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> > > Err, where did this appear from? This code has not been accepted into > the NVMe tree and is indeed not acceptable in this form. It was applied to net-next. Gr{oetje,eeting}s, Geert
Hi Dave, please drop the nvme-offload code from net-next. Code for drivers/nvme/ needs ACKs from us nvme maintainers and for something this significant also needs to go through the NVMe tree. And this code is not ready yet.
From: Christoph Hellwig <hch@lst.de> Date: Tue, 8 Jun 2021 15:43:03 +0200 > please drop the nvme-offload code from net-next. Code for drivers/nvme/ > needs ACKs from us nvme maintainers and for something this significant > also needs to go through the NVMe tree. And this code is not ready yet. Please send me a revert, and I will apply it, thank you. It's tricky because at least one driver uses the new interfaces. Thank you.
Hello: This patch was applied to netdev/net-next.git (refs/heads/master): On Tue, 8 Jun 2021 12:56:09 +0200 you wrote: > The help text for the symbol controlling support for the NVM Express > over Fabrics TCP offload common layer suggests to not enable this > support when unsure. > > Hence drop the "default m", which actually means "default y" if > CONFIG_MODULES is not enabled. > > [...] Here is the summary with links: - nvme: NVME_TCP_OFFLOAD should not default to m https://git.kernel.org/netdev/net-next/c/762411542050 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
On Tue, Jun 08, 2021 at 12:08:39PM -0700, David Miller wrote: > From: Christoph Hellwig <hch@lst.de> > Date: Tue, 8 Jun 2021 15:43:03 +0200 > > > please drop the nvme-offload code from net-next. Code for drivers/nvme/ > > needs ACKs from us nvme maintainers and for something this significant > > also needs to go through the NVMe tree. And this code is not ready yet. > > Please send me a revert, and I will apply it, thank you. > > It's tricky because at least one driver uses the new interfaces. Shouldn't whoever merged un-ACK'ed patches from a different subsystem get to own the tricky revert?
diff --git a/drivers/nvme/host/Kconfig b/drivers/nvme/host/Kconfig index 9c6f4d776daf14cf..f76cc4690bfc37bc 100644 --- a/drivers/nvme/host/Kconfig +++ b/drivers/nvme/host/Kconfig @@ -88,7 +88,6 @@ config NVME_TCP config NVME_TCP_OFFLOAD tristate "NVM Express over Fabrics TCP offload common layer" - default m depends on BLOCK depends on INET select NVME_CORE
The help text for the symbol controlling support for the NVM Express over Fabrics TCP offload common layer suggests to not enable this support when unsure. Hence drop the "default m", which actually means "default y" if CONFIG_MODULES is not enabled. Fixes: f0e8cb6106da2703 ("nvme-tcp-offload: Add nvme-tcp-offload - NVMeTCP HW offload ULP") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/nvme/host/Kconfig | 1 - 1 file changed, 1 deletion(-)