| Message ID | 40095112efd1b2214e4223109fd9f0c6d0158a2d.1680609318.git.geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Awaiting Upstream |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | can: CAN_BXCAN should depend on ARCH_STM32 | expand |
| Context | Check | Description |
|---|---|---|
| netdev/tree_selection | success | Series ignored based on subject |
On Tue, Apr 04, 2023 at 01:59:00PM +0200, Geert Uytterhoeven wrote: > The STMicroelectronics STM32 basic extended CAN Controller (bxCAN) is > only present on STM32 SoCs. Hence drop the "|| OF" part from its > dependency rule, to prevent asking the user about this driver when > configuring a kernel without STM32 SoC support. > > Fixes: f00647d8127be4d3 ("can: bxcan: add support for ST bxCAN controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Simon Horman <simon.horman@corigine.com>
On 04.04.2023 13:59:00, Geert Uytterhoeven wrote: > The STMicroelectronics STM32 basic extended CAN Controller (bxCAN) is > only present on STM32 SoCs. Hence drop the "|| OF" part from its > dependency rule, to prevent asking the user about this driver when > configuring a kernel without STM32 SoC support. > > Fixes: f00647d8127be4d3 ("can: bxcan: add support for ST bxCAN controller") > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Applied to linux-can-next. Thanks, Marc
diff --git a/drivers/net/can/Kconfig b/drivers/net/can/Kconfig index 3ceccafd701b2a31..b190007c01bec5f4 100644 --- a/drivers/net/can/Kconfig +++ b/drivers/net/can/Kconfig @@ -95,7 +95,7 @@ config CAN_AT91 config CAN_BXCAN tristate "STM32 Basic Extended CAN (bxCAN) devices" - depends on OF || ARCH_STM32 || COMPILE_TEST + depends on ARCH_STM32 || COMPILE_TEST depends on HAS_IOMEM select CAN_RX_OFFLOAD help
The STMicroelectronics STM32 basic extended CAN Controller (bxCAN) is only present on STM32 SoCs. Hence drop the "|| OF" part from its dependency rule, to prevent asking the user about this driver when configuring a kernel without STM32 SoC support. Fixes: f00647d8127be4d3 ("can: bxcan: add support for ST bxCAN controller") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- Until v3[1], BXCAN depended on "(ARCH_STM32 || COMPILE_TEST) && OF". v4[2] changed this from "&& OF" to "|| OF", for no apparent reason, and without mentioning this in the changelog. [1] https://lore.kernel.org/all/20220828133329.793324-5-dario.binacchi@amarulasolutions.com [2] https://lore.kernel.org/all/20220925175209.1528960-6-dario.binacchi@amarulasolutions.com --- drivers/net/can/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)