| Message ID | 45b0be04-2886-4eaa-a5a4-9e3a2e29b667@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | net: phy: add and use helper phy_advertise_eee_all | expand |
On Sat, Feb 03, 2024 at 12:20:12PM +0100, Heiner Kallweit wrote: > Per default phylib preserves the EEE advertising at the time of > phy probing. The EEE advertising can be changed from user space, > in addition this helper allows to set the EEE advertising to all > supported modes from drivers in kernel space. > > Suggested-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> > --- > drivers/net/phy/phy_device.c | 12 ++++++++++++ > include/linux/phy.h | 1 + > 2 files changed, 13 insertions(+) > > diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c > index dd778c7fd..df56c3ebf 100644 > --- a/drivers/net/phy/phy_device.c > +++ b/drivers/net/phy/phy_device.c > @@ -2769,6 +2769,18 @@ void phy_advertise_supported(struct phy_device *phydev) > } > EXPORT_SYMBOL(phy_advertise_supported); > > +/** > + * phy_advertise_eee_all - Advertise all supported EEE modes > + * @phydev: target phy_device struct > + * > + * Description: Called to advertise all supported EEE modes > + */ I would expand this description. Include the Per default phylib preserves the EEE advertising at the time of phy probing And extend with something like, which might be a subset of the supported EEE modes. Use this function when all supported EEE modes should be advertised. This does not trigger auto-negotiation, so must be called before phy_start()/phylink_start() which will start auto-negotiation. Andrew
diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index dd778c7fd..df56c3ebf 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -2769,6 +2769,18 @@ void phy_advertise_supported(struct phy_device *phydev) } EXPORT_SYMBOL(phy_advertise_supported); +/** + * phy_advertise_eee_all - Advertise all supported EEE modes + * @phydev: target phy_device struct + * + * Description: Called to advertise all supported EEE modes + */ +void phy_advertise_eee_all(struct phy_device *phydev) +{ + linkmode_copy(phydev->advertising_eee, phydev->supported_eee); +} +EXPORT_SYMBOL_GPL(phy_advertise_eee_all); + /** * phy_support_sym_pause - Enable support of symmetrical pause * @phydev: target phy_device struct diff --git a/include/linux/phy.h b/include/linux/phy.h index a66f07d3f..1343a4081 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -1960,6 +1960,7 @@ int phy_get_rate_matching(struct phy_device *phydev, void phy_set_max_speed(struct phy_device *phydev, u32 max_speed); void phy_remove_link_mode(struct phy_device *phydev, u32 link_mode); void phy_advertise_supported(struct phy_device *phydev); +void phy_advertise_eee_all(struct phy_device *phydev); void phy_support_sym_pause(struct phy_device *phydev); void phy_support_asym_pause(struct phy_device *phydev); void phy_set_sym_pause(struct phy_device *phydev, bool rx, bool tx,
Per default phylib preserves the EEE advertising at the time of phy probing. The EEE advertising can be changed from user space, in addition this helper allows to set the EEE advertising to all supported modes from drivers in kernel space. Suggested-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> --- drivers/net/phy/phy_device.c | 12 ++++++++++++ include/linux/phy.h | 1 + 2 files changed, 13 insertions(+)