| Message ID | 479a6614d1fc4285c02953bf1ca181fa56942fb6.1702990507.git.siyanteng@loongson.cn (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | stmmac: Add Loongson platform support | expand |
On Tue, Dec 19, 2023 at 10:28:19PM +0800, Yanteng Si wrote: > Some chips of Loongson GNET does not support coe, so disable them. > > Signed-off-by: Yanteng Si <siyanteng@loongson.cn> > Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn> > Signed-off-by: Yinggang Gu <guyinggang@loongson.cn> > --- > drivers/net/ethernet/stmicro/stmmac/hwif.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c > index 3724cf698de6..f211880925aa 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c > +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c > @@ -73,6 +73,11 @@ static int stmmac_dwmac1_quirks(struct stmmac_priv *priv) > mac->desc = &ndesc_ops; > } > > + if (priv->synopsys_id == DWLGMAC_CORE_1_00) { > + priv->plat->tx_coe = 0; > + priv->plat->rx_coe = STMMAC_RX_COE_NONE; > + } Couldn't this be done in dwmac-loongson.c? -Serge(y) > + > stmmac_dwmac_mode_quirk(priv); > return 0; > } > -- > 2.31.4 >
在 2023/12/21 10:36, Serge Semin 写道: > On Tue, Dec 19, 2023 at 10:28:19PM +0800, Yanteng Si wrote: >> Some chips of Loongson GNET does not support coe, so disable them. >> >> Signed-off-by: Yanteng Si <siyanteng@loongson.cn> >> Signed-off-by: Feiyang Chen <chenfeiyang@loongson.cn> >> Signed-off-by: Yinggang Gu <guyinggang@loongson.cn> >> --- >> drivers/net/ethernet/stmicro/stmmac/hwif.c | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c >> index 3724cf698de6..f211880925aa 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c >> @@ -73,6 +73,11 @@ static int stmmac_dwmac1_quirks(struct stmmac_priv *priv) >> mac->desc = &ndesc_ops; >> } >> >> + if (priv->synopsys_id == DWLGMAC_CORE_1_00) { >> + priv->plat->tx_coe = 0; >> + priv->plat->rx_coe = STMMAC_RX_COE_NONE; >> + } > Couldn't this be done in dwmac-loongson.c? Sorry for the late reply, I have been busy with patches 4 and 5. I think I can give you a definite answer: This is possible, just like the method you mentioned in patch 5, I only need to overwrite ld->dwlgmac_dma_ops.get_hw_feature. Thanks, Yanteng > > -Serge(y) > >> + >> stmmac_dwmac_mode_quirk(priv); >> return 0; >> } >> -- >> 2.31.4 >>
diff --git a/drivers/net/ethernet/stmicro/stmmac/hwif.c b/drivers/net/ethernet/stmicro/stmmac/hwif.c index 3724cf698de6..f211880925aa 100644 --- a/drivers/net/ethernet/stmicro/stmmac/hwif.c +++ b/drivers/net/ethernet/stmicro/stmmac/hwif.c @@ -73,6 +73,11 @@ static int stmmac_dwmac1_quirks(struct stmmac_priv *priv) mac->desc = &ndesc_ops; } + if (priv->synopsys_id == DWLGMAC_CORE_1_00) { + priv->plat->tx_coe = 0; + priv->plat->rx_coe = STMMAC_RX_COE_NONE; + } + stmmac_dwmac_mode_quirk(priv); return 0; }