| Message ID | 50706db7f675e40b3594d62011d9363dce32b92e.1674495822.git.gnault@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 90317bcdbd337b9e88f253650f6ab9dfe667be64 |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net-next] ipv6: Make ip6_route_output_flags_noref() static. | expand |
On 1/23/23 10:47 AM, Guillaume Nault wrote: > This function is only used in net/ipv6/route.c and has no reason to be > visible outside of it. > > Signed-off-by: Guillaume Nault <gnault@redhat.com> > --- > include/net/ip6_route.h | 4 ---- > net/ipv6/route.c | 8 ++++---- > 2 files changed, 4 insertions(+), 8 deletions(-) > Reviewed-by: David Ahern <dsahern@kernel.org>
Hello: This patch was applied to netdev/net-next.git (master) by Jakub Kicinski <kuba@kernel.org>: On Mon, 23 Jan 2023 18:47:09 +0100 you wrote: > This function is only used in net/ipv6/route.c and has no reason to be > visible outside of it. > > Signed-off-by: Guillaume Nault <gnault@redhat.com> > --- > include/net/ip6_route.h | 4 ---- > net/ipv6/route.c | 8 ++++---- > 2 files changed, 4 insertions(+), 8 deletions(-) Here is the summary with links: - [net-next] ipv6: Make ip6_route_output_flags_noref() static. https://git.kernel.org/netdev/net-next/c/90317bcdbd33 You are awesome, thank you!
diff --git a/include/net/ip6_route.h b/include/net/ip6_route.h index 035d61d50a98..81ee387a1fc4 100644 --- a/include/net/ip6_route.h +++ b/include/net/ip6_route.h @@ -84,10 +84,6 @@ struct dst_entry *ip6_route_input_lookup(struct net *net, struct flowi6 *fl6, const struct sk_buff *skb, int flags); -struct dst_entry *ip6_route_output_flags_noref(struct net *net, - const struct sock *sk, - struct flowi6 *fl6, int flags); - struct dst_entry *ip6_route_output_flags(struct net *net, const struct sock *sk, struct flowi6 *fl6, int flags); diff --git a/net/ipv6/route.c b/net/ipv6/route.c index 76889ceeead9..c180c2ef17c5 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2593,9 +2593,10 @@ INDIRECT_CALLABLE_SCOPE struct rt6_info *ip6_pol_route_output(struct net *net, return ip6_pol_route(net, table, fl6->flowi6_oif, fl6, skb, flags); } -struct dst_entry *ip6_route_output_flags_noref(struct net *net, - const struct sock *sk, - struct flowi6 *fl6, int flags) +static struct dst_entry *ip6_route_output_flags_noref(struct net *net, + const struct sock *sk, + struct flowi6 *fl6, + int flags) { bool any_src; @@ -2624,7 +2625,6 @@ struct dst_entry *ip6_route_output_flags_noref(struct net *net, return fib6_rule_lookup(net, fl6, NULL, flags, ip6_pol_route_output); } -EXPORT_SYMBOL_GPL(ip6_route_output_flags_noref); struct dst_entry *ip6_route_output_flags(struct net *net, const struct sock *sk,
This function is only used in net/ipv6/route.c and has no reason to be visible outside of it. Signed-off-by: Guillaume Nault <gnault@redhat.com> --- include/net/ip6_route.h | 4 ---- net/ipv6/route.c | 8 ++++---- 2 files changed, 4 insertions(+), 8 deletions(-)