| Message ID | 5a009b26cf5fb1ad1512d89c61b37e2fac702323.1725430322.git.jamie.bainbridge@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | e4af74a53b7aa865e7fcc104630ebb7a9129b71f |
| Delegated to: | Netdev Maintainers |
| Headers | show |
| Series | [net] selftests: net: enable bind tests | expand |
On Wed, Sep 4, 2024 at 8:12 AM Jamie Bainbridge <jamie.bainbridge@gmail.com> wrote: > > bind_wildcard is compiled but not run, bind_timewait is not compiled. > > These two tests complete in a very short time, use the test harness > properly, and seem reasonable to enable. > > The author of the tests confirmed via email that these were > intended to be run. > > Enable these two tests. > > Fixes: 13715acf8ab5 ("selftest: Add test for bind() conflicts.") > Fixes: 2c042e8e54ef ("tcp: Add selftest for bind() and TIME_WAIT.") > Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com> Reviewed-by: Eric Dumazet <edumazet@google.com>
From: Jamie Bainbridge <jamie.bainbridge@gmail.com> Date: Wed, 4 Sep 2024 16:12:26 +1000 > bind_wildcard is compiled but not run, bind_timewait is not compiled. > > These two tests complete in a very short time, use the test harness > properly, and seem reasonable to enable. > > The author of the tests confirmed via email that these were > intended to be run. > > Enable these two tests. > > Fixes: 13715acf8ab5 ("selftest: Add test for bind() conflicts.") > Fixes: 2c042e8e54ef ("tcp: Add selftest for bind() and TIME_WAIT.") > Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Thanks! > --- > tools/testing/selftests/net/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile > index 8eaffd7a641c5d6bb5c63e3015fdd9f32c114550..9d5aa817411b653ac130a1a581d933180a597ce5 100644 > --- a/tools/testing/selftests/net/Makefile > +++ b/tools/testing/selftests/net/Makefile > @@ -85,7 +85,8 @@ TEST_GEN_PROGS += so_incoming_cpu > TEST_PROGS += sctp_vrf.sh > TEST_GEN_FILES += sctp_hello > TEST_GEN_FILES += ip_local_port_range > -TEST_GEN_FILES += bind_wildcard > +TEST_GEN_PROGS += bind_wildcard > +TEST_GEN_PROGS += bind_timewait > TEST_PROGS += test_vxlan_mdb.sh > TEST_PROGS += test_bridge_neigh_suppress.sh > TEST_PROGS += test_vxlan_nolocalbypass.sh > -- > 2.39.2 >
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Wed, 4 Sep 2024 16:12:26 +1000 you wrote: > bind_wildcard is compiled but not run, bind_timewait is not compiled. > > These two tests complete in a very short time, use the test harness > properly, and seem reasonable to enable. > > The author of the tests confirmed via email that these were > intended to be run. > > [...] Here is the summary with links: - [net] selftests: net: enable bind tests https://git.kernel.org/netdev/net/c/e4af74a53b7a You are awesome, thank you!
diff --git a/tools/testing/selftests/net/Makefile b/tools/testing/selftests/net/Makefile index 8eaffd7a641c5d6bb5c63e3015fdd9f32c114550..9d5aa817411b653ac130a1a581d933180a597ce5 100644 --- a/tools/testing/selftests/net/Makefile +++ b/tools/testing/selftests/net/Makefile @@ -85,7 +85,8 @@ TEST_GEN_PROGS += so_incoming_cpu TEST_PROGS += sctp_vrf.sh TEST_GEN_FILES += sctp_hello TEST_GEN_FILES += ip_local_port_range -TEST_GEN_FILES += bind_wildcard +TEST_GEN_PROGS += bind_wildcard +TEST_GEN_PROGS += bind_timewait TEST_PROGS += test_vxlan_mdb.sh TEST_PROGS += test_bridge_neigh_suppress.sh TEST_PROGS += test_vxlan_nolocalbypass.sh
bind_wildcard is compiled but not run, bind_timewait is not compiled. These two tests complete in a very short time, use the test harness properly, and seem reasonable to enable. The author of the tests confirmed via email that these were intended to be run. Enable these two tests. Fixes: 13715acf8ab5 ("selftest: Add test for bind() conflicts.") Fixes: 2c042e8e54ef ("tcp: Add selftest for bind() and TIME_WAIT.") Signed-off-by: Jamie Bainbridge <jamie.bainbridge@gmail.com> --- tools/testing/selftests/net/Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)